Page MenuHomePhabricator

close button size is not correct
Closed, ResolvedPublic1 Story PointsBUG REPORT

Description

Steps to Reproduce:
open bridge in beta

Actual Results:
the button size is 48x48px

Expected Results:
button size should be 46x40px (width x height)

Details

Related Gerrit Patches:
mediawiki/extensions/Wikibase : masterbridge: fix close button size

Related Objects

Event Timeline

Restricted Application added a project: Wikidata. · View Herald TranscriptOct 16 2019, 10:48 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
WMDE-leszek updated the task description. (Show Details)Oct 22 2019, 9:18 AM
WMDE-leszek set the point value for this task to 1.Oct 22 2019, 9:20 AM
WMDE-leszek moved this task from Ready to estimate to Ready to pick up on the Wikidata-Bridge board.

Change 545211 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: fix close button size

https://gerrit.wikimedia.org/r/545211

Change 545211 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: fix close button size

https://gerrit.wikimedia.org/r/545211

Charlie_WMDE closed this task as Resolved.Oct 22 2019, 12:18 PM
Charlie_WMDE claimed this task.

looks good! i found 2 other things for which I'm opening separate tickets.