Page MenuHomePhabricator

Opening a dialog (f.e. link dialog) in 2010 wikitext editor results in JS “setTabindexes is not a function” error
Closed, ResolvedPublic

Description

Uncaught TypeError: $.wikiEditor.modules.dialogs.fn.setTabindexes is not a function
    at HTMLDivElement.init (load.php?lang=en&modules=ext.wikiEditor&skin=vector&version=zwztj:50)
    at Function.each (load.php?lang=en&modules=ext.CodeMirror.lib|jquery%2Coojs-ui-core%2Coojs-ui-widgets|oojs-ui.styles.icons-editing-advanced&skin=vector&version=8km3h:259)
    at jQuery.fn.init.each (load.php?lang=en&modules=ext.CodeMirror.lib|jquery%2Coojs-ui-core%2Coojs-ui-widgets|oojs-ui.styles.icons-editing-advanced&skin=vector&version=8km3h:257)
    at Object.reallyCreate (load.php?lang=en&modules=ext.wikiEditor&skin=vector&version=zwztj:44)
    at Object.openDialog (load.php?lang=en&modules=ext.wikiEditor&skin=vector&version=zwztj:42)
    at jQuery.fn.init.$.fn.wikiEditor (load.php?lang=en&modules=ext.wikiEditor&skin=vector&version=zwztj:12)
    at Object.doAction (load.php?lang=en&modules=ext.wikiEditor&skin=vector&version=zwztj:18)
    at load.php?lang=en&modules=ext.wikiEditor&skin=vector&version=zwztj:19
    at OoUiButtonWidget.OO.EventEmitter.emit (<anonymous>:173:483)
    at OoUiButtonWidget.OO.ui.mixin.ButtonElement.onClick (load.php?lang=en&modules=ext.CodeMirror.lib|jquery%2Coojs-ui-core%2Coojs-ui-widgets|oojs-ui.styles.icons-editing-advanced&skin=vector&version=8km3h:433)

Details

Related Gerrit Patches:
mediawiki/extensions/WikiEditor : wmf/1.35.0-wmf.2Revert "Remove use of jquery.tabIndex in jquery.wikiEditor.dialogs.js"
mediawiki/extensions/WikiEditor : masterRemove use of jquery.tabIndex (take 2)
mediawiki/extensions/WikiEditor : masterRevert "Remove use of jquery.tabIndex in jquery.wikiEditor.dialogs.js"

Event Timeline

Volker_E created this task.Oct 16 2019, 7:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 16 2019, 7:32 PM
Krinkle claimed this task.Oct 16 2019, 8:59 PM
Krinkle added a project: Performance-Team.

Change 543694 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/WikiEditor@master] Revert "Remove use of jquery.tabIndex in jquery.wikiEditor.dialogs.js"

https://gerrit.wikimedia.org/r/543694

Change 543695 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/WikiEditor@master] Remove more setTabindexes() calls

https://gerrit.wikimedia.org/r/543695

Krinkle closed this task as Resolved.Oct 16 2019, 9:05 PM
Krinkle reassigned this task from Krinkle to Jdforrester-WMF.
Krinkle triaged this task as Unbreak Now! priority.

Change 543696 had a related patch set uploaded (by Krinkle; owner: Jforrester):
[mediawiki/extensions/WikiEditor@wmf/1.35.0-wmf.2] Revert "Remove use of jquery.tabIndex in jquery.wikiEditor.dialogs.js"

https://gerrit.wikimedia.org/r/543696

Change 543694 merged by jenkins-bot:
[mediawiki/extensions/WikiEditor@master] Revert "Remove use of jquery.tabIndex in jquery.wikiEditor.dialogs.js"

https://gerrit.wikimedia.org/r/543694

Change 543695 merged by jenkins-bot:
[mediawiki/extensions/WikiEditor@master] Remove use of jquery.tabIndex (take 2)

https://gerrit.wikimedia.org/r/543695

Change 543696 merged by jenkins-bot:
[mediawiki/extensions/WikiEditor@wmf/1.35.0-wmf.2] Revert "Remove use of jquery.tabIndex in jquery.wikiEditor.dialogs.js"

https://gerrit.wikimedia.org/r/543696

Mentioned in SAL (#wikimedia-operations) [2019-10-16T21:53:53Z] <jforrester@deploy1001> Synchronized php-1.35.0-wmf.2/extensions/WikiEditor: T235701 Revert removal of jquery.tabIndex (duration: 00m 59s)

happy5214 moved this task from Backlog to Closed on the WikiEditor board.Wed, Nov 20, 8:38 AM