Page MenuHomePhabricator

Discuss and decide on underspecified behavior for anonymous users
Open, Needs TriagePublic

Description

While working on the first baseline patch for T233813: Separate user preferences for Page previews and Reference previews, we realized the behavior for anonymous users is currently underspecified. As of now:

Questions:

Notice we might have three different popup types later via T208758: Display popups for annotated <math> tags.

Suggested baseline (a.k.a. "cheapest way to make it not obviously broken"):

  • Make sure the current cookie solution indeed disables all popup types.
  • Change all relevant messages to talk about all popup types, not only page previews.
  • Tackle T234205 soon-ish.

Event Timeline

Restricted Application added a project: Design. · View Herald TranscriptOct 17 2019, 9:35 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
thiemowmde updated the task description. (Show Details)Oct 17 2019, 9:37 AM

Adding to @ovasileva and @alexhollender's radar in case they're interested in this change.

Some thoughts from my side:

  • I think both preview types should be enabled by default
  • I think having a cog on reference previews (as suggested in T234205: Add cog wheel to the popup to disable ReferencePreviews) would probably be the best way to go in terms of consistency - I think we definitely want to stay away from having different optin/optout mechanicsms for two similar features
  • I'm not sure if a single setting or checkboxes makes more sense, but I agree that both should probably appear within the same modal. So the workflow could be something like: open a page preview or reference preview --> select the cog --> settings modal opens --> select which preview type you would like to enable/disable. To turn back on, select "enable previews" from the footer and that opens the settings modal.

For now, I agree that the baseline suggested makes sense!

I agree with T235737#5639644. Here are two ways we could do that:

Option A

click on setting icon on either reference or page previewsettings modal appearsuser can reveal individual settings

Option B

click on setting icon on either reference or page previewsettings modal appears with individual settings