Replace deprecated block methods in CheckUser
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Tchanders
	Oct 17 2019, 1:52 PM

Description

CheckUser uses the deprecated method User::isBlocked, and should be updated to use User::getBlock instead.

Since we're starting work on this extension we could check that it is up-to-date with all the block changes we've made, by:

searching for methods and properties deprecated since 1.33
updating any we find

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/CheckUser	master	+3 -3	Replace calls to deprecated User::isBlocked

Customize query in gerrit

Event Timeline

Tchanders created this task.Oct 17 2019, 1:52 PM

Restricted Application added subscribers: MGChecker, Aklapper. · View Herald TranscriptOct 17 2019, 1:52 PM

Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.Oct 17 2019, 1:58 PM

Aklapper added a project: Technical-Debt.Oct 17 2019, 4:20 PM

Niharika triaged this task as Medium priority.Oct 17 2019, 6:07 PM

Niharika set the point value for this task to 2.

Niharika moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.

Niharika moved this task from Cards ready for development to The Letter Song on the Anti-Harassment board.Oct 21 2019, 11:59 AM

Niharika edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.

Change 545383 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/CheckUser@master] Replace calls to deprecated User::isBlocked

https://gerrit.wikimedia.org/r/545383

gerritbot added a project: Patch-For-Review.Oct 22 2019, 7:44 PM

The repo was fairly up-to-date - only found User::isBlocked of the deprecated block methods.

Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Oct 22 2019, 7:45 PM

dbarratt assigned this task to Tchanders.Oct 22 2019, 9:05 PM

Change 545383 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Replace calls to deprecated User::isBlocked

https://gerrit.wikimedia.org/r/545383

Tchanders closed this task as Resolved.Oct 23 2019, 3:49 PM

Tchanders moved this task from Code Review 🔍 to Done (2019-20: Q2) on the Anti-Harassment (The Letter Song) board.

Maintenance_bot removed a project: Patch-For-Review.Oct 23 2019, 4:10 PM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.4; 2019-10-29).Oct 24 2019, 12:00 AM

Replace deprecated block methods in CheckUserClosed, ResolvedPublic2 Estimated Story PointsActions

Description

Details

Event Timeline

Replace deprecated block methods in CheckUser
Closed, ResolvedPublic2 Estimated Story Points
Actions