Page MenuHomePhabricator
Create Task
Maniphest T235765

immediate kicking in of the Bridge: Attach link listeners sooner
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

As as user I want links which qualify for bridge to truly opened in bridge.

Problem:
If a user clicks the edit pen too quickly after loading the page then the Bridge hasn't finished loading and the user gets thrown to Wikidata instead.

BDD
GIVEN an article
AND a Bridge-enabled infobox
WHEN loading the page
AND clicking the edit pen shortly afterwards
THEN the Bridge opens

Acceptance criteria:

  • time between page loading and user not being sent to Wikidata after a click is reduced
  • loading of the application and attaching of click handlers to links is parallelized (the latter does not wait for the former to complete)
  • the criteria which links qualify are unchanged

Info

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
bridge: attach link listeners as soon as possiblemediawiki/extensions/Wikibasemaster+111 -35
Customize query in gerrit

Related Objects

Event Timeline

• Pablo-WMDE created this task.Oct 17 2019, 2:17 PM
Restricted Application added a project: Wikidata. · View Herald TranscriptOct 17 2019, 2:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• Pablo-WMDE renamed this task from Attach link listeners to Attach link listeners sooner.Oct 17 2019, 2:17 PM
Lucas_Werkmeister_WMDE merged a task: T235767: Attach event handlers to Data Bridge links as soon as possible.Oct 17 2019, 2:22 PM
Lucas_Werkmeister_WMDE subscribed.
• Pablo-WMDE mentioned this in T233305: delayed kicking in of Bridge.Oct 18 2019, 1:28 PM
Lydia_Pintscher renamed this task from Attach link listeners sooner to immediate kicking in of the Bridge: Attach link listeners sooner.Nov 1 2019, 1:37 PM
Lydia_Pintscher updated the task description. (Show Details)
Lydia_Pintscher moved this task from Needs work to Ready to estimate on the Wikidata-Bridge board.
Lydia_Pintscher triaged this task as Medium priority.Nov 4 2019, 10:02 PM
Lydia_Pintscher updated the task description. (Show Details)Nov 5 2019, 10:05 AM
Michael mentioned this in T237368: Track bridge opening performance.Nov 5 2019, 10:57 AM
• Pablo-WMDE added a comment.Nov 5 2019, 11:31 AM

Some inspiration for how this could be measured can be found in @Lucas_Werkmeister_WMDE post T233305#5555763

Lydia_Pintscher set the point value for this task to 3.Nov 5 2019, 11:41 AM
Lydia_Pintscher moved this task from Ready to estimate to Ready to pick up on the Wikidata-Bridge board.Nov 5 2019, 11:47 AM
Addshore subscribed.Nov 5 2019, 12:12 PM
Lucas_Werkmeister_WMDE claimed this task.Nov 13 2019, 4:11 PM
Lucas_Werkmeister_WMDE edited projects, added Wikidata-Bridge-Sprint-9; removed Wikidata-Bridge.
Lucas_Werkmeister_WMDE moved this task from To do to Doing on the Wikidata-Bridge-Sprint-9 board.
Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Bridge-Sprint-9 board.Nov 13 2019, 5:34 PM
gerritbot added a comment.Nov 13 2019, 5:34 PM

Change 550724 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: attach link listeners as soon as possible

https://gerrit.wikimedia.org/r/550724

gerritbot added a project: Patch-For-Review.Nov 13 2019, 5:34 PM
gerritbot added a comment.Nov 14 2019, 1:45 PM

Change 550724 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: attach link listeners as soon as possible

https://gerrit.wikimedia.org/r/550724

Lucas_Werkmeister_WMDE moved this task from Peer Review to Verification on the Wikidata-Bridge-Sprint-9 board.Nov 14 2019, 2:00 PM

Moving to Verification, though I’m not sure to what extent this can be verified independently.

Maintenance_bot removed a project: Patch-For-Review.Nov 14 2019, 2:11 PM
darthmon_wmde added subscribers: Lydia_Pintscher, darthmon_wmde.Nov 15 2019, 5:17 PM

These are things that will be checked in the performance review. For now I don't think there is verification needed, unless @Lydia_Pintscher thinks differently.

darthmon_wmde added a comment.Nov 15 2019, 5:21 PM

Do you have data for the first acceptance criteria?

  1. form how long to how long has the time between page loading and user not being sent to Wikidata been reduced?
Lydia_Pintscher added a comment.Nov 18 2019, 9:53 AM

I just gave it a try on beta and I'm happy with the result.

Lucas_Werkmeister_WMDE added a comment.Nov 18 2019, 11:59 AM
In T235765#5667386, @darthmon_wmde wrote:

Do you have data for the first acceptance criteria?

I mentioned some numbers from my local system in the commit message:

On my system, the time between the beginning of the init function and the click handlers being attached went down from 280±34 ms to 8±2 ms.

I don’t know how to measure that on the beta cluster, though, not without T237368.

Lucas_Werkmeister_WMDE closed this task as Resolved.Nov 18 2019, 1:00 PM
Lucas_Werkmeister_WMDE moved this task from Verification to Done on the Wikidata-Bridge-Sprint-9 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits