generate_family_file.py crashes when run against private wikis
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	gbenson
	Oct 17 2019, 2:21 PM

Description

Steps to Reproduce:

./generate_family_file.py https://privatewiki.example.com/wiki/ privatefamily

Actual Results:

Generating family file from https://privatewiki.example.com/wiki/
Private wiki detected. Login is required.
Please enter your username? Valid User
Traceback (most recent call last):
  File "generate_family_file.py", line 227, in <module>
    FamilyFileGenerator(*sys.argv[1:]).run()
  File "generate_family_file.py", line 56, in run
    self.wikis[w.lang] = w
AttributeError: 'MWSite' object has no attribute 'lang'
CRITICAL: Exiting due to uncaught exception <class 'AttributeError'>

You get some extra info if you force logging on:

VERBOSE:pywiki:MW 1.17+ detection failed: TypeError('Abstract Family class Family cannot be instantiated; subclass it instead',)

Details

	Subject	Repo	Branch	Lines +/-
	[bugfix] Fix generate_family_file.py for private wikis	pywikibot/core	master	+110 -8

Customize query in gerrit

Related Objects

Mentioned In: rPWBCf9c2a88dad09: [bugfix] Fix generate_family_file.py for private wikis

Event Timeline

gbenson created this task.Oct 17 2019, 2:21 PM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptOct 17 2019, 2:21 PM

What is the output of python pwb.py version?

family and mylang are not set.
Defaulting to family='test' and mylang='test'.
Pywikibot: [ssh] home-gary-git-pywikibot (457ec40, g11595, 2019/10/17, 16:40:40, OUTDATED)
Release version: 3.1.dev0
requests version: 2.22.0
  cacerts: /home/gary/.local/lib/python3.6/site-packages/certifi/cacert.pem
    certificate test: ok
Python: 3.6.8 (default, Jun 11 2019, 15:15:01) 
[GCC 4.8.5 20150623 (Red Hat 4.8.5-39)]
PYWIKIBOT_DIR: Not set
PYWIKIBOT_DIR_PWB: 
PYWIKIBOT_NO_USER_CONFIG: Not set
Config base dir: /home/gary/projects/pywikibot

It's more-or-lest recent git, with the patch from https://gerrit.wikimedia.org/r/542456 on top.

The error message is not clear, but it seems to me Pywikibot can not detect wiki API at the url given. MWSite should change to Site immediately after MediaWiki API is found, thus lang should work correctly after that, which it doesn't. What MW version does your wiki use?

Or wiki API has been detected, but Pywikibot can not read from API somehow. Anyway this only happens with your patch, I hope this is the issue of yout implementation then.

And I agree with @zhuyifei1999, you should save the login credentials to your OS connection config and not deal with them inside Pywikibot's code, at least not this way at this place on every fetch. This just doesn't look right to me and I'm not much surprised it does not actually work.

Xqt triaged this task as Medium priority.Oct 17 2019, 11:18 PM

Xiplus subscribed.Oct 18 2019, 1:09 AM

Change 543107 had a related patch set uploaded (by Gary Benson; owner: Gary Benson):
[pywikibot/core@master] [bugfix] Fix generate_family_file.py for private wikis

https://gerrit.wikimedia.org/r/543107

gerritbot added a project: Patch-For-Review.Oct 18 2019, 9:06 AM

@Dvorapa, change 542456 is unrelated to this failure, I can reproduce this failure with unmodified PyWikibot.

I've uploaded an updated fix for this task, change 543107, with a testcase:

nosetests-3 -v tests.site_detect_tests.PrivateWikiTestCase

You can revert the fix and watch the test fail :)

Framawiki assigned this task to gbenson.Oct 27 2019, 9:45 AM

Framawiki moved this task from Backlog to Needs Review on the Pywikibot board.

Change 543107 merged by jenkins-bot:
[pywikibot/core@master] [bugfix] Fix generate_family_file.py for private wikis

https://gerrit.wikimedia.org/r/543107

gbenson mentioned this in rPWBCf9c2a88dad09: [bugfix] Fix generate_family_file.py for private wikis.Nov 14 2019, 7:24 AM

zhuyifei1999 closed this task as Resolved.Nov 14 2019, 7:24 AM

Maintenance_bot removed a project: Patch-For-Review.Nov 14 2019, 8:10 AM

generate_family_file.py crashes when run against private wikisClosed, ResolvedPublicBUG REPORTActions

Description

Details

Related Objects

Event Timeline

generate_family_file.py crashes when run against private wikis
Closed, ResolvedPublicBUG REPORT
Actions