Page MenuHomePhabricator
Create Task
Maniphest T235779

Implement basic routing for rest.php
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Description

As described in T235478, Varnish configuration is needed in order to correctly serve the basic MW REST API endpoints. An initial version can be built by expanding the restBase regex.

Requirements

  • Expand the config handling request URI normalisation to include the MW REST API
  • Config is reveiwed by SRE Traffic Team
  • Config is deployed in prod
  • Endpoints are accessible publicly as expected

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Varnish: don't decode/encode slashes for core REST API pathsoperations/puppetproduction+1 -1
Customize query in gerrit

Related Objects

Event Timeline

• WDoranWMF created this task.Oct 17 2019, 3:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 17 2019, 3:55 PM
• WDoranWMF triaged this task as High priority.Oct 17 2019, 3:56 PM
• WDoranWMF set the point value for this task to 3.
• WDoranWMF moved this task from Next Sprint to Ready on the Platform Team Workboards (Green) board.
• WDoranWMF mentioned this in T235782: Specify Canonical Version of MW REST API URI.Oct 17 2019, 4:04 PM
• Pchelolo moved this task from Ready to Waiting for Review on the Platform Team Workboards (Green) board.Oct 22 2019, 6:29 PM
gerritbot added a comment.Oct 22 2019, 6:37 PM

Change 545369 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[operations/puppet@production] Varnish: don't decode/encode slashes for core REST API paths.

https://gerrit.wikimedia.org/r/545369

gerritbot added a project: Patch-For-Review.Oct 22 2019, 6:37 PM
gerritbot added a comment.Oct 22 2019, 7:05 PM

Change 545369 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[operations/puppet@production] Varnish: don't decode/encode slashes for core REST API paths

https://gerrit.wikimedia.org/r/545369

• Pchelolo subscribed.Oct 22 2019, 7:09 PM

The patch has been applied in beta cluster, so URIs like https://en.wikipedia.beta.wmflabs.org/w/rest.php/v1/page/User:Pchelolo%2fTest/history work now.

Any help would be much appreciated in testing access for pages with weird symbols (see examples in VCL. Weird are the ones that have 1 or 2 underneath them in that config)

• WDoranWMF added subscribers: • ema, BBlack.EditedOct 23 2019, 1:56 PM

@Pchelolo What are the testing asks?

• WDoranWMF added a project: Traffic.Oct 24 2019, 9:46 PM

@BBlack @ema would you have anytime to review Petr's patch above?

Restricted Application added a project: SRE. · View Herald TranscriptOct 24 2019, 9:46 PM
gerritbot added a comment.Oct 28 2019, 8:37 AM

Change 545369 merged by Ema:
[operations/puppet@production] Varnish: don't decode/encode slashes for core REST API paths

https://gerrit.wikimedia.org/r/545369

• ema added a comment.Oct 28 2019, 8:38 AM
In T235779#5604796, @WDoranWMF wrote:

@BBlack @ema would you have anytime to review Petr's patch above?

Patch merged.

• WDoranWMF added a comment.Oct 28 2019, 12:13 PM

Awesome, thanks @ema !

• ema moved this task from Backlog to Radar/Not for Service on the Traffic board.Oct 28 2019, 3:59 PM
• Pchelolo moved this task from Waiting for Review to Done on the Platform Team Workboards (Green) board.Oct 28 2019, 9:10 PM
• eprodromou closed this task as Resolved.Oct 29 2019, 4:36 PM
• eprodromou claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits