Query isn't fetching a full 10 images
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	AnneT
	Oct 17 2019, 9:53 PM

Description

When I run the unreviewed image query, with or without a user ID passed in, I get back an unpredictable number of results, usually 2-6. This is happening on this patch, where only 1 query should ever be running at a time.

The total # of items I have locally is ~30. In addition to that, I have a bunch of deleted images, where I deleted the filepage for an image I uploaded.

Steps to Reproduce:

Check out the patch linked above locally
Upload a few images (you really need more than 10 to test this thoroughly...)
Delete some of their filepages
Load the special page and observe the total number of images found by the query, and the number of results you're getting per API call

Actual Results:

You'll see fewer than 10 images per API call

Expected Results:

Each API call returns 10 images, until you run out of images on the final call

Details

	Subject	Repo	Branch	Lines +/-
	add hook onFileDeleteComplete to clean data	mediawiki/extensions/MachineVision	master	+86 -2

Customize query in gerrit

Event Timeline

AnneT created this task.Oct 17 2019, 9:53 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 17 2019, 9:53 PM

The patch mentioned in this task has been merged so you can see this on master now.

LGoto triaged this task as High priority.Oct 22 2019, 3:47 PM

LGoto edited projects, added Product-Infrastructure-Team-Backlog-Deprecated (Kanban); removed Product-Infrastructure-Team-Backlog-Deprecated.

• Mholloway removed • Mholloway as the assignee of this task.Oct 22 2019, 3:47 PM

• Mholloway subscribed.

MSantos claimed this task.Oct 22 2019, 6:07 PM

MSantos moved this task from To Do to Doing on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.

MSantos moved this task from Under discussion to In development on the MachineVision board.Oct 22 2019, 6:40 PM

MSantos updated the task description. (Show Details)Oct 22 2019, 6:42 PM

Change 545592 had a related patch set uploaded (by MSantos; owner: MSantos):
[mediawiki/extensions/MachineVision@master] WIP: add hook onFileDeleteComplete to clean data

https://gerrit.wikimedia.org/r/545592

gerritbot added a project: Patch-For-Review.Oct 23 2019, 3:13 PM

MSantos moved this task from Doing to Code Review on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Oct 24 2019, 3:17 PM

Change 545592 merged by jenkins-bot:
[mediawiki/extensions/MachineVision@master] add hook onFileDeleteComplete to clean data

https://gerrit.wikimedia.org/r/545592

Maintenance_bot removed a project: Patch-For-Review.Oct 25 2019, 4:10 PM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.4; 2019-10-29).Oct 25 2019, 5:01 PM

• Mholloway moved this task from In development to Done on the MachineVision board.Oct 29 2019, 2:14 PM

MSantos moved this task from Code Review to To Deploy on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Oct 29 2019, 3:36 PM

• Mholloway moved this task from To Deploy to Sign off on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Nov 5 2019, 3:29 PM

• Mholloway closed this task as Resolved.Nov 8 2019, 2:05 PM