Page MenuHomePhabricator

Remove 'mediawiki.ui.icon'
Open, Stalled, HighPublic

Description

Current search reveals usage of 'mediawiki.ui.icon' module in

Phase 1

  • ULS
  • MMV
  • Popups
  • Minerva and MobileFrontend
  • Mark module as deprecated

Phase 2 - all usages

  • ContentTranslation (covered in T340259)
  • On April 29th we (Bartosz, Jon Robson) removed support for the unused mw-ui-icon-small and mw-ui-icon-flush-top and mw-ui-icon-flush-left to avoid further adoption.

Phase 3

  • Flow/includes/View.php <doing>
  • Example skin
  • Remove 'mediawiki.ui.icon' module

All of above usages should be removed and replaced by Codex (/OOUI) icon modules. And the module itself be removed as result.

Event Timeline

Jdlrobson changed the task status from Open to Stalled.Oct 23 2019, 5:27 PM

I'm not sure what the practical replacement would be. Ideally they'd be a mixin exposed by wikimedia UI for these cases. We are not going to be able to ship an entire OOjs UI stylesheet just to render a single icon in Popups, which loads on all pages, are we?

Unless you have an exact solution in mind for how to use OOUI in Popups, I think is stalled on T159738.
Personally I think this is not a top priority right now.

Jdlrobson updated the task description. (Show Details)

ContentTranslation and Flow are the last remaining consumers of this library.

I don't think the Flow case is worth tackling given it's planned undeploy, T350164. Unless that is blocking the removal of the module.

Volker_E updated the task description. (Show Details)
Volker_E updated the task description. (Show Details)

Change #1025416 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Remove unused .mw-ui-icon-flush-top, -left, -right classes

https://gerrit.wikimedia.org/r/1025416

Change #1025417 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Remove unused .mw-ui-icon-small class

https://gerrit.wikimedia.org/r/1025417

Change #1025416 merged by jenkins-bot:

[mediawiki/core@master] Remove unused .mw-ui-icon-flush-top, -left, -right classes

https://gerrit.wikimedia.org/r/1025416

Change #1025417 merged by jenkins-bot:

[mediawiki/core@master] Remove unused .mw-ui-icon-small class

https://gerrit.wikimedia.org/r/1025417