Page MenuHomePhabricator
Create Task
Maniphest T235937

Remove 'mediawiki.ui.icon'
Open, Stalled, HighPublic
Actions

Description

Current search reveals usage of 'mediawiki.ui.icon' module in

Phase 1

  • ULS
  • MMV
  • Popups
  • Minerva and MobileFrontend
  • Mark module as deprecated

Phase 2 - all usages

  • ContentTranslation (covered in T340259)
  • On April 29th we (Bartosz, Jon Robson) removed support for the unused mw-ui-icon-small and mw-ui-icon-flush-top and mw-ui-icon-flush-left to avoid further adoption.

Phase 3

  • Flow/includes/View.php <doing>
  • Example skin
  • Remove 'mediawiki.ui.icon' module

All of above usages should be removed and replaced by Codex (/OOUI) icon modules. And the module itself be removed as result.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove unused .mw-ui-icon-small classmediawiki/coremaster+0 -28
Remove unused .mw-ui-icon-flush-top, -left, -right classesmediawiki/coremaster+0 -37
Customize query in gerrit

Related Objects
Search...

Event Timeline

Volker_E created this task.Oct 19 2019, 4:20 AM
Volker_E updated the task description. (Show Details)
Masumrezarock100 moved this task from Unsorted to mediawiki.ui on the UI-Standardization board.Oct 19 2019, 4:50 AM
Jdlrobson changed the task status from Open to Stalled.Oct 23 2019, 5:27 PM
Jdlrobson added a subtask: T159738: Limit default styles loaded by OOUI (65kb after gzipping penalty to run a QuickSurveys) by droping use of oojs-ui-widgets .

I'm not sure what the practical replacement would be. Ideally they'd be a mixin exposed by wikimedia UI for these cases. We are not going to be able to ship an entire OOjs UI stylesheet just to render a single icon in Popups, which loads on all pages, are we?

Unless you have an exact solution in mind for how to use OOUI in Popups, I think is stalled on T159738.
Personally I think this is not a top priority right now.

Jdlrobson closed subtask T159738: Limit default styles loaded by OOUI (65kb after gzipping penalty to run a QuickSurveys) by droping use of oojs-ui-widgets as Declined.Jun 4 2021, 4:18 PM
Jdlrobson edited subtasks, added: T340256: Popups: Use Codex markup for buttons instead of mediawiki.ui markup, T340258: MMV should use Codex instead of mediawiki ui; removed: T159738: Limit default styles loaded by OOUI (65kb after gzipping penalty to run a QuickSurveys) by droping use of oojs-ui-widgets .Jun 23 2023, 8:54 PM
Jdlrobson added a subtask: T340259: ContentTranslation shouldn't use mediawiki.ui modules.
Jdlrobson updated the task description. (Show Details)
Jdlrobson triaged this task as High priority.Jun 23 2023, 9:02 PM
Jdlrobson added a project: Web-Team-Backlog-Archived (Needs Prioritization (Tech)).
Jdlrobson moved this task from Backlog to Adopt Codex in Vector 2022 and Minerva on the Web-Team-Backlog-Archived (Needs Prioritization (Tech)) board.
Jdlrobson updated the task description. (Show Details)Jun 23 2023, 9:06 PM
Jdlrobson updated the task description. (Show Details)
Edtadros closed subtask T340256: Popups: Use Codex markup for buttons instead of mediawiki.ui markup as Resolved.Jul 17 2023, 4:26 PM
Jdlrobson closed subtask T340262: Use Codex CSS Button components inside MobileFrontend as Resolved.Aug 3 2023, 1:35 AM
Jdlrobson removed a project: Web-Team-Backlog-Archived (Needs Prioritization (Tech)).Sep 18 2023, 9:25 PM

All web team usages have been cleaned up.

Jdlrobson updated the task description. (Show Details)Sep 18 2023, 9:25 PM
Jdlrobson added projects: StructuredDiscussions, ContentTranslation.Sep 28 2023, 11:15 PM

ContentTranslation and Flow are the last remaining consumers of this library.

Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 28 2023, 11:15 PM
Jdlrobson updated the task description. (Show Details)Sep 28 2023, 11:16 PM
Jdlrobson closed subtask T340258: MMV should use Codex instead of mediawiki ui as Resolved.
Aklapper updated the task description. (Show Details)Oct 3 2023, 7:46 AM
Pginer-WMF updated the task description. (Show Details)Nov 20 2023, 11:21 AM
Pginer-WMF moved this task from Needs Triage to Upstream/Other teams on the ContentTranslation board.
ngkountas changed the status of subtask T340259: ContentTranslation shouldn't use mediawiki.ui modules from Open to In Progress.Jan 18 2024, 8:14 AM
Sgs subscribed.Jan 23 2024, 10:35 AM

I don't think the Flow case is worth tackling given it's planned undeploy, T350164. Unless that is blocking the removal of the module.

Urbanecm_WMF moved this task from Inbox to Triaged on the Growth-Team board.Jan 26 2024, 1:20 PM
Pginer-WMF closed subtask T340259: ContentTranslation shouldn't use mediawiki.ui modules as Resolved.Apr 2 2024, 10:27 AM
Volker_E updated the task description. (Show Details)Apr 2 2024, 7:57 PM
Volker_E updated the task description. (Show Details)
Volker_E updated the task description. (Show Details)
gerritbot added a comment.Apr 29 2024, 5:09 PM

Change #1025416 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Remove unused .mw-ui-icon-flush-top, -left, -right classes

https://gerrit.wikimedia.org/r/1025416

gerritbot added a project: Patch-For-Review.Apr 29 2024, 5:09 PM

Change #1025417 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Remove unused .mw-ui-icon-small class

https://gerrit.wikimedia.org/r/1025417

gerritbot added a comment.Apr 29 2024, 8:42 PM

Change #1025416 merged by jenkins-bot:

[mediawiki/core@master] Remove unused .mw-ui-icon-flush-top, -left, -right classes

https://gerrit.wikimedia.org/r/1025416

gerritbot added a comment.Apr 29 2024, 8:44 PM

Change #1025417 merged by jenkins-bot:

[mediawiki/core@master] Remove unused .mw-ui-icon-small class

https://gerrit.wikimedia.org/r/1025417

Jdlrobson updated the task description. (Show Details)Apr 29 2024, 8:50 PM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.3; 2024-04-30).Apr 29 2024, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 29 2024, 9:30 PM
Pppery subscribed.Oct 14 2024, 5:30 PM
Volker_E edited projects, added Design-System-Team; removed UI-Standardization.Feb 13 2025, 4:56 AM
Volker_E moved this task from Inbox to Following on the Design-System-Team board.
Nikerabbit removed a project: ContentTranslation.Jun 2 2025, 2:00 PM
Pppery unsubscribed.Jun 2 2025, 2:16 PM
Pppery subscribed.
Urbanecm_WMF removed a project: Growth-Team.Oct 28 2025, 12:27 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits