MailGun extension needs php-http/guzzle6-adapter in require not require-dev
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Addshore
	Oct 19 2019, 5:07 PM

Description

The guzzle 6 adapter is listed as a require-dev package in composer.json: https://gerrit.wikimedia.org/g/mediawiki/extensions/Mailgun/+/9ba8e0d5a86936473c804fe93997bea8048ae506/composer.json#11

But it is used in "production" code.
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Mailgun/+/master/MailgunHooks.php#46

This results in the following error when creating accounts with the extension enabled.

[803b5fd8f6b4fed2c4ed6c32] /w/index.php?title=Special:CreateAccount&returnto=Special:SpecialPages Error from line 46 of /var/www/html/extensions/Mailgun/MailgunHooks.php: Class 'Http\Adapter\Guzzle6\Client' not found

The fix is to move php-http/guzzle6-adapter from require-dev to require in the composer.json file.

Details

	Subject	Repo	Branch	Lines +/-
	Move php-http/guzzle6-adapter in require	mediawiki/extensions/Mailgun	master	+2 -2

Customize query in gerrit

Related Objects

Mentioned In: T241645: Bump up Mailgun library to v3.0.0
rEMLGc6f41b1db544: Move php-http/guzzle6-adapter in require
Mentioned Here: T206415: Mailgun extension error on 특수:이메일확인 page

Event Timeline

Addshore created this task.Oct 19 2019, 5:07 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 19 2019, 5:07 PM

Daimona added a project: good first task.Oct 19 2019, 6:25 PM

@Daimona: What would be the fix? Move from require-dev to require? Asking as it's not clear for me if I was a new contributor... Also see the tag description at https://phabricator.wikimedia.org/tag/good_first_bug/
Plus I think links to Github will make people think that they need to do something on Github instead of Gerrit?

In T235943#5603423, @Aklapper wrote:

@Daimona: What would be the fix? Move from require-dev to require?

Yes.

Plus I think links to Github will make people think that they need to do something on Github instead of Gerrit?

Let me change the task description a little bit.

Daimona updated the task description. (Show Details)Oct 26 2019, 6:02 PM

Thank you a lot! :) Let's leave this task open for a Google Code-in student? Happy to mentor.

This would probably also fix T206415

Imported into GCI site as https://codein.withgoogle.com/tasks/4549315935076350/

Urbanecm moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2019 board.Oct 29 2019, 7:31 PM

Kizule claimed this task.Dec 5 2019, 5:27 PM

Restricted Application added a project: User-Kizule. · View Herald TranscriptDec 5 2019, 5:27 PM

Change 554917 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/extensions/Mailgun@master] Move php-http/guzzle6-adapter in require

https://gerrit.wikimedia.org/r/554917

gerritbot added a project: Patch-For-Review.Dec 5 2019, 5:31 PM

Change 554917 merged by jenkins-bot:
[mediawiki/extensions/Mailgun@master] Move php-http/guzzle6-adapter in require

https://gerrit.wikimedia.org/r/554917

Kizule mentioned this in rEMLGc6f41b1db544: Move php-http/guzzle6-adapter in require.Dec 5 2019, 6:58 PM

01tonythomas mentioned this in T241645: Bump up Mailgun library to v3.0.0.Dec 31 2019, 12:29 PM

Kizule closed this task as Resolved.Feb 19 2020, 7:21 PM

Addshore added a project: wbstack.Dec 6 2020, 5:40 PM

Maintenance_bot removed a project: Patch-For-Review.Dec 6 2020, 6:10 PM