Page MenuHomePhabricator

Special:PopularPages shows german alias in every language
Closed, ResolvedPublicBUG REPORT

Description

The defined german aliases overwrite the english alias in HitCounters.i18n.ailas.php

Event Timeline

Pwirth created this task.Oct 21 2019, 7:25 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 21 2019, 7:25 AM

Change 544658 had a related patch set uploaded (by Pwirth; owner: Pwirth):
[mediawiki/extensions/HitCounters@master] Fix german alias displayed in every language. T236012

https://gerrit.wikimedia.org/r/544658

Change 544658 merged by jenkins-bot:
[mediawiki/extensions/HitCounters@master] Fix german alias displayed in every language. T236012

https://gerrit.wikimedia.org/r/544658

Since this was request to me by a customer using REL1_31
Can this be cherry-picked down every REL_* branch until (including) REL1_31?

Reedy renamed this task from Specialpage Special:PopularPages shows german alias in every language to Special:PopularPages shows german alias in every language.Oct 21 2019, 11:41 AM
Reedy added a subscriber: Reedy.

Since this was request to me by a customer using REL1_31
Can this be cherry-picked down every REL_* branch until (including) REL1_31?

Feel free

Change 544920 had a related patch set uploaded (by Kghbln; owner: Pwirth):
[mediawiki/extensions/HitCounters@REL1_31] Fix German alias displayed in every language. T236012

https://gerrit.wikimedia.org/r/544920

Kghbln added a subscriber: Kghbln.EditedOct 21 2019, 1:52 PM

By coincidence I just wanted to fix this issue myself and found that someone was a couple of hours faster. Thanks a ton.

I just created the commit for this to be back-ported to REL1_31.

Change 544920 merged by Reedy:
[mediawiki/extensions/HitCounters@REL1_31] Fix German alias displayed in every language. T236012

https://gerrit.wikimedia.org/r/544920

Change 544925 had a related patch set uploaded (by Reedy; owner: Pwirth):
[mediawiki/extensions/HitCounters@REL1_32] Fix german alias displayed in every language. T236012

https://gerrit.wikimedia.org/r/544925

Change 544926 had a related patch set uploaded (by Reedy; owner: Pwirth):
[mediawiki/extensions/HitCounters@REL1_33] Fix german alias displayed in every language. T236012

https://gerrit.wikimedia.org/r/544926

Change 544927 had a related patch set uploaded (by Reedy; owner: Pwirth):
[mediawiki/extensions/HitCounters@REL1_34] Fix german alias displayed in every language. T236012

https://gerrit.wikimedia.org/r/544927

Kghbln closed this task as Resolved.Oct 21 2019, 2:08 PM

Ah, thanks @Reedy also for back-porting to the other branches. This was not absolutely necessary but a very nice service!

Change 544927 merged by jenkins-bot:
[mediawiki/extensions/HitCounters@REL1_34] Fix german alias displayed in every language. T236012

https://gerrit.wikimedia.org/r/544927

Change 544925 merged by jenkins-bot:
[mediawiki/extensions/HitCounters@REL1_32] Fix german alias displayed in every language. T236012

https://gerrit.wikimedia.org/r/544925

Change 544926 merged by jenkins-bot:
[mediawiki/extensions/HitCounters@REL1_33] Fix german alias displayed in every language. T236012

https://gerrit.wikimedia.org/r/544926

Reedy added a comment.Oct 21 2019, 2:10 PM

Ah, thanks @Reedy also for back-porting to the other branches. This was not absolutely necessary but a very nice service!

It's minimal work to do so, and it has potential benefits. So worth a few minutes time to sort :)

thank you very much!