Page MenuHomePhabricator

Bump PHPCS version in REL1_31 extensions
Closed, ResolvedPublic

Description

Following on from T236069: Make PHP 7.3 non voting on REL1_31... As we support REL1_31 until June 2021, it would be useful to upgrade PHPCS across the REL1_31 fleet

We don't need to fix the code, just adding necessary exclusions would be sufficient

Upgrade mediawiki/mediawiki-codesniffer to 19.1.0 and ignore new rules in .phpcs.xml. Example for CentralAuth REL1_31:

https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CentralAuth/+/538973/

Details

SubjectRepoBranchLines +/-
labs/libraryupgrader/configmaster+4 -0
labs/libraryupgrader/configmaster+8 -0
mediawiki/extensions/SecurePollREL1_31+1 -1
mediawiki/extensions/ParserFunctionsREL1_31+2 -2
mediawiki/extensions/SpamBlacklistREL1_31+2 -2
mediawiki/extensions/GadgetsREL1_31+2 -1
mediawiki/extensions/ReplaceTextREL1_31+2 -2
mediawiki/extensions/CategoryTreeREL1_31+2 -2
mediawiki/skins/CologneBlueREL1_31+2 -2
mediawiki/skins/MonoBookREL1_31+1 -1
mediawiki/extensions/TitleBlacklistREL1_31+1 -1
mediawiki/skins/TimelessREL1_31+1 -1
mediawiki/extensions/SyntaxHighlight_GeSHiREL1_31+1 -1
mediawiki/extensions/CiteREL1_31+1 -1
mediawiki/skins/VectorREL1_31+1 -1
mediawiki/skins/TimelessREL1_31+1 -1
mediawiki/extensions/MultimediaViewerREL1_31+1 -1
mediawiki/skins/MonoBookREL1_31+1 -1
mediawiki/extensions/RenameuserREL1_31+1 -1
mediawiki/extensions/ImageMapREL1_31+1 -1
mediawiki/extensions/PoemREL1_31+1 -1
mediawiki/extensions/LocalisationUpdateREL1_31+1 -1
mediawiki/extensions/PdfHandlerREL1_31+1 -1
mediawiki/extensions/InterwikiREL1_31+1 -1
mediawiki/extensions/NukeREL1_31+1 -1
mediawiki/extensions/InputBoxREL1_31+1 -1
mediawiki/extensions/CodeEditorREL1_31+1 -1
mediawiki/extensions/CiteThisPageREL1_31+1 -1
mediawiki/extensions/WikiEditorREL1_31+1 -1
mediawiki/vendorREL1_31+2 -1
mediawiki/extensions/OAuthREL1_31+2 -1
mediawiki/extensions/EchoREL1_31+2 -1
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

This is a dupe of T233759, right?

Or a very specific subset of it

Reedy triaged this task as High priority.Apr 6 2020, 4:35 PM

This is getting annoying when trying to backport stuff

Change 586395 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/Echo@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/586395

Change 586395 merged by jenkins-bot:
[mediawiki/extensions/Echo@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/586395

Change 640250 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/OAuth@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640250

Change 640250 merged by jenkins-bot:
[mediawiki/extensions/OAuth@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640250

Change 640525 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/skins/CologneBlue@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640525

Change 640526 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/skins/MonoBook@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640526

Change 640527 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/skins/Timeless@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640527

Change 640528 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/CategoryTree@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640528

Change 640529 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/Cite@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640529

Change 640530 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/CiteThisPage@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640530

Change 640531 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/CodeEditor@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640531

Change 640532 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/Gadgets@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640532

Change 640533 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/ImageMap@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640533

Change 640534 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/InputBox@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640534

Change 640535 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/Interwiki@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640535

Change 640536 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/LocalisationUpdate@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640536

Change 640537 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/MultimediaViewer@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640537

Change 640538 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/Nuke@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640538

Change 640539 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/ParserFunctions@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640539

Change 640540 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/PdfHandler@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640540

Change 640541 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/Poem@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640541

Change 640542 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/Renameuser@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640542

Change 640543 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/ReplaceText@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640543

Change 640544 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/SpamBlacklist@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640544

Change 640545 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/SyntaxHighlight_GeSHi@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640545

Change 640546 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/TitleBlacklist@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640546

Change 640547 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/WikiEditor@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640547

Change 640548 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/skins/MonoBook@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640548

Change 640549 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/skins/Timeless@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640549

Change 640550 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/skins/Vector@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640550

Change 640551 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/vendor@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640551

Change 640551 abandoned by Reedy:
[mediawiki/vendor@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

Reason:

https://gerrit.wikimedia.org/r/640551

Change 640547 merged by jenkins-bot:
[mediawiki/extensions/WikiEditor@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640547

Change 640530 merged by jenkins-bot:
[mediawiki/extensions/CiteThisPage@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640530

Change 640531 merged by jenkins-bot:
[mediawiki/extensions/CodeEditor@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640531

Change 640534 merged by jenkins-bot:
[mediawiki/extensions/InputBox@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640534

Change 640537 merged by jenkins-bot:
[mediawiki/extensions/MultimediaViewer@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640537

Change 640538 merged by jenkins-bot:
[mediawiki/extensions/Nuke@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640538

Change 640535 merged by jenkins-bot:
[mediawiki/extensions/Interwiki@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640535

Change 640540 merged by jenkins-bot:
[mediawiki/extensions/PdfHandler@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640540

Change 640536 merged by jenkins-bot:
[mediawiki/extensions/LocalisationUpdate@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640536

Change 640541 merged by jenkins-bot:
[mediawiki/extensions/Poem@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640541

Change 640533 merged by jenkins-bot:
[mediawiki/extensions/ImageMap@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640533

Change 640542 merged by jenkins-bot:
[mediawiki/extensions/Renameuser@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640542

Change 640548 merged by jenkins-bot:
[mediawiki/skins/MonoBook@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640548

Change 640529 merged by jenkins-bot:
[mediawiki/extensions/Cite@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640529

Change 640550 merged by jenkins-bot:
[mediawiki/skins/Vector@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640550

Change 640549 merged by jenkins-bot:
[mediawiki/skins/Timeless@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640549

Change 640545 merged by jenkins-bot:
[mediawiki/extensions/SyntaxHighlight_GeSHi@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640545

Change 640546 merged by jenkins-bot:
[mediawiki/extensions/TitleBlacklist@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640546

Change 640527 merged by jenkins-bot:
[mediawiki/skins/Timeless@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640527

Change 640526 merged by jenkins-bot:
[mediawiki/skins/MonoBook@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640526

Change 640525 merged by jenkins-bot:
[mediawiki/skins/CologneBlue@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640525

Change 640528 merged by jenkins-bot:
[mediawiki/extensions/CategoryTree@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640528

Change 640532 merged by jenkins-bot:
[mediawiki/extensions/Gadgets@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640532

Change 640543 merged by jenkins-bot:
[mediawiki/extensions/ReplaceText@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640543

Reedy lowered the priority of this task from High to Medium.Nov 10 2020, 10:03 PM

Bumping down to Medium as I've done all the remaining skins/extensions that are tarballed

Change 640539 merged by jenkins-bot:
[mediawiki/extensions/ParserFunctions@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640539

Change 640544 merged by jenkins-bot:
[mediawiki/extensions/SpamBlacklist@REL1_31] Upgrade mediawiki-codesniffer for php7.3 support

https://gerrit.wikimedia.org/r/640544

Reedy lowered the priority of this task from Medium to Low.Dec 2 2020, 2:24 AM

Bumping down to low... I did all the tarball extensions...

Change 652277 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[labs/libraryupgrader/config@master] Bump mediawiki/mediawiki-codesniffer to 19.1.0 on REL1_31

https://gerrit.wikimedia.org/r/652277

Change 652277 merged by jenkins-bot:
[labs/libraryupgrader/config@master] Bump mediawiki/mediawiki-codesniffer to 19.1.0 on REL1_31

https://gerrit.wikimedia.org/r/652277

Change 652948 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[labs/libraryupgrader/config@master] Bump wikibase/wikibase-codesniffer to 0.5.1 on REL1_31

https://gerrit.wikimedia.org/r/652948

Change 652948 merged by jenkins-bot:
[labs/libraryupgrader/config@master] Bump wikibase/wikibase-codesniffer to 0.5.1 on REL1_31

https://gerrit.wikimedia.org/r/652948