Page MenuHomePhabricator
Create Task
Maniphest T236109

User message bugs on mobile
Closed, ResolvedPublic
Actions

Description

There are a couple of bugs on mobile that have recently occurred:

  • Success message is not displaying after tags are published
  • Failure message after error on publish is not properly styled

The success message should display when tags are published, and both messages (which are toasts) should be displayed at the proper width and centered in the viewport.

Details

SubjectRepoBranchLines +/-
Fix toast message styles on mobilemediawiki/extensions/MachineVisionmaster+36 -25
Customize query in gerrit

Event Timeline

AnneT created this task.Oct 21 2019, 11:05 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 21 2019, 11:05 PM
gerritbot added a comment.Oct 22 2019, 12:56 AM

Change 545124 had a related patch set uploaded (by Anne Tomasevich; owner: Anne Tomasevich):
[mediawiki/extensions/MachineVision@master] Fix toast message styles on mobile

https://gerrit.wikimedia.org/r/545124

gerritbot added a project: Patch-For-Review.Oct 22 2019, 12:56 AM
gerritbot added a comment.Oct 22 2019, 5:37 PM

Change 545124 merged by jenkins-bot:
[mediawiki/extensions/MachineVision@master] Fix toast message styles on mobile

https://gerrit.wikimedia.org/r/545124

Maintenance_bot removed a project: Patch-For-Review.Oct 22 2019, 6:10 PM
AnneT moved this task from Backlog to Done on the MachineVision board.Oct 22 2019, 6:26 PM
AnneT moved this task from Triage to Current Work on the Structured-Data-Backlog board.
AnneT edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.
AnneT moved this task from Incoming to Code Review on the Structured-Data-Backlog (Current Work) board.
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.4; 2019-10-29).Oct 22 2019, 10:00 PM
AnneT moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Oct 28 2019, 4:23 PM
• Ramsey-WMF reassigned this task from AnneT to Edtadros.Nov 14 2019, 8:27 PM
• Ramsey-WMF triaged this task as Medium priority.
Edtadros added a subscriber: • Ramsey-WMF.Dec 16 2019, 3:16 AM

@Ramsey-WMF I'm assuming this is on the SuggestTags page. This is what I see when I successfully publish a tag:

T236109-1.gif (929×429 px, 1 MB)

Please provide steps to cause it to fail.

Edtadros reassigned this task from Edtadros to • Ramsey-WMF.Dec 16 2019, 3:16 AM
Edtadros subscribed.
• Ramsey-WMF moved this task from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.Dec 16 2019, 5:46 PM
• Ramsey-WMF closed this task as Resolved.Dec 16 2019, 9:27 PM

Hey @Edtadros thanks for the GIF of your test. That confirms that success message on mobile is fine. I was able to reproduce a fail condition in my testing and it is properly styled, so I will close this.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL