Already merged code-reviews show up on gerrit
Closed, DuplicatePublic
Actions

Assigned To

None

Authored By

	Osnard
	Oct 22 2019, 9:55 AM

Description

I just noticed that a bunch (~10) of code review appeared in gerrit that have long been merged. Example:

CR in gerrit: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/BlueSpiceFoundation/+/539616/ with commit hash de81ba25d91609f105ec7516879a8c2affb91831
The same commit already merged into branch master https://github.com/wikimedia/mediawiki-extensions-BlueSpiceFoundation/commit/de81ba25d91609f105ec7516879a8c2affb91831 (here is an actual file in master that has been added by the change: https://github.com/wikimedia/mediawiki-extensions-BlueSpiceFoundation/blob/master/tests/phpunit/ExtensionAttributeBasedRegistryTest.php)

Could this be due to yesterday's gerrit server maintenance?

What should I do with these? Review/Merge them again? Abandon them? Delete them in another way?

Related Objects

Mentioned In: T236114: check and fix some Gerrit revs
Mentioned Here: T236114: check and fix some Gerrit revs

Event Timeline

Osnard created this task.Oct 22 2019, 9:55 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 22 2019, 9:55 AM

MarcoAurelio added a project: Gerrit.Oct 22 2019, 10:58 AM

Jdforrester-WMF triaged this task as Unbreak Now! priority.Oct 22 2019, 11:28 AM

Jdforrester-WMF added a project: Release-Engineering-Team-TODO.

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptOct 22 2019, 11:28 AM

I'm seeing the same thing in MediaWiki core - several of my merged patches are showing up as open in my outgoing reviews queue.

Most obvious example is: https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/528918/, which introduced a new file, BlockErrorFormatter.php, which is present in master. (Interestingly it's an old patch set that shows up, before the file was renamed from BlockInfoFormatter.)

That's already reported: T236114

• Marostegui mentioned this in T236114: check and fix some Gerrit revs.Oct 22 2019, 11:31 AM

• Marostegui closed this task as a duplicate of T236114: check and fix some Gerrit revs.

Restricted Application removed a subscriber: Liuxinyu970226. · View Herald TranscriptOct 22 2019, 11:31 AM

Thanks @Marostegui

Jdforrester-WMF closed this task as a duplicate of T236114: check and fix some Gerrit revs.Oct 22 2019, 11:32 AM

Already merged code-reviews show up on gerritClosed, DuplicatePublicActions

Description

Related Objects

Event Timeline

Already merged code-reviews show up on gerrit
Closed, DuplicatePublic
Actions