Page MenuHomePhabricator

Already merged code-reviews show up on gerrit
Closed, DuplicatePublic

Description

I just noticed that a bunch (~10) of code review appeared in gerrit that have long been merged. Example:

Could this be due to yesterday's gerrit server maintenance?

What should I do with these? Review/Merge them again? Abandon them? Delete them in another way?

Event Timeline

Osnard created this task.Oct 22 2019, 9:55 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 22 2019, 9:55 AM
Jdforrester-WMF triaged this task as Unbreak Now! priority.Oct 22 2019, 11:28 AM
Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptOct 22 2019, 11:28 AM

I'm seeing the same thing in MediaWiki core - several of my merged patches are showing up as open in my outgoing reviews queue.

Most obvious example is: https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/528918/, which introduced a new file, BlockErrorFormatter.php, which is present in master. (Interestingly it's an old patch set that shows up, before the file was renamed from BlockInfoFormatter.)

That's already reported: T236114

Restricted Application removed a subscriber: Liuxinyu970226. · View Herald TranscriptOct 22 2019, 11:31 AM