Page MenuHomePhabricator

[stalled] close icon is too bold
Closed, DuplicatePublicBUG REPORT

Description

close size in an OOUI dialog or in the template wizard

Our close icon

As one can see, our X is much more bold than the regular icon. I am not sure why that is, since both have the width of 20px (which is correct) and the proportions seem to be right.

Expected Results:
Our close icon has the same thikness as the regular OOUI icon

Details

Related Gerrit Patches:
mediawiki/extensions/Wikibase : masterbridge: Reduce button icon size to match OOUI

Related Objects

Event Timeline

Restricted Application added a project: Wikidata. · View Herald TranscriptOct 22 2019, 12:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I vaguely remember that the way buttons were crafted for termbox (and that is where this our button originates) was very deliberate, with usability for mobile users as priority. Aside of aligning perfectly with OOUI specification, was this taken into account?
In case the decision stays that way, does that mean that this change should be upstreamed into termbox?

Change 547198 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] bridge: Reduce button icon size to match OOUI

https://gerrit.wikimedia.org/r/547198

Added a quick implementation of the requested change. Though the specifics might depend on the decisions to the questions raised by Pablo.

Good point @Pablo-WMDE will discuss with Hanna tomorrow and get back to you

@Pablo-WMDE after another chat with the UX-team we decided to revise the decision made earlier this year to stick to whatever desktop is doing and want to diverge the UI for mobile (just slightly, no worries). I think for that we should have a quick chat to sort out some details. Nonetheless, the actual icon size (not the click area) should be slimmer as indicated in the original ticket so I think this can stay as is.

@Charlie_WMDE wrote

stick to whatever desktop is doing and want to diverge the UI for mobile

This is fine, us devs want to actually work like that - it is building a responsive product, as stated in the bonfire slides.
The thing is that we don't want to get the requirements for desktop now, and the requirements for mobile in some illusive future, but we need both requirements from the get go (i.e. now).

Charlie_WMDE changed the task status from Open to Stalled.Nov 4 2019, 11:55 AM

I didn't mean some illusive future, I just meant that I don't have the updated mocks right this second. I will stall this ticket until i have made the changes.

Tonina_Zhelyazkova_WMDE renamed this task from close icon is too bold to [stalled] close icon is too bold.Tue, Nov 12, 3:16 PM
Charlie_WMDE added a comment.EditedTue, Dec 3, 2:19 PM

I think we can close this ticket in favor of this ticket T239421 since the icon size fix will be part of the overall mobile fixes.

the other ticket isn't entirely ready yet, but it'll be going through story writing/time separately anyway, since it includes more acceptance criteria than this ticket currently does