Page MenuHomePhabricator

bridge header label not centered in desktop view
Closed, InvalidPublicBUG REPORT

Description

This only applies to the modal on desktop i.e. when the viewport is bigger than 500px and not to the fullscreen mobile view

Actual Results:
The header label (here: edit property) is not centered in the modal but rather centered between the two buttons in the header

fatX.png (450×500 px, 8 KB)

Expected Results:
The header label should be centered across the whole header, NOT centered between the two buttons in the header.

normalX.png (482×500 px, 22 KB)

Related Objects

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

The example screenshots are sort of funny as they compare apples (a German one with a long button label) and oranges (an English one with a short button label).
It appears if you switch to German then the header is not centered at all...

Bildschirmfoto von 2019-10-29 12-05-25.png (1×1 px, 381 KB)

Thoughts?

@Pablo-WMDE that is very odd because when i tested it with long labels way back when it behaved the same way. Maybe it was changed in between or I absolutely snoozed while researching this. Will have a look and get back to you on that next week. thank you for the heads-up.

@Pablo, I couldn't figure out quickly weather this was changed recently or not, but what i found is that the header stays centered as long as it has about a two letter space distance to the publish button. When this space becomes to small (because the label is too long or because the viewport has shrunk (this applies to mobile too)) it centers itself between the buttons instead of the center of the modal.

I will change the ticket to reflect this behavior accordingly.

Thanks for bringing this up

closing this ticket because of inaccuracy and because I can not remove the "bug report" tag. Created a new ticket here T237518