Replace EasyDeflate with faster library
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Oct 22 2019, 8:26 PM

Description

Pako appears to be about 50-60% faster than EasyDeflate, and is the recommended replacement library for EasyDeflate which is deprecated.

The library itself is ~8,800 bytes after min and gzip, which is almost identical to the current lib.

Performance:

https://jsperf.com/js-deflate/3

Update: We also need to pick a compression level. EasyDeflate defaulted to 9, which was probably a bit high. Pako defaults to 6.

Tests at levels 1, 5 & 9:
https://jsperf.com/js-deflate/4

Details

	Subject	Repo	Branch	Lines +/-
	Use faster pako library for deflating in the client	mediawiki/core	master	+4 K -2 K
	Move deflate method to MW util and deprecate EasyDeflate module	mediawiki/core	master	+34 -17

Customize query in gerrit

Related Objects

Mentioned In: T312720: Provide a compression+decompression library
T235237: Use CompressionStream API where available (instead of Pako polyfill)
Mentioned Here: rECTX6339ab87e10b: Replace deprecated easy-deflate.deflate with mediawiki.deflate
rEVED1bb72f0bb55d: Replace deprecated easy-deflate.deflate with mediawiki.deflate
rMW87045b307679: mediawiki.deflate: Remove 'easy-deflate.deflate' module

Event Timeline

Esanders created this task.Oct 22 2019, 8:26 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 22 2019, 8:26 PM

Esanders renamed this task from Replace EasyDeflate with fast library to Replace EasyDeflate with faster library.Oct 22 2019, 8:26 PM

Esanders added a project: MediaWiki-General.

Esanders updated the task description. (Show Details)

Esanders added a subscriber: Krinkle.

Krinkle added a project: Performance-Team (Radar).Oct 22 2019, 8:40 PM

Krinkle moved this task from Limbo to Perf recommendation on the Performance-Team (Radar) board.

Reedy updated the task description. (Show Details)Oct 22 2019, 10:44 PM

Reedy edited projects, added MediaWiki-ResourceLoader; removed MediaWiki-General.

Change 545413 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/core@master] Use faster pako library for deflating in the client

https://gerrit.wikimedia.org/r/545413

gerritbot added a project: Patch-For-Review.Oct 22 2019, 10:46 PM

Krinkle moved this task from Inbox to Backlog on the MediaWiki-ResourceLoader board.Oct 23 2019, 8:00 PM

Krinkle mentioned this in T235237: Use CompressionStream API where available (instead of Pako polyfill).Oct 24 2019, 4:02 PM

Change 546454 had a related patch set uploaded (by Krinkle; owner: Esanders):
[mediawiki/core@master] Move deflate method to MW util and deprecate EasyDeflate module

https://gerrit.wikimedia.org/r/546454

Change 546454 merged by jenkins-bot:
[mediawiki/core@master] Move deflate method to MW util and deprecate EasyDeflate module

https://gerrit.wikimedia.org/r/546454

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.5; 2019-11-05).Oct 30 2019, 5:00 PM

Krinkle claimed this task.Jan 29 2020, 3:59 AM