Utils::bcp47 still says 'Not yet ported'. This is required to setting the lang attribute on the <body> tag which is behind a PORT-FIXME for this reason.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Copy bcp47 code from Mediawiki's LanguageCode.php implementation | mediawiki/services/parsoid | master | +16 -20 |
Event Timeline
Comment Actions
I think this was a function which is in core and was ported to JS?
So at the least check core for the PHP version and copy that over, but it might also be nice to add this to siteinfo some how so we can just use the version in core w/o code duplication.
Comment Actions
Change 545864 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] Copy bcp47 code from Mediawiki's LanguageCode.php implementation
Comment Actions
Yes, that is what I copied over.
So at the least check core for the PHP version and copy that over, but it might also be nice to add this to siteinfo some how so we can just use the version in core w/o code duplication.
I just want to unblock work but that can be done post port.
Comment Actions
Change 545864 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Copy bcp47 code from Mediawiki's LanguageCode.php implementation