Page MenuHomePhabricator

Unify transitions in MinervaNeue
Closed, ResolvedPublic

Description

As of now, transition code doesn't seem to follow a variablized, standard approach:
https://codesearch.wmflabs.org/skins/?q=transition&i=nope&files=&repos=Skin:MinervaNeue

Let's fix this by

  • relying on WikimediaUI Base style variables and
  • using those variables consistently.

Additionally

  • making sure that cross-browser transition mixin is used.

Event Timeline

Change 545631 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/skins/MinervaNeue@master] Unify transition values across board

https://gerrit.wikimedia.org/r/545631

Change 545631 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Unify transition values across board

https://gerrit.wikimedia.org/r/545631

Change 545953 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/skins/MinervaNeue@master] Use default duration LESS variable and align timing function one

https://gerrit.wikimedia.org/r/545953

Change 545953 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Use default duration LESS variable and align timing function one

https://gerrit.wikimedia.org/r/545953

Volker_E removed a project: Patch-For-Review.
Volker_E updated the task description. (Show Details)