Page MenuHomePhabricator

Image view and gallery
Closed, ResolvedPublic

Assigned To
Authored By
cmadeo
Oct 23 2019, 5:48 PM
Referenced Files
F31545999: Capture.PNG
Feb 3 2020, 1:22 PM
F31520810: Capture 5.PNG
Jan 22 2020, 7:14 AM
F31520808: Capture 3.PNG
Jan 22 2020, 7:14 AM
F31520809: Capture 4.PNG
Jan 22 2020, 7:14 AM
F31520806: Capture 2.PNG
Jan 22 2020, 7:14 AM
F31520807: Capture 6.PNG
Jan 22 2020, 7:14 AM
F31520805: Capture 1.PNG
Jan 22 2020, 7:14 AM
F31505337: Image thumbnail.png
Jan 8 2020, 9:39 PM

Description

Why are we doing this?

We would like for readers on the KaiOS app to be able to look at images in articles in a focused manner where they can also learn more about the image that they are viewing.

User story

As a reader on the KaiOS app I would like to be able to view images in full screen and learn more about them if I am interested

Proposed design

Thumbnail in articleGallery viewAbout
Image thumbnail.png (320×240 px, 36 KB)
11 - Article gallery view.png (640×480 px, 167 KB)
11a - Article gallery view - about.png (640×480 px, 70 KB)
https://zpl.io/29znGpphttps://zpl.io/a3d9RQYhttps://zpl.io/2j7WYdp
Screen type: dialog
Interaction details
ScreenD-pad centerD-pad up/downD-pad left/rightLSKRSK
Gallery viewOpens About dialogn/acycles through images in articleCloses viewn/a
Aboutn/an/an/aCloses dialogOpens image page on Commons in the browser
Design details

Article view

  • images should have a max height of 90px
  • Text should have a max length of two lines

Gallery view

  • Left and right should cycle through all of the images in the article view
  • Selecting About opens the About overlay
  • If the description is longer than 3 lines, text is truncated
  • Selecting 'More info' from the About overlay opens the Commons item page in the browser
  • Images should be scaled to fit
API

This should use the media API: https://en.wikipedia.org/api/rest_v1/page/media/Cat

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
cmadeo updated the task description. (Show Details)
cmadeo moved this task from Design doing to Ready for approval on the KaiOS-Wikipedia-app board.

@cmadeo Can you clarify how the user gets to the full-screen image view? Are the images within the article focusable like the links?

@SBisson, sorry I forgot to define this, but yes, let's please make images focusable like the links in an article

On inline images, let's experiment with @SBisson idea of a small image icon, slightly larger than the one in search results, that pops out into an image viewer. If the image viewer could allow for descriptive text/captions of the image, that'd be great.

Design needed:

  • thumbnails of images
  • Images should be scattered throughout the text
cmadeo removed cmadeo as the assignee of this task.Jan 8 2020, 9:39 PM
cmadeo updated the task description. (Show Details)
cmadeo updated the task description. (Show Details)
cmadeo moved this task from Design doing to Ready for approval on the KaiOS-Wikipedia-app board.

Regarding the article view,

the image and description might be break into 2 pages

Capture 3.PNG (436×360 px, 72 KB)
Capture 4.PNG (437×359 px, 26 KB)
Capture 6.PNG (438×365 px, 60 KB)
Capture 2.PNG (436×361 px, 23 KB)

We can also make it stay under 1 page only using display: inline-block, but then we will lose the remaining description

Capture 5.PNG (436×363 px, 34 KB)
Capture 1.PNG (439×364 px, 59 KB)

I will go for the first option (break into 2 pages)

@hueitan could we actually go for option 2 instead? Once the user taps through to the gallery view we could show the full description with a scroll within the div?

Do you mean showing the description in full with a scroll then author and license instead of max 3 lines description? In the case with scroll, user unable to see the author and license when opening the ABOUT at first view.

@cmadeo @AMuigai Do we show the gallery option in the menu list? if so which text to show?

@hueitan There is a showInGallery property in the API response that can be used to filter out some of the less interesting images (like speaker icons).

For the text at the top of the image, I'm wondering if we should use caption when present. It looks like it is more likely to be in the content language and the description is more often in english.

@hueitan There is a showInGallery property in the API response that can be used to filter out some of the less interesting images (like speaker icons).

For the text at the top of the image, I'm wondering if we should use caption when present. It looks like it is more likely to be in the content language and the description is more often in english.

Ya, this is better now. here's the change https://github.com/wikimedia/wikipedia-kaios/pull/120

The Gallery sometimes look like this, lang af article Religie, the image has transparent background and black color image https://upload.wikimedia.org/wikipedia/commons/thumb/3/38/ReligijneSymbole.svg/320px-ReligijneSymbole.svg.png

maybe gray color as the background? @cmadeo

Capture.PNG (435×365 px, 6 KB)

@hueitan it looks like we're applying a white background just to the image itself on SVGs on iOS, would it be possible to do the same? I'd hate to lose the black background just for these edge cases.

@hueitan it looks like we're applying a white background just to the image itself on SVGs on iOS, would it be possible to do the same? I'd hate to lose the black background just for these edge cases.

sure, the update is on https://github.com/wikimedia/wikipedia-kaios/pull/122

I will continue with the option (1) breaking into 2 pages, and make the description has max 3 line with an ellipsis in the about gallery dialog.

I also add the Gallery item on the menu page.


Feel free to reopen this card or open a new card when any changes needed for gallery.

@hueitan I just saw that on the image gallery, if I go right it scrolls endlessly between the images, but if I go left it stops at the first one.
can you fix this on this PR (or an ongoing one) or should I create a new ticket?