Page MenuHomePhabricator
Create Task
Maniphest T236320

Internal error while undoing file captions: "InvalidArgumentException: Unsaved revision passed"
Closed, ResolvedPublic
Actions

Description

While undoing file captions I get internal error, e.g. in case of undoing this change I got [XbCuwQpAICwAAK60wekAAACP] 2019-10-23 19:49:21: Fatal exception of type "InvalidArgumentException". Tested on three different files, seems to be very fresh issue. Rollbacking works as expected.

2019-10-23 19:49:21 [XbCuwQpAICwAAK60wekAAACP] mw1323 commonswiki 1.35.0-wmf.3 exception ERROR: [XbCuwQpAICwAAK60wekAAACP] /w/index.php?title=File:Scorpio2.jpg&action=mcrundo&undo=367895766&undoafter=345858690&uselang=en   InvalidArgumentException from line 3276 of /srv/mediawiki/php-1.35.0-wmf.3/includes/Revision/RevisionStore.php: Unsaved revision passed {"exception_id":"XbCuwQpAICwAAK60wekAAACP","exception_url":"/w/index.php?title=File:Scorpio2.jpg&action=mcrundo&undo=367895766&undoafter=345858690&uselang=en","caught_by":"mwe_handler"} 
[Exception InvalidArgumentException] (/srv/mediawiki/php-1.35.0-wmf.3/includes/Revision/RevisionStore.php:3276) Unsaved revision passed
  #0 /srv/mediawiki/php-1.35.0-wmf.3/includes/diff/DifferenceEngine.php(1470): MediaWiki\Revision\RevisionStore->countRevisionsBetween(MediaWiki\Revision\MutableRevisionRecord, MediaWiki\Revision\RevisionStoreCacheRecord, integer)
  #1 /srv/mediawiki/php-1.35.0-wmf.3/includes/diff/DifferenceEngine.php(998): DifferenceEngine->getMultiNotice()
  #2 /srv/mediawiki/php-1.35.0-wmf.3/includes/actions/McrUndoAction.php(242): DifferenceEngine->getDiff(string, string)
  #3 /srv/mediawiki/php-1.35.0-wmf.3/includes/actions/McrUndoAction.php(374): McrUndoAction->generateDiffOrPreview()
  #4 /srv/mediawiki/php-1.35.0-wmf.3/includes/htmlform/fields/HTMLInfoField.php(25): McrUndoAction->{closure}(array)
  #5 /srv/mediawiki/php-1.35.0-wmf.3/includes/htmlform/HTMLForm.php(1699): HTMLInfoField->getDefault()
  #6 /srv/mediawiki/php-1.35.0-wmf.3/includes/htmlform/HTMLForm.php(1299): HTMLForm->displaySection(array, string)
  #7 /srv/mediawiki/php-1.35.0-wmf.3/includes/htmlform/OOUIHTMLForm.php(254): HTMLForm->getBody()
  #8 /srv/mediawiki/php-1.35.0-wmf.3/includes/htmlform/HTMLForm.php(1076): OOUIHTMLForm->getBody()
  #9 /srv/mediawiki/php-1.35.0-wmf.3/includes/htmlform/HTMLForm.php(1055): HTMLForm->getHTML(boolean)
  #10 /srv/mediawiki/php-1.35.0-wmf.3/includes/htmlform/HTMLForm.php(606): HTMLForm->displayForm(boolean)
  #11 /srv/mediawiki/php-1.35.0-wmf.3/includes/actions/FormAction.php(143): HTMLForm->show()
  #12 /srv/mediawiki/php-1.35.0-wmf.3/includes/actions/McrUndoAction.php(90): FormAction->show()
  #13 /srv/mediawiki/php-1.35.0-wmf.3/includes/MediaWiki.php(514): McrUndoAction->show()
  #14 /srv/mediawiki/php-1.35.0-wmf.3/includes/MediaWiki.php(304): MediaWiki->performAction(ImagePage, Title)
  #15 /srv/mediawiki/php-1.35.0-wmf.3/includes/MediaWiki.php(967): MediaWiki->performRequest()
  #16 /srv/mediawiki/php-1.35.0-wmf.3/includes/MediaWiki.php(530): MediaWiki->main()
  #17 /srv/mediawiki/php-1.35.0-wmf.3/index.php(44): MediaWiki->run()
  #18 /srv/mediawiki/w/index.php(3): require(string)
  #19 {main}

Details

SubjectRepoBranchLines +/-
Don't calculate amount of inbetween revisions for MCR undomediawiki/corewmf/1.35.0-wmf.5+1 -0
Don't calculate amount of inbetween revisions for MCR undomediawiki/coremaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

Jdx created this task.Oct 23 2019, 7:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 23 2019, 7:56 PM
Reedy added projects: Wikimedia-production-error, MediaWiki-Core-Revision-backend.Oct 23 2019, 9:50 PM
Reedy updated the task description. (Show Details)
Krinkle moved this task from Untriaged to Oct2019/1.35.wmf.1+ on the Wikimedia-production-error board.Oct 24 2019, 3:01 PM
Aklapper renamed this task from Internal error while undoing file captions to Internal error while undoing file captions: "Unsaved revision passed".Oct 24 2019, 4:58 PM
• Ramsey-WMF added projects: Structured Data Engineering, Structured-Data-Backlog (Current Work).Oct 25 2019, 7:12 PM
Jdx triaged this task as High priority.Oct 26 2019, 8:32 AM
Jdx added a comment.Oct 26 2019, 8:43 AM

I would like to add that this is pretty annoying issue because it makes reverting multiple vandalisms hard, e.g. I am not able to restore using popups version of File:UA Flight 175 hits WTC south tower 9-11 edit.jpeg from 21st May.

Aklapper added a comment.Oct 26 2019, 10:30 AM

@Jdx: Hi, do you plan to work on fixing this task, as you prioritized this task? Thanks!

Jdx raised the priority of this task from High to Needs Triage.Oct 26 2019, 10:45 AM
Jdx added a comment.Oct 26 2019, 10:49 AM

@Aklapper No, I don't. Unfortunately, I do not know MW's internals. Just wanted to signal that this is important problem.

• Ramsey-WMF assigned this task to matthiasmullie.Oct 28 2019, 4:40 PM
• Ramsey-WMF triaged this task as High priority.
• Ramsey-WMF subscribed.

Can be reproduced

image.png (226×879 px, 17 KB)

Reise_Reise subscribed.Oct 28 2019, 6:02 PM
Ahmad252 subscribed.Oct 29 2019, 11:28 AM

+1. It must be some kind of incompatibility with undo. I tried safemode as well, doesn't work with undo. I also tried using a script which uses undo to restore the page to a specific revision, doesn't work.

NicoScribe subscribed.Oct 29 2019, 3:29 PM
matthiasmullie merged a task: T236911: InvalidArgumentException: Unsaved revision passed when undoing a 'depicts' statement.Oct 30 2019, 2:43 PM
matthiasmullie added a subscriber: • Mholloway.
• Mholloway merged a task: T236911: InvalidArgumentException: Unsaved revision passed when undoing a 'depicts' statement.Oct 30 2019, 2:43 PM
gerritbot added a comment.Nov 4 2019, 10:18 AM

Change 548221 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/core@master] Don't calculate amount of inbetween revisions for MCR undo

https://gerrit.wikimedia.org/r/548221

gerritbot added a project: Patch-For-Review.Nov 4 2019, 10:18 AM
matthiasmullie moved this task from Incoming to Code Review on the Structured-Data-Backlog (Current Work) board.Nov 4 2019, 10:19 AM
gerritbot added a comment.Nov 6 2019, 2:52 PM

Change 548221 merged by jenkins-bot:
[mediawiki/core@master] Don't calculate amount of inbetween revisions for MCR undo

https://gerrit.wikimedia.org/r/548221

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.8; 2019-11-26).Nov 6 2019, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 6 2019, 3:10 PM
Krinkle moved this task from Oct2019/1.35.wmf.1+ to Resolved on the Wikimedia-production-error board.Nov 7 2019, 8:08 PM
gerritbot added a comment.Nov 7 2019, 8:09 PM

Change 549624 had a related patch set uploaded (by Krinkle; owner: Matthias Mullie):
[mediawiki/core@wmf/1.35.0-wmf.5] Don't calculate amount of inbetween revisions for MCR undo

https://gerrit.wikimedia.org/r/549624

gerritbot added a project: Patch-For-Review.Nov 7 2019, 8:09 PM
• Pchelolo mentioned this in T237670: Fatal when trying to undo Commons edits: InvalidArgumentException "Unsaved old revision passed" from RevisionStore.Nov 7 2019, 8:59 PM
Krinkle merged tasks: T237670: Fatal when trying to undo Commons edits: InvalidArgumentException "Unsaved old revision passed" from RevisionStore, T237173: InvalidArgumentException breaking Commons "undo" functionality, T237169: InvalidArgumentException when undoing edits in structured data on commons.Nov 7 2019, 9:07 PM
Krinkle added subscribers: • mmodell, TheSandDoctor, Xiplus and 3 others.
Krinkle subscribed.

Reported in three other tasks as well:

matthiasmullie moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Nov 8 2019, 10:10 AM
Premeditated subscribed.Nov 9 2019, 5:10 PM
Masumrezarock100 merged a task: T238501: Can't undo latest edit and summary that include captions.Nov 17 2019, 6:27 PM
Masumrezarock100 added a subscriber: Willy1018.
Masumrezarock100 added a comment.Nov 17 2019, 6:33 PM

Just so you know, rollback works despite all of this. In other words it is possible to revert changes to Structured Data fields using rollback.

Masumrezarock100 updated the task description. (Show Details)Nov 17 2019, 6:38 PM
Jdx mentioned this in T239062: Internal error while browsing diffs on Special:Undelete: "Revision 207278230 doesn't belong to page 0".Nov 25 2019, 11:51 AM
Jdx added a comment.Nov 27 2019, 10:18 AM

When the changes will be deployed? Three weeks have passed since the day the patch was submitted and lack of fully functional "undo" is a big pain in the butt for people who fight vandalism on Commons…

Masumrezarock100 added a comment.EditedNov 27 2019, 1:10 PM
In T236320#5696371, @Jdx wrote:

When the changes will be deployed? Three weeks have passed since the day the patch was submitted and lack of fully functional "undo" is a big pain in the butt for people who fight vandalism on Commons…

We need a reviewer with +2 access who can merge the change. But for now, use rollback (only applies to latest revisions obviously).

• Ramsey-WMF added a comment.Nov 27 2019, 8:08 PM

This patch has been approved and merged (you can test it on Test Commons now), but it won't reach real Commons until next Wednesday, due to a split rollout because of the holiday (US Thanksgiving).

In T236320#5696371, @Jdx wrote:

When the changes will be deployed? Three weeks have passed since the day the patch was submitted and lack of fully functional "undo" is a big pain in the butt for people who fight vandalism on Commons…

Krinkle added a comment.Nov 28 2019, 4:23 AM
In T236320#5698330, @Ramsey-WMF wrote:

This patch has been approved and merged (you can test it on Test Commons now), but it won't reach real Commons until next Wednesday […]

For significant regressions like these we have a backporting process that allows individual changes to be applied quicker. I've prepared a cherry-pick for this commit:

In T236320#5645655, @gerritbot wrote:

Change 549624 had a related patch set uploaded (owner: Matthias Mullie):
[mediawiki/core@wmf/1.35.0-wmf.5] Don't calculate amount of inbetween revisions for MCR undo

https://gerrit.wikimedia.org/r/549624

It needs a quick look-over from Matthias, Daniel or someone else familiar with the code to confirm that it applies cleanly to last week's state, and then someone can roll it out tomorrow. I can help with that.

• Ramsey-WMF added a comment.Nov 28 2019, 7:01 AM

Thanks! I'll defer to @matthiasmullie on that.

Umherirrender mentioned this in T238988: Internal error when trying to revert MCR edits: "Unsaved old revision passed".Nov 29 2019, 8:52 PM
Krinkle merged a task: T238988: Internal error when trying to revert MCR edits: "Unsaved old revision passed".Dec 2 2019, 8:29 PM
Krinkle added subscribers: Tacsipacsi, Umherirrender, Liuxinyu970226.
gerritbot added a comment.Dec 3 2019, 1:00 AM

Change 549624 merged by jenkins-bot:
[mediawiki/core@wmf/1.35.0-wmf.5] Don't calculate amount of inbetween revisions for MCR undo

https://gerrit.wikimedia.org/r/549624

Maintenance_bot removed a project: Patch-For-Review.Dec 3 2019, 1:10 AM
Stashbot added a comment.Dec 3 2019, 1:20 AM

Mentioned in SAL (#wikimedia-operations) [2019-12-03T01:20:57Z] <jforrester@deploy1001> Synchronized php-1.35.0-wmf.5/includes/diff/DifferenceEngine.php: T236320 Don't calculate amount of inbetween revisions for MCR undo (duration: 00m 59s)

Jdforrester-WMF subscribed.Dec 3 2019, 1:24 AM

Now deployed.

Masumrezarock100 closed this task as Resolved.Dec 3 2019, 1:43 AM

Looks so good! https://commons.wikimedia.org/wiki/Special:Diff/378834178

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.5; 2019-11-05); removed MW-1.35-notes (1.35.0-wmf.8; 2019-11-26).Dec 3 2019, 2:00 AM
matthiasmullie added a comment.Dec 3 2019, 8:16 AM

Whoops. I hadn't realized this was blocked on me! Thanks for the ping, @Krinkle & @Ramsey-WMF.

Krinkle renamed this task from Internal error while undoing file captions: "Unsaved revision passed" to Internal error while undoing file captions: "InvalidArgumentException: Unsaved revision passed".Dec 4 2019, 12:38 AM
Krinkle merged a task: T238228: Internal error when undoing caption edit by IP: "Unsaved old revision passed".
Krinkle added a subscriber: Astinson.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL