Seen while testing RESTBase. Calling transform/wikitext/to/lint with the body wikitext: '<div>No div ending' produces different results between Parsoid/JS and Parsoid/PHP:
body: [
{ type: 'missing-end-tag', params: [Object], dsr: [Object] }
]body: []
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Parsoid/PHP: Load the extension on all Parsoid nodes | operations/mediawiki-config | master | +19 -18 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | ssastry | T229015 Tracking: Direct live production traffic at Parsoid/PHP | |||
| Resolved | • mobrovac | T229018 RESTBase should be able to store Parsoid/PHP contents in Cassandra alongwith Parsoid/JS contents | |||
| Resolved | ssastry | T235902 Tracking: Shadow Parsoid/PHP deployment to production cluster to handle mirrored reparse traffic | |||
| Resolved | • mobrovac | T230791 Have a Mechanism for Storing and Retrieving Parsoid HTML from JS and PHP | |||
| Resolved | • mobrovac | T236388 Linting is disabled on beta cluster, but needs to be enabled |
Linting has been implemented and tested. This is a config issue.
From wmf-config file:
// While we are testing & benchmarking, make production db access read-only
$wgReadOnly = $wmfRealm !== 'labs';
$wgParsoidSettings = [
'useSelser' => true,
// Temporarily condition on $wgReadOnly while testing & benchmarking
// so we don't try to update lint information in the production dbs.
'linting' => (bool)$wgReadOnly
];So we need a config fix for beta.
Thinking about this, shouldn't this be
linting => !$wgReadOnly
since we should be linting if MW is not in read-only mode?
It was set that way because scandium was readonly ... and linting was safe because posting of lints to the db was conditioned on $wgReadOnly.
We want the same behavior for production in these next few weeks .. i.e. and lint and find crashers if any .. but don't post.
For now, we probably need a special condition for beta.
Once we are ready to go live, we can change it to what you suggest there and have a special case for scandium (instead of beta).
Does that sound reasonable?
Change 544878 had a related patch set uploaded (by Mobrovac; owner: Mobrovac):
[operations/mediawiki-config@master] Parsoid/PHP: Load the extension on all Parsoid nodes
Change 544878 merged by jenkins-bot:
[operations/mediawiki-config@master] Parsoid/PHP: Load the extension on all Parsoid nodes
Mentioned in SAL (#wikimedia-operations) [2019-10-24T17:26:00Z] <mobrovac@deploy1001> Synchronized wmf-config/CommonSettings.php: Enable Parsoid/PHP in the whole wtp (a.k.a. Parsoid) cluster - T236388 (duration: 00m 53s)