Page MenuHomePhabricator

Check number of existing depicts statements for an image before serving for review
Closed, ResolvedPublic

Description

Before serving an image and its labels for review, we should double-check that it does not already have more than the configured maximum number of depicts statements. This check already happens in the maintenance scripts used to build file lists for existing images, but there is currently no check at the point of serving images. It is possible that depicts statements will be added separately between label requests and serving the labels for confirmation.

This is not a blocker for launch.

Event Timeline

Change 546658 had a related patch set uploaded (by Mholloway; owner: Michael Holloway):
[mediawiki/extensions/MachineVision@master] Condiitonally withhold remaining unreviewed titles on save complete

https://gerrit.wikimedia.org/r/546658

Change 546658 merged by jenkins-bot:
[mediawiki/extensions/MachineVision@master] Condiitonally withhold remaining unreviewed titles on save complete

https://gerrit.wikimedia.org/r/546658

@Mholloway do we care if the edits that marked the label as withheld are reverted?

Hmm, I'm not sure. We could handle that case by hooking into the undo/rollback complete hooks and flipping withheld images back to unreviewed if they pass filtering. The only catch is that we don't currently have separate review states representing different reasons for withholding an image (NSFW vs. too many existing depicts statements). We'd have to introduce a new review state for this.

I think it's probably worth doing if we have time, but shouldn't block launch. Let's also find out what @Ramsey-WMF thinks about it.

This would be a neat feature, but perhaps too clever for where we are now. We just have to get the thing working, and we haven't even put it on test Commons yet 😸 I suggest we keep things simple and focus on making base functionality as clean as possible.