Fatal Error: "Call to a member function getId() on string" from BlockListPager.php
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

MediaWiki version: 1.35.0-wmf.3

message

Call to a member function getId() on string

Impact

Notes

Details

Request ID: XbG5tApAIC8AAGkAHFsAAAAI
Request URL: https://en.wikipedia.org/w/index.php?title=Special:BlockList&dir=prev

Stack Trace

exception.trace

#0 /includes/pager/TablePager.php(197): BlockListPager->formatValue(string, NULL)
#1 /includes/pager/IndexPager.php(491): TablePager->formatRow(stdClass)
#2 /includes/pager/TablePager.php(106): IndexPager->getBody()
#3 /includes/specials/SpecialBlockList.php(231): TablePager->getFullOutput()
#4 /includes/specials/SpecialBlockList.php(133): SpecialBlockList->showList(BlockListPager)
#5 /includes/specialpage/SpecialPage.php(575): SpecialBlockList->execute(NULL)
#6 /includes/specialpage/SpecialPageFactory.php(607): SpecialPage->run(NULL)
#7 /includes/MediaWiki.php(298): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#8 /includes/MediaWiki.php(967): MediaWiki->performRequest()
#9 /includes/MediaWiki.php(530): MediaWiki->main()
#10 /index.php(44): MediaWiki->run()
#11 /srv/mediawiki/w/index.php(3): require(string)
#12 {main}

Project	Branch	Lines +/-	Subject
mediawiki/core	wmf/1.35.0-wmf.2	+18 -11	Ensure that the $target is a UserIdentity before calling ::getId()
mediawiki/core	wmf/1.35.0-wmf.3	+18 -11	Ensure that the $target is a UserIdentity before calling ::getId()
mediawiki/core	master	+18 -11	Ensure that the $target is a UserIdentity before calling ::getId()

Customize query in gerrit

Related Objects

Mentioned Here: rMWfc99c5a7c0de: Ensure that the $target is a UserIdentity before calling ::getId()

Event Timeline

Krinkle created this task.Oct 24 2019, 6:45 PM

Restricted Application added subscribers: MGChecker, Aklapper. · View Herald TranscriptOct 24 2019, 6:45 PM

Reproducible at https://en.wikipedia.org/w/index.php?title=Special:BlockList&dir=prev.

Krinkle moved this task from Untriaged to Oct2019/1.35.wmf.1+ on the Wikimedia-production-error board.Oct 24 2019, 6:45 PM

dbarratt claimed this task.Oct 24 2019, 7:25 PM

Tchanders added subscribers: dbarratt, Tchanders, • aezell.Oct 24 2019, 7:26 PM

Change 545924 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[mediawiki/core@master] Ensure that the $target is a UserIdentity before calling ::getId()

https://gerrit.wikimedia.org/r/545924

gerritbot added a project: Patch-For-Review.Oct 24 2019, 7:38 PM

dbarratt edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.Oct 24 2019, 7:41 PM

dbarratt moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.

@dbarratt Is this patch safe to backport to current prod? (wmf.3)

Change 545924 merged by jenkins-bot:
[mediawiki/core@master] Ensure that the $target is a UserIdentity before calling ::getId()

https://gerrit.wikimedia.org/r/545924

Change 545969 had a related patch set uploaded (by Tchanders; owner: Dbarratt):
[mediawiki/core@wmf/1.35.0-wmf.2] Ensure that the $target is a UserIdentity before calling ::getId()

https://gerrit.wikimedia.org/r/545969

Change 545970 had a related patch set uploaded (by Tchanders; owner: Dbarratt):
[mediawiki/core@wmf/1.35.0-wmf.3] Ensure that the $target is a UserIdentity before calling ::getId()

https://gerrit.wikimedia.org/r/545970

@Krinkle The patch that it's fixing is also on wmf.2 so have cherry-picked to both (https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/541074/)

Not sure why we didn't see errors earlier, possibly because blocks whose targets aren't user, IP or range are rare/old.

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.4; 2019-10-29).Oct 24 2019, 11:00 PM

Change 545970 merged by jenkins-bot:
[mediawiki/core@wmf/1.35.0-wmf.3] Ensure that the $target is a UserIdentity before calling ::getId()

https://gerrit.wikimedia.org/r/545970

Mentioned in SAL (#wikimedia-operations) [2019-10-24T23:24:12Z] <krinkle@deploy1001> Synchronized php-1.35.0-wmf.3/includes/specials/pagers/BlockListPager.php: T236425, rMWfc99c5a7c0de (duration: 00m 54s)