Page MenuHomePhabricator

Fatal Error: "Call to a member function getId() on string" from BlockListPager.php
Closed, ResolvedPublic

Description

Error

MediaWiki version: 1.35.0-wmf.3

message
Call to a member function getId() on string

Impact

Notes

Details

Request ID
XbG5tApAIC8AAGkAHFsAAAAI
Request URL
https://en.wikipedia.org/w/index.php?title=Special:BlockList&dir=prev
Stack Trace
exception.trace
#0 /includes/pager/TablePager.php(197): BlockListPager->formatValue(string, NULL)
#1 /includes/pager/IndexPager.php(491): TablePager->formatRow(stdClass)
#2 /includes/pager/TablePager.php(106): IndexPager->getBody()
#3 /includes/specials/SpecialBlockList.php(231): TablePager->getFullOutput()
#4 /includes/specials/SpecialBlockList.php(133): SpecialBlockList->showList(BlockListPager)
#5 /includes/specialpage/SpecialPage.php(575): SpecialBlockList->execute(NULL)
#6 /includes/specialpage/SpecialPageFactory.php(607): SpecialPage->run(NULL)
#7 /includes/MediaWiki.php(298): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#8 /includes/MediaWiki.php(967): MediaWiki->performRequest()
#9 /includes/MediaWiki.php(530): MediaWiki->main()
#10 /index.php(44): MediaWiki->run()
#11 /srv/mediawiki/w/index.php(3): require(string)
#12 {main}
Related Gerrit Patches:

Event Timeline

Krinkle created this task.Thu, Oct 24, 6:45 PM
Restricted Application added subscribers: MGChecker, Aklapper. · View Herald TranscriptThu, Oct 24, 6:45 PM
dbarratt claimed this task.Thu, Oct 24, 7:25 PM

Change 545924 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[mediawiki/core@master] Ensure that the $target is a UserIdentity before calling ::getId()

https://gerrit.wikimedia.org/r/545924

Krinkle added a comment.EditedThu, Oct 24, 10:34 PM

@dbarratt Is this patch safe to backport to current prod? (wmf.3)

Change 545924 merged by jenkins-bot:
[mediawiki/core@master] Ensure that the $target is a UserIdentity before calling ::getId()

https://gerrit.wikimedia.org/r/545924

Change 545969 had a related patch set uploaded (by Tchanders; owner: Dbarratt):
[mediawiki/core@wmf/1.35.0-wmf.2] Ensure that the $target is a UserIdentity before calling ::getId()

https://gerrit.wikimedia.org/r/545969

Change 545970 had a related patch set uploaded (by Tchanders; owner: Dbarratt):
[mediawiki/core@wmf/1.35.0-wmf.3] Ensure that the $target is a UserIdentity before calling ::getId()

https://gerrit.wikimedia.org/r/545970

@Krinkle The patch that it's fixing is also on wmf.2 so have cherry-picked to both (https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/541074/)

Not sure why we didn't see errors earlier, possibly because blocks whose targets aren't user, IP or range are rare/old.

Change 545970 merged by jenkins-bot:
[mediawiki/core@wmf/1.35.0-wmf.3] Ensure that the $target is a UserIdentity before calling ::getId()

https://gerrit.wikimedia.org/r/545970

Mentioned in SAL (#wikimedia-operations) [2019-10-24T23:24:12Z] <krinkle@deploy1001> Synchronized php-1.35.0-wmf.3/includes/specials/pagers/BlockListPager.php: T236425, fc99c5a7c0de2 (duration: 00m 54s)

Change 545969 abandoned by Tchanders:
Ensure that the $target is a UserIdentity before calling ::getId()

Reason:
No longer in production

https://gerrit.wikimedia.org/r/545969

Krinkle closed this task as Resolved.Fri, Oct 25, 1:25 AM