Page MenuHomePhabricator

Regression: Changes to email blacklist or muted users do not activate Save button in Preferences
Closed, ResolvedPublic

Description

The Save button in Special:Preferences is supposed to only be greyed out until you change something. It remains greyed out if you only change the email blacklist at "Prohibit these users from emailing me" under "User profile", or the muted users at "Do not display notifications from these users" under "Notifications".

The Save button works if you also change another preference, but returns to greyed out if you change the other preference back before saving.

(I just copied from T192147, it seems to have regressed again.)

Details

Related Gerrit Patches:

Event Timeline

Schnark created this task.Fri, Oct 25, 7:06 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptFri, Oct 25, 7:06 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 547685 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] mw.widgets.UsersMultiselectWidget: Fix property name

https://gerrit.wikimedia.org/r/547685

Change 547685 merged by jenkins-bot:
[mediawiki/core@master] mw.widgets.UsersMultiselectWidget: Fix property name

https://gerrit.wikimedia.org/r/547685

Change 547692 had a related patch set uploaded (by Jforrester; owner: Bartosz Dziewoński):
[mediawiki/core@wmf/1.35.0-wmf.4] mw.widgets.UsersMultiselectWidget: Fix property name

https://gerrit.wikimedia.org/r/547692

Change 547692 merged by jenkins-bot:
[mediawiki/core@wmf/1.35.0-wmf.4] mw.widgets.UsersMultiselectWidget: Fix property name

https://gerrit.wikimedia.org/r/547692

Mentioned in SAL (#wikimedia-operations) [2019-11-01T01:21:31Z] <jforrester@deploy1001> Synchronized php-1.35.0-wmf.4/resources/src/mediawiki.widgets/mw.widgets.UsersMultiselectWidget.js: T236460 mw.widgets.UsersMultiselectWidget: Fix property name (duration: 00m 54s)

Jdforrester-WMF closed this task as Resolved.Fri, Nov 1, 1:22 AM
Jdforrester-WMF assigned this task to matmarex.