Page MenuHomePhabricator

Incompatible calls to SkinTemplateTabs hook
Closed, ResolvedPublic

Description

Author: bugs

Description:
Skin::extensionTabLinks() in Skin.php calls:

wfRunHooks( 'SkinTemplateTabs', array( $this, &$tabs ) );

SkinTemplate::buildContentActionUrls() in SkinTemplate.php calls:

wfRunHooks( 'SkinTemplateTabs', array( &$this, &$content_actions ) );

Note the presence of & reference operator applied on $this in the SkinTemplate call. Both calls should be compatible. Probably the first one is correct, according to the documentation in http://www.mediawiki.org/wiki/Manual:Hooks/SkinTemplateTabs .


Version: 1.16.x
Severity: normal

Details

Reference
bz21650

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:52 PM
bzimport set Reference to bz21650.
bzimport added a subscriber: Unknown Object (MLST).
IAlex added a comment.Nov 26 2009, 8:20 PM

Fixed in r59468.