In Firefox 70, view goes up to the top of the page when user exits Media Viewer
Closed, DuplicatePublicBUG REPORT
Actions

Assigned To

None

Authored By

	Framawiki
	Oct 25 2019, 8:55 PM

Description

Steps to Reproduce:

Load any wiki page containing an image that is not at the top of the page, like https://fr.wikipedia.org/wiki/Charles_de_Lalaisse
Click on this image to load Media Viewer
Wait for full image loading
Click on the top right cross to close Media Viewer interface

Actual Results:

Browser view goes up to the top of the page

Expected Results:

Browser view position does not change, and remains at the same place

Tested with and without custom scripts (?safemode=1), results is the same.
Can't find errors in console.

Related Objects

Mentioned In: T238242: Closing the Media Viewer in latest Firefox causes a jump to top of page

Event Timeline

Framawiki created this task.Oct 25 2019, 8:55 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 25 2019, 8:55 PM

Boldly setting High priority: it is annoying for the user to come back at the top of the page each time he opens an image, and it impact user reading experience.

Framawiki updated the task description. (Show Details)Oct 25 2019, 8:57 PM

Confirming on Firefox 70.

I"m also on FF 70, but I suspect it only impact this version, can someone test it with another version/browser?

In T236520#5608982, @Framawiki wrote:

I"m also on FF 70, but I suspect it only impact this version, can someone test it with another version/browser?

Cannot reproduce on opera, nor chrome (based on a quick test).

Heighliner10191 subscribed.Oct 30 2019, 5:13 AM

Actually, the viewport goes always up to the top, then it is set back to where it was before the opening of MediaViewer. FireFox 70 still works like that just fine on MediaWiki 1.31 so it doesn't really seem a browser issue. Also, possibly it is useful to mention that on the current MediaWiki release both Firefox and Chrome return to the previous page when closing MediaViewer in fullscreen mode.

Aklapper renamed this task from Browser view goes up to the top of the page when user exits Media Viewer to In Firefox 70, view goes up to the top of the page when user exits Media Viewer.Oct 31 2019, 10:06 AM

Aklapper merged a task: T236967: Closing an image returns you to the top of the page, not where you were before clicking on the picture in Firefox.

Aklapper added a project: Browser-Support-Firefox.

Aklapper added subscribers: Thryduulf, KTC.

From the merged task, this occurs in Firefox 70 on Windows 7, Windows 10 and Xubuntu Linux 18.04. It doesn't occur in Firefox 69 on Windows nor in Chromium or Konqueror on Linux.

mathcolo subscribed.Nov 4 2019, 4:00 AM

Unsurprisingly, this is bug is still present in Firefox 70.0.1

https://bugzilla.mozilla.org/show_bug.cgi?id=1594345

Thank you!

Aklapper raised the priority of this task from High to Needs Triage.Nov 8 2019, 9:59 AM

Aklapper moved this task from Backlog to Reported Upstream on the Upstream board.

Quoting https://bugzilla.mozilla.org/show_bug.cgi?id=1594345#c7 :

This is a tech evangelism bug. A quick research finds:

[this.router.back()](https://github.com/wikimedia/mediawiki-extensions-MultimediaViewer/blob/master/resources/mmv/mmv.js#L888) is a [deferred.promise()](https://github.com/wikimedia/oojs-router/blob/master/src/index.js#L194) but there’s no then(), so it’s not async-ready

Then there is a [setTimeout() hack for Chrome](https://github.com/wikimedia/mediawiki-extensions-MultimediaViewer/blob/master/resources/mmv.bootstrap/mmv.bootstrap.js#L584-L588) but it’s not working for Firefox probably because the delay is not specified

Aklapper mentioned this in T238242: Closing the Media Viewer in latest Firefox causes a jump to top of page.Nov 13 2019, 11:47 PM

Aklapper merged a task: T238242: Closing the Media Viewer in latest Firefox causes a jump to top of page.

Aklapper added subscribers: MarkTraceur, Jdlrobson.

Aklapper closed this task as a duplicate of T229484: [M] After closing, browser sometimes scrolls to the top of the page in Firefox.Nov 18 2019, 12:27 PM

In Firefox 70, view goes up to the top of the page when user exits Media ViewerClosed, DuplicatePublicBUG REPORTActions

Description

Related Objects

Event Timeline

In Firefox 70, view goes up to the top of the page when user exits Media Viewer
Closed, DuplicatePublicBUG REPORT
Actions