Page MenuHomePhabricator
Create Task
Maniphest T236522

Newcomer tasks: Use RESTBase for text extracts
Closed, ResolvedPublic
Actions

Description

Currently we use TextExtracts extension, but as discussed in this patch it would be better to use RESTBase.

We could probably reuse the $wgGENewcomerTasksRemoteApiUrl config variable to determine which language wiki to use with RESTBase.

Also, if we don't have a thumbnail from PageImages (which happens if e.g. $wgGENewcomerTasksRemoteApiUrl is used) then maybe we could consider using the thumbnail from RESTBase, even though it's not sized quite how we'd want it to be.

Details

SubjectRepoBranchLines +/-
Make RESTBase errors trigger the error screen + add URL overridemediawiki/extensions/GrowthExperimentsmaster+36 -9
Suggested Edits: Use RESTBase for loading text extractsmediawiki/extensions/GrowthExperimentsmaster+44 -16
Customize query in gerrit

Related Objects
Search...

Event Timeline

kostajh created this task.Oct 25 2019, 9:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 25 2019, 9:21 PM
JTannerWMF subscribed.Oct 29 2019, 2:41 PM

@kostajh will create a new task for 1.0 and then bump this task out of the current sprint board

kostajh mentioned this in T236798: Newcomer tasks: Load text extracts for all tasks returned from ApiQueryGrowthTasks.Oct 29 2019, 2:44 PM
kostajh edited projects, added NewcomerTasks Future Release ; removed NewcomerTasks 1.0 , Growth-Team (Sprint 0 (Growth Team)).

Not needed for 1.0 but could be done as part of T236798

Tgr mentioned this in T237056: Newcomer tasks: article card displays parts of wiki source text.Oct 31 2019, 10:24 PM
kostajh claimed this task.Nov 4 2019, 2:54 PM
kostajh added a project: Growth-Team (Sprint 0 (Growth Team)).
kostajh moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Nov 4 2019, 3:01 PM

Change 548278 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] (wip) Suggested Edits: Use RESTBase for loading text extracts

https://gerrit.wikimedia.org/r/548278

gerritbot added a project: Patch-For-Review.Nov 4 2019, 3:01 PM
kostajh moved this task from In Progress to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 4 2019, 9:03 PM
gerritbot added a comment.Nov 4 2019, 9:13 PM

Change 548278 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Suggested Edits: Use RESTBase for loading text extracts

https://gerrit.wikimedia.org/r/548278

Maintenance_bot removed a project: Patch-For-Review.Nov 4 2019, 10:11 PM
gerritbot added a comment.Nov 5 2019, 10:53 AM

Change 548578 had a related patch set uploaded (by Kosta Harlan; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Make RESTBase errors trigger the error screen + add URL override

https://gerrit.wikimedia.org/r/548578

gerritbot added a project: Patch-For-Review.Nov 5 2019, 10:53 AM
gerritbot added a comment.Nov 5 2019, 11:20 AM

Change 548578 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Make RESTBase errors trigger the error screen + add URL override

https://gerrit.wikimedia.org/r/548578

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.5; 2019-11-05).Nov 5 2019, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 5 2019, 12:10 PM
Etonkovidova closed this task as Resolved.Nov 8 2019, 6:10 AM
Etonkovidova subscribed.

Checked as per T237056

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL