Page MenuHomePhabricator
Create Task
Maniphest T236620

Refactor GrowthExperiments Homepage Selenium test
Closed, ResolvedPublic
Actions

Description

  • Move preferences functionality from homepage.js to preferences.page page object
  • Create preferences enable and disable functions in page object

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/GrowthExperimentsmaster+24 -22Selenium: abstract preferences page functionality
Customize query in gerrit

Event Timeline

Ephemeralwaves created this task.Oct 27 2019, 2:26 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 27 2019, 2:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Ephemeralwaves updated the task description. (Show Details)Oct 27 2019, 3:01 PM
gerritbot added a comment.Oct 27 2019, 3:17 PM

Change 546361 had a related patch set uploaded (by Ephemeralwaves; owner: Ephemeralwaves):
[mediawiki/extensions/GrowthExperiments@master] Selenium: abstract preferences page functionality

https://gerrit.wikimedia.org/r/546361

gerritbot added a project: Patch-For-Review.Oct 27 2019, 3:17 PM
zeljkofilipin triaged this task as Medium priority.Oct 28 2019, 12:30 PM
zeljkofilipin added a project: User-zeljkofilipin.
zeljkofilipin added projects: Release-Engineering-Team-TODO (201910), Release-Engineering-Team (Unit & Int & System Tooling).
zeljkofilipin moved this task from INBOX to Doing on the Release-Engineering-Team-TODO (201910) board.
zeljkofilipin moved this task from Backlog 🪒 to In Progress 🎸 on the User-zeljkofilipin board.
zeljkofilipin removed projects: Release-Engineering-Team (Unit & Int & System Tooling), Release-Engineering-Team-TODO (201910).Oct 30 2019, 2:00 PM
gerritbot added a comment.Nov 1 2019, 5:35 PM

Change 547757 had a related patch set uploaded (by Ephemeralwaves; owner: Ephemeralwaves):
[mediawiki/extensions/GrowthExperiments@master] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GrowthExperiments into T236620

https://gerrit.wikimedia.org/r/547757

gerritbot added a comment.Nov 1 2019, 5:36 PM

Change 547757 abandoned by Ephemeralwaves:
Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GrowthExperiments into T236620

https://gerrit.wikimedia.org/r/547757

gerritbot added a comment.Dec 2 2019, 4:58 PM

Change 546361 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Selenium: abstract preferences page functionality

https://gerrit.wikimedia.org/r/546361

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.10; 2019-12-10).Dec 2 2019, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 2 2019, 5:10 PM
zeljkofilipin closed this task as Resolved.Dec 9 2019, 12:37 PM
zeljkofilipin added a subscriber: zeljkofilipin.

Looks like this is resolved. Please reopen if there's anything left to do here.

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL