Unable to restore https://pl.wikipedia.org/wiki/Lista_kolor%C3%B3w
Some revisions can't be previewed: https://pl.wikipedia.org/w/index.php?title=Specjalna:Odtw%C3%B3rz&target=Lista+kolor%C3%B3w×tamp=20060330184135&diff=prev
[XbXHpgpAMFYAAJsVC4AAAACN] /w/index.php?title=Specjalna:Odtw%C3%B3rz&action=submit MediaWiki\Revision\IncompleteRevisionException from line 404 of /srv/mediawiki/php-1.35.0-wmf.3/includes/Revision/RevisionStore.php: user_text field must not be ''!
#0 /includes/Revision/RevisionStore.php(462): MediaWiki\Revision\RevisionStore->failOnEmpty(string, string)
#1 /includes/page/PageArchive.php(707): MediaWiki\Revision\RevisionStore->insertRevisionOn(MediaWiki\Revision\RevisionArchiveRecord, Wikimedia\Rdbms\MaintainableDBConnRef)
#2 /includes/page/PageArchive.php(437): PageArchive->undeleteRevisions(array, boolean, string)
#3 /includes/specials/SpecialUndelete.php(1195): PageArchive->undelete(array, string, array, boolean, User)
#4 /includes/specials/SpecialUndelete.php(223): SpecialUndelete->undelete()
#5 /includes/specialpage/SpecialPage.php(575): SpecialUndelete->execute(NULL)
#6 /includes/specialpage/SpecialPageFactory.php(607): SpecialPage->run(NULL)
#7 /includes/MediaWiki.php(298): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#8 /includes/MediaWiki.php(967): MediaWiki->performRequest()
#9 /includes/MediaWiki.php(530): MediaWiki->main()
#10 /index.php(44): MediaWiki->run()
#11 /srv/mediawiki/w/index.php(3): require(string)
#12 {main}| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| RevisionStore: force "Unknown user" instead of empty user name | mediawiki/core | master | +55 -1 |
It is able to restore in parts. This page has over 900 revisions. Whet I try to restore 100 of them it works.
I undeleted all revs without one. This revision from 2004 has the removed username. This is probably the result of beta version of oversight.
Message:
[XbXm6gpAADwAAEPlTeAAAAAW] 2019-10-27 18:50:18: Krytyczny wyjątek typu „MediaWiki\Revision\IncompleteRevisionException”
I don't see an immediate relation to MCR, but in case it is (as the reported tagged), cc-ing CPT for awareness.
Looks like the same basic cause as T203913: User.php: Cannot create a user with no name, no ID, and no actor ID (Unable to delete certain pages on Chinese Wikisource), see T203913#5037424 for discussion of the solution.
Untagging as the related task Brad mentions is handle by growth team. Please correct me if that is not right.
This definitely looks like a very deep MCR/core issue to me, not at all a Growth team issue. I don't know how we came to be tagged on the related task, but this is way out of our area of expertise.
@Anomie What would happen if PageArchive::undeleteRevisions would detect empty user names, and replace them with "Unknown user"? Can we just do that, or would this lead to problems down the road? Writing a reserved pseudo-user to the database seems like asking for trouble, but better than an empty user name.
That would probably work. The maintenance script proposed in T203913#5037424 would be doing basically the same thing.
I just found that RevisionStore::newRevisionFromArchiveRow() already has code in place for this. The fact that this code doesn't trigger makes ma think that we probably not only have an empty user name, but an actor entry with a valid ID that resolves to the empty user name. @Anomie wrote:
On enwiki, try User::newFromAnyId( null, null, 36635239 )->getName()
We could ignore the actor ID on undelete when the user name is empty, and still force "Unknown user". Would that be the right thing to do?
As long as the undeleted row winds up pointing to the actual "Unknown user" actor, sure.
Change 553185 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] RevisionStore: force "Unknown user" instead of empty user name
Change 553185 merged by jenkins-bot:
[mediawiki/core@master] RevisionStore: force "Unknown user" instead of empty user name