Implement alternative `SiteLinkLookup` for MediaInfo entities
Closed, DuplicatePublic
Actions

Description

We have this:
It is possible to fetch MediaInfo entities via Lua on Commons, and most of the methods exposed via Wikibase's Lua modules work just fine.
However, it is not currently possible to use those that rely on SiteLinkLookup (getEntityIdForTitle, getSiteLinkPageName and getEntityIdForCurrentPage )
Those should become available as well.

We want this:
Support for mw.wikibase.getEntityIdForCurrentPage, mw.wikibase.getEntityIdForTitle and mw.wikibase.getSiteLinkPageName calls should be implemented, so MediaInfo entities can be found by page title.

Acceptance Criteria:

mw.wikibase.getEntityIdForCurrentPage works
mw.wikibase.getEntityIdForTitle works
mw.wikibase.getSiteLinkPageName works

Details

Project	Branch	Lines +/-	Subject
mediawiki/extensions/WikibaseMediaInfo	master	+3 -0	Register mediainfo-specific EntityIdLookup
mediawiki/extensions/WikibaseMediaInfo	wmf/1.35.0-wmf.10	+3 -0	Register mediainfo-specific EntityIdLookup
mediawiki/extensions/Wikibase	wmf/1.35.0-wmf.10	+2 -2	Fix idlookup dropping pageids
mediawiki/extensions/Wikibase	master	+2 -2	Fix idlookup dropping pageids
mediawiki/extensions/Wikibase	master	+376 -16	Add ByTypeDispatchingEntityIdLookup, allowing other entity id lookup for other types

Customize query in gerrit

Related Objects

Mentioned In: T240410: Wikidata updates(?) are triggering "Call to a member function getPageLanguage() on null" on wmf.10 wikis
T237107: Extend mw.wikibase lua functions to allow accessing Structured Data on Commons items
T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items
Mentioned Here: T240410: Wikidata updates(?) are triggering "Call to a member function getPageLanguage() on null" on wmf.10 wikis
T237107: Extend mw.wikibase lua functions to allow accessing Structured Data on Commons items

Event Timeline

matthiasmullie created this task.Oct 28 2019, 2:23 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 28 2019, 2:23 PM

matthiasmullie mentioned this in T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items.Oct 28 2019, 2:33 PM

Multichill added a subscriber: Multichill.Oct 28 2019, 9:14 PM

Jarekt mentioned this in T237107: Extend mw.wikibase lua functions to allow accessing Structured Data on Commons items.Nov 1 2019, 2:36 PM

I think mw.wikibase.getSiteLinkPageName is called mw.wikibase.getSitelink according to the documentation. If getSiteLinkPageName is an alternative name than it does not seem to be documented. I apologize for nitpicking, but it is confusing.

I just created T237107, before noticing this task. They have some overlap, but T237107 is more general as it ask for review, testing and documentation of mw.wikibase functions in SDC environment. So maybe this would be the subtask of the other.

Change 550494 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/Wikibase@master] [WIP] Add ByTypeDispatchingEntityIdLookup, allowing other entity id lookup for other types

https://gerrit.wikimedia.org/r/550494

Change 550497 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Register mediainfo-specific EntityIdLookup

https://gerrit.wikimedia.org/r/550497

gerritbot added a project: Patch-For-Review.Nov 12 2019, 3:43 PM

matej_suchanek added a project: Structured Data Engineering.Nov 24 2019, 5:05 PM

matthiasmullie claimed this task.Nov 26 2019, 3:12 PM

matthiasmullie moved this task from Incoming to Code Review on the Structured-Data-Backlog (Current Work) board.

Change 550494 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add ByTypeDispatchingEntityIdLookup, allowing other entity id lookup for other types

https://gerrit.wikimedia.org/r/550494

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.10; 2019-12-10).Dec 5 2019, 1:00 PM

• Addshore mentioned this in T240410: Wikidata updates(?) are triggering "Call to a member function getPageLanguage() on null" on wmf.10 wikis.Dec 11 2019, 10:05 AM

• Addshore added a subscriber: • Addshore.

Change 556347 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] Fix idlookup dropping pageids

https://gerrit.wikimedia.org/r/556347

Change 556353 had a related patch set uploaded (by Ladsgroup; owner: Michael Große):
[mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.10] Fix idlookup dropping pageids

https://gerrit.wikimedia.org/r/556353

Change 556347 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix idlookup dropping pageids

https://gerrit.wikimedia.org/r/556347

Change 556353 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.10] Fix idlookup dropping pageids

https://gerrit.wikimedia.org/r/556353

Mentioned in SAL (#wikimedia-operations) [2019-12-11T12:03:46Z] <ladsgroup@deploy1001> Synchronized php-1.35.0-wmf.10/extensions/Wikibase/data-access: [[gerrit:556353|Fix idlookup dropping pageids (T236691 T240410)]] (duration: 01m 03s)

Change 550497 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Register mediainfo-specific EntityIdLookup

https://gerrit.wikimedia.org/r/550497

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.11; 2019-12-17); removed MW-1.35-notes (1.35.0-wmf.10; 2019-12-10).Dec 12 2019, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Dec 12 2019, 4:10 PM

Change 556743 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@wmf/1.35.0-wmf.10] Register mediainfo-specific EntityIdLookup

https://gerrit.wikimedia.org/r/556743

gerritbot added a project: Patch-For-Review.Dec 12 2019, 5:19 PM

Change 556743 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@wmf/1.35.0-wmf.10] Register mediainfo-specific EntityIdLookup

https://gerrit.wikimedia.org/r/556743

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.10; 2019-12-10); removed MW-1.35-notes (1.35.0-wmf.11; 2019-12-17).Dec 12 2019, 8:00 PM

Maintenance_bot removed a project: Patch-For-Review.Dec 12 2019, 8:10 PM

matthiasmullie closed this task as a duplicate of T237107: Extend mw.wikibase lua functions to allow accessing Structured Data on Commons items.Jan 6 2020, 12:09 PM