Page MenuHomePhabricator

Theming details for history & diff screens
Closed, ResolvedPublic

Description

This task is to audit theming on the latest black beta build for history & diffs and document any additional changes needed for sepia, dark and black themes.

Simulator Screen Shot - iPhone Xʀ - 2019-10-28 at 14.15.19.png (1×828 px, 187 KB)
IMG_0020.PNG (1×750 px, 196 KB)
IMG_0021.PNG (1×750 px, 206 KB)
IMG_0022.PNG (1×750 px, 214 KB)

Proposed designs

1 revision selected2 revisions selectedDiff with moved paragraphsIndividual revision
Black mode - 1 revision selected.png (1×750 px, 141 KB)
Black mode - 2 revisions selected.png (1×750 px, 143 KB)
Black mode - Diff - Moved paragraph and edited text.png (2×750 px, 349 KB)
Black mode - history - Individual revision.png (1×750 px, 153 KB)
https://zpl.io/bzjX3G3https://zpl.io/bJgxD3Whttps://zpl.io/aXm8ejEhttps://zpl.io/agOdj1Q

Event Timeline

Tsevener renamed this task from Theming details for diff screens & history to Theming details for history & diff screens.Oct 28 2019, 6:27 PM
Tsevener created this task.
JMinor triaged this task as Medium priority.Oct 28 2019, 6:38 PM
JMinor removed a project: Epic.
JMinor moved this task from Needs Triage to Product Backlog on the Wikipedia-iOS-App-Backlog board.
cmadeo updated the task description. (Show Details)

Thanks for making all of these updates @Tsevener! Everything is looking so good! One small tweak, on the History page the back arrow in the header still appears to be blue instead of the same color as the link text.

looking at the arrow color bug, looks like there were some changes to nav bar appearance in iOS 13 - https://developer.apple.com/documentation/uikit/uinavigationbarappearance

looks like an iOS 13.1 bug, appears to be fixed in iOS 13.2

@Tsevener thank you so much for your hard work on this ticket! The themed pages are all looking really good!

JMinor claimed this task.