Allow WikiExporter to function with MCR-only schema
Closed, ResolvedPublic
Actions

Description

WikiExporter has an explicit check that makes it fail if the SCHEMA_COMPAT_WRITE_OLD flag is not set in $wgMultiContentRevisionMigrationStage. This causes all exports to fail in SCHEMA_COMPAT_NEW mode.

This check was needed to avoid breakage while WikiExporter was still relying on the old schema for bulk operations. This has has however been however been resolved by T198706: Make BackupDumper, WikiExporter and XmlDumpWriter compliant with the MCR revision retrival mechanism (main slot only) and T198341: Remove all references to the rev_text_id and ar_text_id fields. This check is now obsolete and should be removed to allow us to switch to SCHEMA_COMPAT_NEW everywhere.

Details

	Subject	Repo	Branch	Lines +/-
	WikiExporter: Remove unnecessary check for SCHEMA_COMPAT_WRITE_OLD flag	mediawiki/core	REL1_34	+8 -27
	WikiExporter: Remove unnecessary check for SCHEMA_COMPAT_WRITE_OLD flag	mediawiki/core	master	+8 -27

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Stalled	None	T174043 Deploy Multi-Content Revisions
Stalled	None	T174045 DB schema migration for MCR
Open	None	T183490 MCR schema migration stage 4: Migrate External Store URLs (wmf production)
Resolved	None	T231668 MCR schema migration
Resolved	Zabe	T231674 [Epic] Remove support for writing to the pre-MCR schema
Resolved	daniel	T231673 Make SCHEMA_COMPAT_NEW the default MCR migration schema
Resolved	None	T231672 Stop writing to pre-MCR fields in WMF production
Resolved	None	T183487 MCR schema migration stage 3: stop using legacy fields
Resolved	Anomie	T198312 Set the WMF cluster to use the new MCR-only schema
Resolved	daniel	T198558 Set testwiki to use the new MCR-only schema
Resolved	daniel	T198559 Set Beta Cluster wikis to use the new MCR-only schema
Resolved	Anomie	T198311 Enable MCR migration stage "write both, read new" on commons beta.
Resolved	Anomie	T197818 Enable MCR migration stage "write both, read old" on commons beta.
Resolved	daniel	T197619 Introduce SCHEMA_COMPAT_XXX constants to allow more fine grained control over the migration process
Resolved	daniel	T198413 Allow multiple slots to be used while still writing to the old as well as the new schema
Resolved	daniel	T236735 Allow WikiExporter to function with MCR-only schema
Resolved	None	T231671 [EPIC] Ensure all direct or indirect access to pre-MCR fields is gated with the MCR migration stage and emits a warning if any pre-MCR schema fields are accessed
Resolved	CCicalese_WMF	T231689 Can get bulk access from code that has been using the 'text' for getQueryInfo()
Resolved	CCicalese_WMF	T231693 No direct or indirect access to pre-MCR fields is ungated
Resolved	daniel	T198341 Remove all references to the rev_text_id and ar_text_id fields
Resolved	• Pchelolo	T198342 Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo().
Resolved	daniel	T198706 Make BackupDumper, WikiExporter and XmlDumpWriter compliant with the MCR revision retrival mechanism (main slot only)
Resolved	BPirkle	T203424 Replace the WikiExporter backup dump streaming mode with batched queries
Resolved	• Pchelolo	T233356 Flow: remove dependency on pre-MCR database schema
Resolved	• Clarakosi	T233357 ReplaceText: remove dependency on pre-MCR database schema
Resolved	daniel	T233358 SpamBlacklist: remove dependency on pre-MCR database schema
Resolved	• Pchelolo	T198343 Replace all calls to Revision::getRevisionText()
Resolved	• Pchelolo	T228675 Remove direct access to the text table from the Translate extension.
Resolved	• Pchelolo	T228988 Create batch access interface for page content
Resolved	• Pchelolo	T233173 Make RevisionStore::newRevisionsFromBatch use BlobStore::getBlobBatch
Resolved	• Pchelolo	T230834 Create batch access interface for BlobStore
Resolved	daniel	T234034 Create low level batch access interface for page content
Resolved	daniel	T233350 ActiveAbstract: remove dependency on pre-MCR database schema
Resolved	• holger.knust	T233353 EntitySchema: remove dependency on pre-MCR database schema
Resolved	• Pchelolo	T233355 WikimediaMaintenance: remove dependency on pre-MCR database schema
Resolved	None	T231699 A warning is emitted if any pre-MCR fields are accessed
Resolved	None	T200918 Make sure code that accesses legacy pre-MCR fields triggers warnings before switching off WRITE_OLD (compat) mode.

Event Timeline

daniel created this task.Oct 28 2019, 8:04 PM

daniel added parent tasks: T231673: Make SCHEMA_COMPAT_NEW the default MCR migration schema, T198558: Set testwiki to use the new MCR-only schema.

Change 546711 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] WikiExporter: remove check for SCHEMA_COMPAT_WRITE_OLD flag.

https://gerrit.wikimedia.org/r/546711

gerritbot added a project: Patch-For-Review.Oct 28 2019, 8:12 PM

Change 546711 merged by jenkins-bot:
[mediawiki/core@master] WikiExporter: Remove unnecessary check for SCHEMA_COMPAT_WRITE_OLD flag

https://gerrit.wikimedia.org/r/546711

Maintenance_bot removed a project: Patch-For-Review.Oct 28 2019, 9:10 PM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.4; 2019-10-29).Oct 28 2019, 10:01 PM

Fixed, confirmed on beta:
https://en.wikipedia.beta.wmflabs.org/wiki/Special:Export/0.42323637011943815

daniel mentioned this in T198559: Set Beta Cluster wikis to use the new MCR-only schema.Oct 29 2019, 8:49 AM

Change 551599 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@REL1_34] WikiExporter: Remove unnecessary check for SCHEMA_COMPAT_WRITE_OLD flag

https://gerrit.wikimedia.org/r/551599

gerritbot added a project: Patch-For-Review.Nov 18 2019, 6:12 PM

Change 551599 merged by jenkins-bot:
[mediawiki/core@REL1_34] WikiExporter: Remove unnecessary check for SCHEMA_COMPAT_WRITE_OLD flag

https://gerrit.wikimedia.org/r/551599

ReleaseTaggerBot added a project: MW-1.34-notes.Nov 19 2019, 10:00 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 19 2019, 10:10 PM