Special:Translated - "used n times" has an extra 〉
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	DannyS712
	Oct 28 2019, 8:29 PM

Description

The text is currently

mw.msg(
	'tux-editor-n-uses',
	mw.language.convertNumber( suggestion.count )
) + '  〉'

I propose that the trailing 〉 be removed. Any objections?

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/Translate	master	+2 -2	Remove extraneous 〉 from `tux-editor-n-uses` message

Customize query in gerrit

Event Timeline

DannyS712 created this task.Oct 28 2019, 8:29 PM

Restricted Application added a project: User-DannyS712. · View Herald TranscriptOct 28 2019, 8:29 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@Nikerabbit would this be okay to do?

But why would you remove it?

In T236736#5613335, @Nikerabbit wrote:

But why would you remove it?

Because it renders as "used 2 times 〉", and without a matching opening brace this looks odd

Various kind of arrows are common way to highlight interactive elements.

https://commons.wikimedia.org/w/index.php?title=File:Translate-workflow-spec.pdf&page=14 doesn't have the arrow though.

In T236736#5615235, @Nikerabbit wrote:

https://commons.wikimedia.org/w/index.php?title=File:Translate-workflow-spec.pdf&page=14 doesn't have the arrow though.

Then I'm not sure. As far as I can tell, you added it with https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Translate/+/45932/

Nikerabbit moved this task from Backlog to tux on the MediaWiki-extensions-Translate board.Nov 7 2019, 9:09 AM

Change 550586 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Translate@master] Remove extraneous 〉 from tux-editor-n-uses message

https://gerrit.wikimedia.org/r/550586

gerritbot added a project: Patch-For-Review.Nov 13 2019, 3:51 AM

DannyS712 moved this task from Next to Awaiting review and deployment on the User-DannyS712 board.Nov 13 2019, 3:52 AM