Page MenuHomePhabricator

Use local DBs on testcommonswiki and testwikidatawiki
Open, LowPublic

Description

WikimediaEditorTasks is currently enabled on commonswiki and wikidatawiki, as well as their production testing counterparts, testcommonswiki and testwikidatawiki. All use the wikishared database in the x1 cluster. However, we probably don't want to count edits to the test wikis in our feature usage metrics. Counts and streaks for testwikidatawiki and testcommonswiki should be confined to local tables.

Data volume on the test wikis is expected to be very low.

Event Timeline

Mholloway added a subscriber: jcrespo.

Pinging @jcrespo as a heads-up before I create the local tables and update the wiki configs. Please let me know if you have any objection to this change. Thank you.

Are WikimediaEditorTasks tables public? Have their columns been added to the allowed columns? In general you can create tables on your own, but we ask to ping us in advance so they are added to either:

puppet:modules/role/templates/mariadb/private_tables.txt.erb for tables that should not be replicated
or to
puppet:modules/role/files/mariadb/filtered_tables.txt to ok the columns with public data.

If they are fully public, they can be done after the fact. But we need to account those tables.

Putting a reference of the patch or actions here would be also nice, in case we see something weird with ongoing maintenance on the sections.

Mholloway lowered the priority of this task from Medium to Low.Nov 4 2019, 3:20 PM

The tables are being replicated to labs, but not yet exposed by any view. T218302#5080997 is the most recent update.

This isn't urgent, so I've reduced the priority to low.

Ah, so that was handled already by Manuel. Sorry, I wasn't aware of that ticket. As far as I understand, there is nothing really for us to do here, as the tables were confirmed as 100% public (correct?) (so no filterning setup is needed). No blockers from us for you to proceed.

Edit: maybe you will need us to delete the corresponding tables on x1 when migrated, after the fact?

We would still want to continue having the non-test wikis use the wikishared DB; this task is just to have testwikidatawiki and testcommonswiki use their local DBs instead. The underlying concern with having the test wikis also using the wikishared DB is that someone could inadvertantly skew feature usage metrics derived from the shared DB tables through testing on the test wikis. But it's a relatively unlikely scenario; in team discussion last week we were actually considering declining this task as not worth the trouble and added complexity.

Sorry I wasn't clear, I mean if you want to delete the tables on x1 for the test wikis only, if they will become unused? (just a suggestion, not a big deal)

the tables were confirmed as 100% public (correct?)

If I understand the question, that's correct, there is no private data in the tables.