Page MenuHomePhabricator
Create Task
Maniphest T236756

add "warningbox" class for CentralAuth and GlobalBlocking extension to "onSpecialContributionsBeforeMainOutput" hook output
Closed, ResolvedPublic
Actions

Description

As follows T234509: Add `warningbox` to `mw-warning-with-logexcerpt` carrying elements, we need add class warningbox to div having mw-warning-with-logexcerpt class outputs for keep styling.

Details

SubjectRepoBranchLines +/-
Add 'warningbox' class for onSpecialContributionsBeforeMainOutputmediawiki/extensions/CentralAuthmaster+1 -1
Add 'warningbox' class for onSpecialContributionsBeforeMainOutputmediawiki/extensions/GlobalBlockingmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Rxy created this task.Oct 29 2019, 6:25 AM
Restricted Application added a project: User-Rxy. · View Herald TranscriptOct 29 2019, 6:25 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Oct 29 2019, 6:28 AM

Change 546791 had a related patch set uploaded (by Rxy; owner: Rxy):
[mediawiki/extensions/CentralAuth@master] Add 'warningbox' class for onSpecialContributionsBeforeMainOutput

https://gerrit.wikimedia.org/r/546791

gerritbot added a project: Patch-For-Review.Oct 29 2019, 6:28 AM
gerritbot added a comment.Oct 29 2019, 6:36 AM

Change 546792 had a related patch set uploaded (by Rxy; owner: Rxy):
[mediawiki/extensions/GlobalBlocking@master] Add 'warningbox' class for onSpecialContributionsBeforeMainOutput

https://gerrit.wikimedia.org/r/546792

Rxy moved this task from Backlog to In progress - Development on the User-Rxy board.Oct 29 2019, 6:41 AM
Rxy moved this task from In progress - Development to Development on the User-Rxy board.
Volker_E subscribed.Oct 30 2019, 7:33 PM

@Rxy Thanks for your patches, would you provide a before/after screenshot?

Rxy added a comment.Nov 8 2019, 12:18 PM
In T236756#5621021, @Volker_E wrote:

@Rxy Thanks for your patches, would you provide a before/after screenshot?

ca-diff.png (603×964 px, 30 KB)
gb-diff.png (674×970 px, 50 KB)

gerritbot added a comment.Nov 13 2019, 11:04 PM

Change 546791 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Add 'warningbox' class for onSpecialContributionsBeforeMainOutput

https://gerrit.wikimedia.org/r/546791

gerritbot added a comment.Nov 13 2019, 11:04 PM

Change 546792 merged by jenkins-bot:
[mediawiki/extensions/GlobalBlocking@master] Add 'warningbox' class for onSpecialContributionsBeforeMainOutput

https://gerrit.wikimedia.org/r/546792

Maintenance_bot removed a project: Patch-For-Review.Nov 13 2019, 11:10 PM
Volker_E closed this task as Resolved.Nov 13 2019, 11:31 PM
Volker_E triaged this task as Medium priority.

Thanks @Rxy!

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.8; 2019-11-26).Nov 14 2019, 12:00 AM
Urbanecm merged a task: T239513: At some wikis, "Account is locked" message is not formatted properly.Nov 30 2019, 5:27 PM
Urbanecm subscribed.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL