Upgrade service-runner on AQS to unblock rsyslog logging
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	elukey
	Oct 29 2019, 7:47 AM

Description

In T219928#5610811, @mobrovac wrote:

In T219928#5610521, @elukey wrote:

@mobrovac I just noticed in the description the newest version of service-runner part. We currently run 2.6.7, is it enough?

Eh no, unfortunately not. Support for prefixed syslog logging came in v2.6.15. The [diff between v2.6.7 and v2.6.15](https://github.com/wikimedia/service-runner/compare/v2.6.7...v2.6.15) suggests it's safe for you to update to that version. Moreover, it would beneficial if you could update to the latest version, v2.7.3 as it brings many improvements and bug fixes over v2.6.15. Again, the diff suggests there are no backwards-incompatible interface changes, so you should fine in doing so.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Update service-runner version	analytics/aqs	master	+741 -253

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	herron	T227080 Deprecate all non-Kafka logstash inputs
Invalid	None	T225122 Migrate services using deprecated Gelf logstash input to Kafka enabled logging pipeline
Resolved	herron	T225125 Migrate Elasticsearch from deprecated Gelf logstash input to rsyslog Kafka logging pipeline
Resolved	• Pchelolo	T211125 Move service-runner to new logging infrastructure
Resolved	elukey	T219928 Move AQS logging to new logging pipeline
Resolved	Milimetric	T236757 Upgrade service-runner on AQS to unblock rsyslog logging

Event Timeline

elukey created this task.Oct 29 2019, 7:47 AM

elukey mentioned this in T219928: Move AQS logging to new logging pipeline.

@Pchelolo last time we talked about T219922 there was some service-runner (or service-template-node?) related blocker to doing this. Is that still true or could this happen any time?

@Ottomata AQS is not on k8s, so for AQS it's all ready - just need the latest service-runner and a config change.

Oh ho hoooo righto.

Milimetric claimed this task.Jan 2 2020, 5:59 PM

Milimetric added a project: Analytics-Kanban.

I think we can safely skip this. We're going to be updating service-runner based services to be prometheus-native (see https://github.com/wikimedia/service-runner/pull/221), so we can leapfrog this.

elukey moved this task from Backlog to Keep an eye on it on the User-Elukey board.Jan 3 2020, 10:59 AM

Milimetric moved this task from Next Up to In Progress on the Analytics-Kanban board.Jan 3 2020, 4:51 PM

ok, well we need this for T219928 so I'm going to upgrade and test, to take care of any snags before the next upgrade. Then we can delay deploying if we want to upgrade again after PR 221.

Change 562078 had a related patch set uploaded (by Milimetric; owner: Milimetric):
[analytics/aqs@master] [WIP] Update service-runner version

https://gerrit.wikimedia.org/r/562078

gerritbot added a project: Patch-For-Review.Jan 6 2020, 1:50 AM

Milimetric moved this task from In Progress to In Code Review on the Analytics-Kanban board.Jan 6 2020, 1:50 AM

@Milimetric you can just update the service-runner version, but it would probably be better to use this as an opportunity to do so by updating to the latest service-template-node:

https://www.mediawiki.org/wiki/ServiceTemplateNode/Updating

Milimetric moved this task from In Code Review to In Progress on the Analytics-Kanban board.Jan 13 2020, 4:05 PM

Milimetric moved this task from In Progress to In Code Review on the Analytics-Kanban board.Jan 14 2020, 1:51 PM

Change 562078 merged by Milimetric:
[analytics/aqs@master] Update service-runner version

https://gerrit.wikimedia.org/r/562078