Page MenuHomePhabricator
Create Task
Maniphest T236803

Donors being asked to log in during donation (INGENICO)
Open, MediumPublic2 Estimated Story Points
Actions

Description

Separated out from original amazon instance of this bug recorded here

In T234538#5577888, @MBeat33 wrote:

Not sure if this is related but the donor in cid=9155230 inadvertently made 3 Ingenico contribs today because they said the form asked them to "log in to the Foundation". I asked them to confirm whether the page they saw was https://payments.wikimedia.org/index.php/error-default. Their donations are

INGENICO 000000657040023246060000100001
INGENICO 000000657040023245490000100001
INGENICO 000000657040023245280000100001

if the logs can illuminate anything.

In T234538#5580747, @MBeat33 wrote:

It sounds like donors are still seeing this:

628208 10/16 I tried to donate $75 but once I had completed the information, the system wanted me to "log in". I was unable to log in. I ended up trying to create an account and getting an email from mini-wikis or some similar name related to wikipedia. I do not wish to join or log in, I was simply trying to make a donation.

This was an Ingenico donor, who eventually succeeded: INGENICO 000000657040023523390000100001

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Iframe liberator always reloads pageEjeggmediawiki/extensions/DonationInterfacemaster+6 -8
Customize query in gerrit

Related Objects

Event Timeline

jgleeson created this task.Oct 29 2019, 3:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 29 2019, 3:12 PM
• DStrine moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.Oct 29 2019, 3:36 PM
• DStrine moved this task from Sprint +1 to Current Sprint on the Fundraising-Backlog board.Oct 29 2019, 8:49 PM
• DStrine added a project: Fundraising Sprint Visual Basic Instinct.Oct 29 2019, 8:57 PM
jgleeson moved this task from Backlog to Doing on the Fundraising Sprint Visual Basic Instinct board.Oct 29 2019, 9:32 PM
jgleeson added a comment.Oct 30 2019, 6:44 PM

I think I might know what's happening here, it looks like at some point the last donor was sent here - https://payments.wikimedia.org/index.php/Special:IngenicoGatewayResult?order_id=70794726.1&hostedCheckoutId=8467accc-a8ab-47f6-821f-cb6b3bbee02f&RETURNMAC=88667854-1e67-4ffb-9890-eab8811aa34a&isFramed=false which shows a login link at the top right.

I'm not sure why this happened yet.

MBeat33 added a subscriber: krobinson.Nov 4 2019, 9:34 PM

Donor cid=36730826 got this login error today. They donated successfully INGENICO ID 000000657040025678570000100001, Ref 71463648.2 but also ended up as a result of some confusion making a duplicate donation as cid=36730790. We'll refund one of them and apologize for the error.

Ejegg subscribed.Nov 4 2019, 10:38 PM

Looks like our code for dealing with dead sessions on donor return isn't working correctly. What we SHOULD be doing is showing the donor the Thank You page then waiting for the orphan rectifier to try to push the donation through.

I'm trying to figure out if it was never working, or if we broke it in the last year. My first thought was that I broke it in rEDOI0be2891b8795, but I've tried checking out the commits a couple before that and it seems to act the same way.

gerritbot added a comment.Nov 4 2019, 11:12 PM

Change 548544 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Iframe liberator always reloads page

https://gerrit.wikimedia.org/r/548544

gerritbot added a project: Patch-For-Review.Nov 4 2019, 11:12 PM
jgleeson added a comment.Nov 5 2019, 2:52 PM

@Ejegg could you add some notes on how I can test your patch please? Thanks in advance!

jgleeson added a comment.Nov 5 2019, 3:00 PM

Tested out @Ejegg's patch and it now redirects to the thank you page fixing the issue.

gerritbot added a comment.Nov 5 2019, 3:05 PM

Change 548544 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Iframe liberator always reloads page

https://gerrit.wikimedia.org/r/548544

Maintenance_bot removed a project: Patch-For-Review.Nov 5 2019, 3:10 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.5; 2019-11-05).Nov 5 2019, 4:00 PM
Ejegg moved this task from Doing to Review on the Fundraising Sprint Visual Basic Instinct board.Nov 5 2019, 8:03 PM
Ejegg moved this task from Review to Deployed on the Fundraising Sprint Visual Basic Instinct board.Nov 5 2019, 8:06 PM
Ejegg closed this task as Resolved.Nov 12 2019, 9:11 PM
Ejegg triaged this task as Medium priority.
Ejegg set the point value for this task to 2.
MBeat33 reopened this task as Open.Dec 5 2019, 3:44 AM

Zendesk 674304 reported this today:

"...after I click on the “mastercard” symbol, I am taken to a WikiMedia site that requests a “Log In” to continue!?? I don’t have a “Log In” for Wiki Media!?"

Their email address is at cid=8304132 from past donation. Please let me know if I can ask them for more info, or create a new Phab task for this.

jgleeson added a project: Fundraising Sprint X-rays.Dec 5 2019, 6:13 PM
jgleeson added a comment.EditedDec 5 2019, 7:18 PM

I'm looking in to this. Not found anything as of yet

jgleeson moved this task from Backlog to Doing on the Fundraising Sprint X-rays board.Dec 6 2019, 1:54 PM
• DStrine added a project: Fundraising Sprint YAMLton, the Musical.Dec 10 2019, 9:18 PM
• DStrine removed a project: Fundraising Sprint YAMLton, the Musical.Dec 13 2019, 6:01 PM
• DStrine moved this task from Current Sprint to Q4 FY21-22 on the Fundraising-Backlog board.
Aklapper removed jgleeson as the assignee of this task.Mar 13 2022, 7:49 PM

Removing task assignee due to inactivity, as this open task has been assigned for more than two years. See the email sent to the task assignee on February 06th 2022 (and T295729).

Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome.

If this task has been resolved in the meantime, or should not be worked on ("declined"), please update its task status via "Add Action… 🡒 Change Status".

Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator.

XenoRyet moved this task from Q4 FY21-22 to Unscheduled on the Fundraising-Backlog board.Mar 13 2023, 9:46 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits