A number of the methods in Parser.php are unused outside the class itself, but are public for historical reasons.
We need to first deprecate these, then eventually make them private.
A number of the methods in Parser.php are unused outside the class itself, but are public for historical reasons.
We need to first deprecate these, then eventually make them private.
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Open | None | T261329 Prepare Parsoid for MW | |||
Open | None | T236809 Refactor Parser.php to allow alternate parser (Parsoid) | |||
Open | None | T236810 Make private methods of Parser.php actually private |
Change 546793 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Deprecate Parser implementation methods (will be private in next release)
Change 546967 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Deprecate Parser::areSubpagesAllowed() / Parser::maybeDoSubpageLink()
Change 546968 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Deprecate Parser::armorLinks() / Parser::makeKnownLinkHolder()
Change 546969 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Deprecate Parser::splitWhitespace() / Parser::createAssocArgs()
Change 546981 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Deprecate Parser::replaceLinkHolders/replaceLinkHoldersText
Change 546982 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Deprecate Parser::getImageParams()
Change 546982 abandoned by C. Scott Ananian:
Deprecate Parser::getImageParams()
Reason:
squashed into I44458490fa86abd0ead048a4c94021da6be333f0
@cscott I was wondering if there is a preferred migration path away from Parser::replaceLinkHolders for code that relied on it. I see that the mLinkHolders field in Parser is public, but I imagine that won't stay that way either, right? Thanks in advance!
Change 547048 had a related patch set uploaded (by Krinkle; owner: C. Scott Ananian):
[mediawiki/core@REL1_34] Deprecate Parser implementation methods (will be private in next release)
Change 547048 merged by jenkins-bot:
[mediawiki/core@REL1_34] Deprecate Parser implementation methods (will be private in next release)
Change 546793 merged by jenkins-bot:
[mediawiki/core@master] Deprecate Parser implementation methods (will be private in next release)
Change 547259 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/DataTable2@master] Stop using the deprecated Parser::createAssocArgs() function from core
Change 547259 merged by jenkins-bot:
[mediawiki/extensions/DataTable2@master] Stop using the deprecated Parser::createAssocArgs() function from core
Change 546967 merged by jenkins-bot:
[mediawiki/core@master] Deprecate Parser::areSubpagesAllowed() / Parser::maybeDoSubpageLink()
Change 546969 merged by jenkins-bot:
[mediawiki/core@master] Deprecate Parser::splitWhitespace() / Parser::createAssocArgs()
Change 546968 merged by jenkins-bot:
[mediawiki/core@master] Deprecate additional public methods of Parser
Change 546981 merged by jenkins-bot:
[mediawiki/core@master] Deprecate Parser::replaceLinkHolders / replaceLinkHoldersText
Change 547315 had a related patch set uploaded (by Jforrester; owner: C. Scott Ananian):
[mediawiki/core@REL1_34] Deprecate Parser::areSubpagesAllowed() / Parser::maybeDoSubpageLink()
Change 547316 had a related patch set uploaded (by Jforrester; owner: C. Scott Ananian):
[mediawiki/core@REL1_34] Deprecate Parser::splitWhitespace() / Parser::createAssocArgs()
Change 547317 had a related patch set uploaded (by Jforrester; owner: C. Scott Ananian):
[mediawiki/core@REL1_34] Deprecate Parser::replaceLinkHolders / replaceLinkHoldersText
Change 547318 had a related patch set uploaded (by Jforrester; owner: C. Scott Ananian):
[mediawiki/core@REL1_34] Deprecate additional public methods of Parser
Change 547315 merged by jenkins-bot:
[mediawiki/core@REL1_34] Deprecate Parser::areSubpagesAllowed() / Parser::maybeDoSubpageLink()
Change 547316 merged by jenkins-bot:
[mediawiki/core@REL1_34] Deprecate Parser::splitWhitespace() / Parser::createAssocArgs()
Change 547317 merged by jenkins-bot:
[mediawiki/core@REL1_34] Deprecate Parser::replaceLinkHolders / replaceLinkHoldersText
Change 547318 merged by jenkins-bot:
[mediawiki/core@REL1_34] Deprecate additional public methods of Parser
Change 548458 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Parser: remove/make private historically-public methods
Change 548458 merged by jenkins-bot:
[mediawiki/core@master] Parser: remove/make private historically-public methods
Good question. I haven't quite figured that out yet. You're right that public mLinkHolders needs to go away. Parsoid doesn't have any corresponding concept for "link holders"; we need to figure out if that needs to be added to Parsoid and/or replaced with something different for the eventual parser migration.
Hi folks, I see mLinkHolders is now private, and that Parser::replaceLinkHolders has a deprecation tag in its comment. Is there at this stage a recommended alternative for parsing linkHolders in a string that an extension has? If not, is there any other way to go about doing so, without having to re-parse the entire content within which the links are held?
Change 832494 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):
[mediawiki/core@master] Make private deprecated public properties of Parser
Change 832494 merged by jenkins-bot:
[mediawiki/core@master] Make private deprecated public properties of Parser
@cscott: Hi, all related patches in Gerrit have been merged. Can this task be resolved (via Add Action... → Change Status in the dropdown menu), or is there more to do in this task? Asking as you are set as task assignee. Thanks in advance!
@cscott: Removing task assignee as this open task has been assigned for more than two years - See the email sent to task assignee on Feburary 22nd, 2023.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome! :)
If this task has been resolved in the meantime, or should not be worked on by anybody ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!
Change 1004158 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):
[mediawiki/core@master] [Parser] Emit warnings for accesses to deprecated $ot property
Change 1004162 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):
[mediawiki/core@master] [Parser] Emit warnings for accesses to deprecated $mTitle property
Change 1004163 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):
[mediawiki/core@master] [Parser] Emit warnings for accesses to deprecated $mOptions property
Change #1019355 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):
[mediawiki/core@master] [Parser] Mark $mPPNodeCount and $mHighestExpansionDepth @internal
Change #1004158 merged by jenkins-bot:
[mediawiki/core@master] [Parser] Emit warnings for accesses to deprecated $ot property
Change #1004162 merged by jenkins-bot:
[mediawiki/core@master] [Parser] Emit warnings for accesses to deprecated $mTitle property
Change #1004163 merged by jenkins-bot:
[mediawiki/core@master] [Parser] Emit warnings for accesses to deprecated $mOptions property
Change #1019355 merged by jenkins-bot:
[mediawiki/core@master] [Parser] Mark $mPPNodeCount and $mHighestExpansionDepth @internal
Change #1019871 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):
[mediawiki/core@REL1_42] [Parser] Emit warnings for accesses to deprecated $ot property
Change #1019872 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):
[mediawiki/core@REL1_42] [Parser] Emit warnings for accesses to deprecated $mTitle property
Change #1019873 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):
[mediawiki/core@REL1_42] [Parser] Emit warnings for accesses to deprecated $mOptions property
Change #1019874 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):
[mediawiki/core@REL1_42] [Parser] Mark $mPPNodeCount and $mHighestExpansionDepth @internal
Change #1019871 merged by jenkins-bot:
[mediawiki/core@REL1_42] [Parser] Emit warnings for accesses to deprecated $ot property
Change #1019872 merged by jenkins-bot:
[mediawiki/core@REL1_42] [Parser] Emit warnings for accesses to deprecated $mTitle property
Change #1019873 merged by jenkins-bot:
[mediawiki/core@REL1_42] [Parser] Emit warnings for accesses to deprecated $mOptions property
Change #1019874 merged by jenkins-bot:
[mediawiki/core@REL1_42] [Parser] Mark $mPPNodeCount and $mHighestExpansionDepth @internal