Page MenuHomePhabricator
Create Task
Maniphest T236810

Make private methods of Parser.php actually private
Open, MediumPublic
Actions

Description

A number of the methods in Parser.php are unused outside the class itself, but are public for historical reasons.

We need to first deprecate these, then eventually make them private.

Details

SubjectRepoBranchLines +/-
[Parser] Mark $mPPNodeCount and $mHighestExpansionDepth @internalmediawiki/coreREL1_42+6 -2
[Parser] Emit warnings for accesses to deprecated $mTitle propertymediawiki/coreREL1_42+3 -1
[Parser] Emit warnings for accesses to deprecated $mOptions propertymediawiki/coreREL1_42+4 -2
[Parser] Emit warnings for accesses to deprecated $ot propertymediawiki/coreREL1_42+16 -6
[Parser] Mark $mPPNodeCount and $mHighestExpansionDepth @internalmediawiki/coremaster+6 -2
[Parser] Emit warnings for accesses to deprecated $mOptions propertymediawiki/coremaster+4 -2
[Parser] Emit warnings for accesses to deprecated $mTitle propertymediawiki/coremaster+3 -1
[Parser] Emit warnings for accesses to deprecated $ot propertymediawiki/coremaster+16 -6
Make private deprecated public properties of Parsermediawiki/coremaster+14 -21
Parser: remove/make private historically-public methodsmediawiki/coremaster+33 -400
Deprecate additional public methods of Parsermediawiki/coreREL1_34+98 -16
Deprecate Parser implementation methods (will be private in next release)mediawiki/coreREL1_34+251 -43
Deprecate Parser::replaceLinkHolders / replaceLinkHoldersTextmediawiki/coreREL1_34+31 -4
Deprecate Parser::splitWhitespace() / Parser::createAssocArgs()mediawiki/coreREL1_34+6 -1
Deprecate Parser::areSubpagesAllowed() / Parser::maybeDoSubpageLink()mediawiki/coreREL1_34+15 -4
Deprecate Parser::replaceLinkHolders / replaceLinkHoldersTextmediawiki/coremaster+30 -4
Deprecate Parser::splitWhitespace() / Parser::createAssocArgs()mediawiki/coremaster+6 -1
Deprecate additional public methods of Parsermediawiki/coremaster+100 -17
Deprecate Parser::areSubpagesAllowed() / Parser::maybeDoSubpageLink()mediawiki/coremaster+15 -4
Stop using the deprecated Parser::createAssocArgs() function from coremediawiki/extensions/DataTable2master+31 -1
Deprecate Parser implementation methods (will be private in next release)mediawiki/coremaster+251 -43
Deprecate Parser::getImageParams()mediawiki/coremaster+11 -1
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

cscott created this task.Oct 29 2019, 4:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 29 2019, 4:12 PM
cscott added a parent task: T236809: Refactor Parser.php to allow alternate parser (Parsoid).Oct 29 2019, 4:12 PM
gerritbot added a comment.Oct 29 2019, 4:26 PM

Change 546793 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Deprecate Parser implementation methods (will be private in next release)

https://gerrit.wikimedia.org/r/546793

gerritbot added a project: Patch-For-Review.Oct 29 2019, 4:26 PM

Change 546967 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Deprecate Parser::areSubpagesAllowed() / Parser::maybeDoSubpageLink()

https://gerrit.wikimedia.org/r/546967

gerritbot added a comment.Oct 29 2019, 4:26 PM

Change 546968 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Deprecate Parser::armorLinks() / Parser::makeKnownLinkHolder()

https://gerrit.wikimedia.org/r/546968

gerritbot added a comment.Oct 29 2019, 4:26 PM

Change 546969 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Deprecate Parser::splitWhitespace() / Parser::createAssocArgs()

https://gerrit.wikimedia.org/r/546969

gerritbot added a comment.Oct 29 2019, 4:58 PM

Change 546981 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Deprecate Parser::replaceLinkHolders/replaceLinkHoldersText

https://gerrit.wikimedia.org/r/546981

gerritbot added a comment.Oct 29 2019, 4:58 PM

Change 546982 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Deprecate Parser::getImageParams()

https://gerrit.wikimedia.org/r/546982

Anomie added a project: Platform Team Workboards (Clinic Duty Team).Oct 29 2019, 5:20 PM
Anomie moved this task from Inbox to External Code Review In Progress on the Platform Team Workboards (Clinic Duty Team) board.
gerritbot added a comment.Oct 29 2019, 6:28 PM

Change 546982 abandoned by C. Scott Ananian:
Deprecate Parser::getImageParams()

Reason:
squashed into I44458490fa86abd0ead048a4c94021da6be333f0

https://gerrit.wikimedia.org/r/546982

TK-999 subscribed.Oct 29 2019, 7:02 PM

@cscott I was wondering if there is a preferred migration path away from Parser::replaceLinkHolders for code that relied on it. I see that the mLinkHolders field in Parser is public, but I imagine that won't stay that way either, right? Thanks in advance!

gerritbot added a comment.Oct 29 2019, 9:34 PM

Change 547048 had a related patch set uploaded (by Krinkle; owner: C. Scott Ananian):
[mediawiki/core@REL1_34] Deprecate Parser implementation methods (will be private in next release)

https://gerrit.wikimedia.org/r/547048

gerritbot added a comment.Oct 29 2019, 9:44 PM

Change 547048 merged by jenkins-bot:
[mediawiki/core@REL1_34] Deprecate Parser implementation methods (will be private in next release)

https://gerrit.wikimedia.org/r/547048

gerritbot added a comment.Oct 29 2019, 9:47 PM

Change 546793 merged by jenkins-bot:
[mediawiki/core@master] Deprecate Parser implementation methods (will be private in next release)

https://gerrit.wikimedia.org/r/546793

ReleaseTaggerBot added projects: MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), MW-1.34-notes.Oct 29 2019, 10:00 PM
gerritbot added a comment.Oct 30 2019, 4:33 PM

Change 547259 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/DataTable2@master] Stop using the deprecated Parser::createAssocArgs() function from core

https://gerrit.wikimedia.org/r/547259

gerritbot added a comment.Oct 30 2019, 8:24 PM

Change 547259 merged by jenkins-bot:
[mediawiki/extensions/DataTable2@master] Stop using the deprecated Parser::createAssocArgs() function from core

https://gerrit.wikimedia.org/r/547259

gerritbot added a comment.Oct 30 2019, 8:33 PM

Change 546967 merged by jenkins-bot:
[mediawiki/core@master] Deprecate Parser::areSubpagesAllowed() / Parser::maybeDoSubpageLink()

https://gerrit.wikimedia.org/r/546967

gerritbot added a comment.Oct 30 2019, 8:34 PM

Change 546969 merged by jenkins-bot:
[mediawiki/core@master] Deprecate Parser::splitWhitespace() / Parser::createAssocArgs()

https://gerrit.wikimedia.org/r/546969

gerritbot added a comment.Oct 30 2019, 8:34 PM

Change 546968 merged by jenkins-bot:
[mediawiki/core@master] Deprecate additional public methods of Parser

https://gerrit.wikimedia.org/r/546968

gerritbot added a comment.Oct 30 2019, 8:36 PM

Change 546981 merged by jenkins-bot:
[mediawiki/core@master] Deprecate Parser::replaceLinkHolders / replaceLinkHoldersText

https://gerrit.wikimedia.org/r/546981

Maintenance_bot removed a project: Patch-For-Review.Oct 30 2019, 9:10 PM
gerritbot added a comment.Oct 30 2019, 9:35 PM

Change 547315 had a related patch set uploaded (by Jforrester; owner: C. Scott Ananian):
[mediawiki/core@REL1_34] Deprecate Parser::areSubpagesAllowed() / Parser::maybeDoSubpageLink()

https://gerrit.wikimedia.org/r/547315

gerritbot added a project: Patch-For-Review.Oct 30 2019, 9:35 PM

Change 547316 had a related patch set uploaded (by Jforrester; owner: C. Scott Ananian):
[mediawiki/core@REL1_34] Deprecate Parser::splitWhitespace() / Parser::createAssocArgs()

https://gerrit.wikimedia.org/r/547316

gerritbot added a comment.Oct 30 2019, 9:35 PM

Change 547317 had a related patch set uploaded (by Jforrester; owner: C. Scott Ananian):
[mediawiki/core@REL1_34] Deprecate Parser::replaceLinkHolders / replaceLinkHoldersText

https://gerrit.wikimedia.org/r/547317

gerritbot added a comment.Oct 30 2019, 9:36 PM

Change 547318 had a related patch set uploaded (by Jforrester; owner: C. Scott Ananian):
[mediawiki/core@REL1_34] Deprecate additional public methods of Parser

https://gerrit.wikimedia.org/r/547318

gerritbot added a comment.Oct 30 2019, 9:44 PM

Change 547315 merged by jenkins-bot:
[mediawiki/core@REL1_34] Deprecate Parser::areSubpagesAllowed() / Parser::maybeDoSubpageLink()

https://gerrit.wikimedia.org/r/547315

gerritbot added a comment.Oct 30 2019, 9:46 PM

Change 547316 merged by jenkins-bot:
[mediawiki/core@REL1_34] Deprecate Parser::splitWhitespace() / Parser::createAssocArgs()

https://gerrit.wikimedia.org/r/547316

gerritbot added a comment.Oct 30 2019, 9:46 PM

Change 547317 merged by jenkins-bot:
[mediawiki/core@REL1_34] Deprecate Parser::replaceLinkHolders / replaceLinkHoldersText

https://gerrit.wikimedia.org/r/547317

gerritbot added a comment.Oct 30 2019, 9:46 PM

Change 547318 merged by jenkins-bot:
[mediawiki/core@REL1_34] Deprecate additional public methods of Parser

https://gerrit.wikimedia.org/r/547318

Maintenance_bot removed a project: Patch-For-Review.Oct 30 2019, 10:10 PM
gerritbot added a comment.Nov 4 2019, 7:53 PM

Change 548458 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Parser: remove/make private historically-public methods

https://gerrit.wikimedia.org/r/548458

gerritbot added a project: Patch-For-Review.Nov 4 2019, 7:53 PM
gerritbot added a comment.Nov 4 2019, 9:06 PM

Change 548458 merged by jenkins-bot:
[mediawiki/core@master] Parser: remove/make private historically-public methods

https://gerrit.wikimedia.org/r/548458

Maintenance_bot removed a project: Patch-For-Review.Nov 4 2019, 9:10 PM
ssastry edited projects, added Parsoid; removed Parsoid-PHP.Nov 5 2019, 5:53 PM
ssastry removed a subscriber: Parsing-Team--ARCHIVED.
cscott added a comment.Nov 5 2019, 6:38 PM
In T236810#5616875, @TK-999 wrote:

@cscott I was wondering if there is a preferred migration path away from Parser::replaceLinkHolders for code that relied on it. I see that the mLinkHolders field in Parser is public, but I imagine that won't stay that way either, right? Thanks in advance!

Good question. I haven't quite figured that out yet. You're right that public mLinkHolders needs to go away. Parsoid doesn't have any corresponding concept for "link holders"; we need to figure out if that needs to be added to Parsoid and/or replaced with something different for the eventual parser migration.

LGoto moved this task from Needs Triage to Backlog on the Parsoid board.Feb 15 2020, 12:05 AM
LGoto moved this task from Backlog to Non-Parsing-Team Tasks on the Parsoid board.Feb 21 2020, 5:28 PM
WDoranWMF moved this task from External Code Review In Progress to External Code Review Completed on the Platform Team Workboards (Clinic Duty Team) board.Mar 3 2020, 8:56 PM
ssastry assigned this task to cscott.Mar 30 2020, 5:44 PM
ssastry triaged this task as Medium priority.
ssastry added a project: Parsing-Active-Work.
ssastry moved this task from Incoming Work (but not yet ready) to Todo (Roadmap Critical Path) on the Parsing-Active-Work board.Apr 20 2020, 9:16 PM
LGoto moved this task from Todo (Roadmap Critical Path) to Doing (Roadmap Critical Path) on the Parsing-Active-Work board.Jun 11 2020, 5:42 PM
LGoto moved this task from Doing (Roadmap Critical Path) to Todo (Roadmap Critical Path) on the Parsing-Active-Work board.
Naypta subscribed.Jun 27 2020, 12:01 PM

Hi folks, I see mLinkHolders is now private, and that Parser::replaceLinkHolders has a deprecation tag in its comment. Is there at this stage a recommended alternative for parsing linkHolders in a string that an extension has? If not, is there any other way to go about doing so, without having to re-parse the entire content within which the links are held?

Naypta mentioned this in T256528: Permit wikitext in captions.Jun 27 2020, 12:03 PM
ssastry moved this task from Non-Parsing-Team Tasks to Current & Upcoming Work on the Parsoid board.Jul 2 2020, 6:40 PM
ssastry added a project: Technical-Debt.Jul 9 2020, 5:06 PM
ssastry moved this task from Todo (Roadmap Critical Path) to Doing (Roadmap Critical Path) on the Parsing-Active-Work board.Aug 25 2020, 5:36 PM
Arlolra moved this task from Current & Upcoming Work to Tech Debt / Big changes on the Parsoid board.Jul 30 2021, 10:19 PM
gerritbot added a comment.Sep 15 2022, 1:13 PM

Change 832494 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Make private deprecated public properties of Parser

https://gerrit.wikimedia.org/r/832494

gerritbot added a project: Patch-For-Review.Sep 15 2022, 1:13 PM
gerritbot added a comment.Sep 20 2022, 12:49 PM

Change 832494 merged by jenkins-bot:

[mediawiki/core@master] Make private deprecated public properties of Parser

https://gerrit.wikimedia.org/r/832494

Aklapper added a comment.Feb 21 2023, 9:43 PM

@cscott: Hi, all related patches in Gerrit have been merged. Can this task be resolved (via Add Action... → Change Status in the dropdown menu), or is there more to do in this task? Asking as you are set as task assignee. Thanks in advance!

Maintenance_bot removed a project: Patch-For-Review.Feb 21 2023, 10:11 PM
Aklapper removed cscott as the assignee of this task.Mar 21 2023, 9:34 AM

@cscott: Removing task assignee as this open task has been assigned for more than two years - See the email sent to task assignee on Feburary 22nd, 2023.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome! :)
If this task has been resolved in the meantime, or should not be worked on by anybody ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!

gerritbot added a comment.Feb 16 2024, 3:43 PM

Change 1004158 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] [Parser] Emit warnings for accesses to deprecated $ot property

https://gerrit.wikimedia.org/r/1004158

gerritbot added a project: Patch-For-Review.Feb 16 2024, 3:43 PM
gerritbot added a comment.Feb 16 2024, 3:54 PM

Change 1004162 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] [Parser] Emit warnings for accesses to deprecated $mTitle property

https://gerrit.wikimedia.org/r/1004162

gerritbot added a comment.Feb 16 2024, 3:55 PM

Change 1004163 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] [Parser] Emit warnings for accesses to deprecated $mOptions property

https://gerrit.wikimedia.org/r/1004163

gerritbot added a comment.Fri, Apr 12, 8:57 PM

Change #1019355 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] [Parser] Mark $mPPNodeCount and $mHighestExpansionDepth @internal

https://gerrit.wikimedia.org/r/1019355

gerritbot added a comment.Sun, Apr 14, 8:27 PM

Change #1004158 merged by jenkins-bot:

[mediawiki/core@master] [Parser] Emit warnings for accesses to deprecated $ot property

https://gerrit.wikimedia.org/r/1004158

gerritbot added a comment.Sun, Apr 14, 10:06 PM

Change #1004162 merged by jenkins-bot:

[mediawiki/core@master] [Parser] Emit warnings for accesses to deprecated $mTitle property

https://gerrit.wikimedia.org/r/1004162

gerritbot added a comment.Sun, Apr 14, 10:06 PM

Change #1004163 merged by jenkins-bot:

[mediawiki/core@master] [Parser] Emit warnings for accesses to deprecated $mOptions property

https://gerrit.wikimedia.org/r/1004163

gerritbot added a comment.Sun, Apr 14, 10:28 PM

Change #1019355 merged by jenkins-bot:

[mediawiki/core@master] [Parser] Mark $mPPNodeCount and $mHighestExpansionDepth @internal

https://gerrit.wikimedia.org/r/1019355

gerritbot added a comment.Mon, Apr 15, 6:52 PM

Change #1019871 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@REL1_42] [Parser] Emit warnings for accesses to deprecated $ot property

https://gerrit.wikimedia.org/r/1019871

gerritbot added a comment.Mon, Apr 15, 6:52 PM

Change #1019872 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@REL1_42] [Parser] Emit warnings for accesses to deprecated $mTitle property

https://gerrit.wikimedia.org/r/1019872

gerritbot added a comment.Mon, Apr 15, 6:52 PM

Change #1019873 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@REL1_42] [Parser] Emit warnings for accesses to deprecated $mOptions property

https://gerrit.wikimedia.org/r/1019873

gerritbot added a comment.Mon, Apr 15, 6:52 PM

Change #1019874 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@REL1_42] [Parser] Mark $mPPNodeCount and $mHighestExpansionDepth @internal

https://gerrit.wikimedia.org/r/1019874

gerritbot added a comment.Tue, Apr 16, 1:21 PM

Change #1019871 merged by jenkins-bot:

[mediawiki/core@REL1_42] [Parser] Emit warnings for accesses to deprecated $ot property

https://gerrit.wikimedia.org/r/1019871

gerritbot added a comment.Tue, Apr 16, 1:21 PM

Change #1019872 merged by jenkins-bot:

[mediawiki/core@REL1_42] [Parser] Emit warnings for accesses to deprecated $mTitle property

https://gerrit.wikimedia.org/r/1019872

gerritbot added a comment.Tue, Apr 16, 1:21 PM

Change #1019873 merged by jenkins-bot:

[mediawiki/core@REL1_42] [Parser] Emit warnings for accesses to deprecated $mOptions property

https://gerrit.wikimedia.org/r/1019873

gerritbot added a comment.Tue, Apr 16, 1:21 PM

Change #1019874 merged by jenkins-bot:

[mediawiki/core@REL1_42] [Parser] Mark $mPPNodeCount and $mHighestExpansionDepth @internal

https://gerrit.wikimedia.org/r/1019874

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL