Page MenuHomePhabricator
Create Task
Maniphest T236813

Magic word implementations should be moved out of Parser.php
Closed, ResolvedPublic
Actions

Description

Parser::expandMagicVariable should be moved into a separate class dedicated to implementation of magic words, much like CoreParserFunctions is the implementation of parser functions.

This will allow use of these magic word implementations from Parsoid.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
WIP DNP: Use the magic word value cache for magic word handlersmediawiki/extensions/ParserFunmaster+2 -2
Deprecate the use of magic variables whose names contain a colonmediawiki/coremaster+7 -0
ParserGetVariableValueSwitchHook: Don't use the cache parametermediawiki/coremaster+12 -23
Remove ParserGetVariableVarCacheHook, deprecated in 1.35mediawiki/coremaster+3 -40
Refactor magic word implementations out of Parser.phpmediawiki/coremaster+412 -385
Deprecate the ParserGetVariableValueVarCache hookmediawiki/coremaster+5 -3
Deprecate unusual uses of the ParserGetVariableValueSwitch hookmediawiki/coremaster+21 -5
Use the magic word value cache for magic word handlersmediawiki/extensions/Wikibasemaster+6 -5
Use the magic word value cache for magic word handlersmediawiki/extensions/BlueSpicePageVersionmaster+4 -4
Use the magic word value cache for magic word handlersmediawiki/extensions/NewsTickermaster+6 -2
Use the magic word value cache for magic word handlersmediawiki/extensions/HitCountersmaster+3 -3
Use the magic word value cache for magic word handlersmediawiki/extensions/InteractiveBlockMessagemaster+7 -7
Use the magic word value cache for magic word handlersmediawiki/extensions/MyVariablesmaster+10 -9
Use the magic word value cache for magic word handlersmediawiki/extensions/S5SlideShowmaster+2 -2
Use the magic word value cache for magic word handlersmediawiki/extensions/WikimediaIncubatormaster+5 -3
Always cache magic word expansionsmediawiki/coremaster+16 -8
Use the magic word value cache for magic word handlersmediawiki/extensions/SubpageFunmaster+14 -2
Use the magic word value cache for magic word handlersmediawiki/extensions/MintyDocsmaster+6 -6
Use the magic word value cache for magic word handlersmediawiki/extensions/OnlineStatusBarmaster+3 -3
Use the magic word value cache for magic word handlersmediawiki/extensions/UILangCodemaster+2 -2
Use the magic word value cache for magic word handlersmediawiki/extensions/FlaggedRevsmaster+2 -2
Use the magic word value cache for magic word handlersmediawiki/extensions/VoteNYmaster+4 -4
Use the magic word value cache for magic word handlersmediawiki/extensions/SiteMatrixmaster+4 -7
Use the magic word value cache for magic word handlersmediawiki/extensions/Commentsmaster+6 -6
Use the magic word value cache for magic word handlersmediawiki/extensions/NumberOfWikismaster+3 -3
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

cscott created this task.Oct 29 2019, 4:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 29 2019, 4:22 PM
cscott added a parent task: T236809: Refactor Parser.php to allow alternate parser (Parsoid).Oct 29 2019, 4:22 PM
ssastry edited projects, added Parsoid; removed Parsoid-PHP.Nov 5 2019, 5:52 PM
ssastry removed a subscriber: Parsing-Team--ARCHIVED.
LGoto moved this task from Needs Triage to Backlog on the Parsoid board.Feb 15 2020, 12:05 AM
LGoto moved this task from Backlog to Non-Parsing-Team Tasks on the Parsoid board.Feb 21 2020, 5:24 PM
gerritbot added a comment.Mar 26 2020, 8:51 PM

Change 583752 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] WIP: Refactor magic word implementations out of Parser.php

https://gerrit.wikimedia.org/r/583752

gerritbot added a project: Patch-For-Review.Mar 26 2020, 8:51 PM
gerritbot added a comment.Mar 26 2020, 10:14 PM

Change 583766 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Always cache magic word expansions

https://gerrit.wikimedia.org/r/583766

gerritbot added a comment.Mar 26 2020, 10:14 PM

Change 583767 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Deprecate the ParserGetVariableValueVarCache hook

https://gerrit.wikimedia.org/r/583767

gerritbot added a comment.Mar 26 2020, 10:14 PM

Change 583768 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Deprecate unusual uses of the ParserGetVariableValueVarSwitch hook

https://gerrit.wikimedia.org/r/583768

DannyS712 awarded a token.Mar 26 2020, 10:30 PM
DannyS712 subscribed.
gerritbot added a comment.Mar 26 2020, 11:25 PM

Change 583785 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/Wikibase@master] Use the magic word value cache for magic word handlers

https://gerrit.wikimedia.org/r/583785

gerritbot added a comment.Mar 26 2020, 11:27 PM

Change 583767 merged by jenkins-bot:
[mediawiki/core@master] Deprecate the ParserGetVariableValueVarCache hook

https://gerrit.wikimedia.org/r/583767

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.26; 2020-03-31).Mar 27 2020, 12:02 AM
gerritbot added a comment.Mar 27 2020, 12:40 AM

Change 583789 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/FlaggedRevs@master] Use the magic word value cache for magic word handlers

https://gerrit.wikimedia.org/r/583789

gerritbot added a comment.Mar 27 2020, 12:44 AM

Change 583790 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/SiteMatrix@master] Use the magic word value cache for magic word handlers

https://gerrit.wikimedia.org/r/583790

gerritbot added a comment.Mar 27 2020, 12:48 AM

Change 583791 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/WikimediaIncubator@master] Use the magic word value cache for magic word handlers

https://gerrit.wikimedia.org/r/583791

gerritbot added a comment.Mar 27 2020, 12:56 AM

Change 583793 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/BlueSpicePageVersion@master] Use the magic word value cache for magic word handlers

https://gerrit.wikimedia.org/r/583793

gerritbot added a comment.Mar 27 2020, 12:58 AM

Change 583794 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/Comments@master] Use the magic word value cache for magic word handlers

https://gerrit.wikimedia.org/r/583794

gerritbot added a comment.Mar 27 2020, 1:01 AM

Change 583795 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/HitCounters@master] Use the magic word value cache for magic word handlers

https://gerrit.wikimedia.org/r/583795

gerritbot added a comment.Mar 27 2020, 1:05 AM

Change 583797 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/NewsTicker@master] Use the magic word value cache for magic word handlers

https://gerrit.wikimedia.org/r/583797

gerritbot added a comment.Mar 27 2020, 1:58 AM

Change 583801 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/S5SlideShow@master] Use the magic word value cache for magic word handlers

https://gerrit.wikimedia.org/r/583801

ssastry subscribed.Mar 27 2020, 2:02 AM

We should chat about the risk profile of this work in the context of covid19.

gerritbot added a comment.Mar 27 2020, 2:03 AM

Change 583802 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/SubpageFun@master] Use the magic word value cache for magic word handlers

https://gerrit.wikimedia.org/r/583802

gerritbot added a comment.Mar 27 2020, 2:10 AM

Change 583803 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/InteractiveBlockMessage@master] Use the magic word value cache for magic word handlers

https://gerrit.wikimedia.org/r/583803

gerritbot added a comment.Mar 27 2020, 2:12 AM

Change 583804 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/MintyDocs@master] Use the magic word value cache for magic word handlers

https://gerrit.wikimedia.org/r/583804

gerritbot added a comment.Mar 27 2020, 2:16 AM

Change 583805 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/MyVariables@master] Use the magic word value cache for magic word handlers

https://gerrit.wikimedia.org/r/583805

gerritbot added a comment.Mar 27 2020, 2:19 AM

Change 583806 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/NumberOfWikis@master] Use the magic word value cache for magic word handlers

https://gerrit.wikimedia.org/r/583806

gerritbot added a comment.Mar 27 2020, 2:20 AM

Change 583807 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/OnlineStatusBar@master] Use the magic word value cache for magic word handlers

https://gerrit.wikimedia.org/r/583807

gerritbot added a comment.Mar 27 2020, 2:25 AM

Change 583808 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/ParserFun@master] WIP DNP: Use the magic word value cache for magic word handlers

https://gerrit.wikimedia.org/r/583808

gerritbot added a comment.Mar 27 2020, 2:26 AM

Change 583809 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/VoteNY@master] Use the magic word value cache for magic word handlers

https://gerrit.wikimedia.org/r/583809

gerritbot added a comment.Mar 27 2020, 3:40 AM

Change 583815 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/UILangCode@master] Use the magic word value cache for magic word handlers

https://gerrit.wikimedia.org/r/583815

gerritbot added a comment.Mar 27 2020, 2:09 PM

Change 583766 merged by jenkins-bot:
[mediawiki/core@master] Always cache magic word expansions

https://gerrit.wikimedia.org/r/583766

gerritbot added a comment.Mar 27 2020, 2:09 PM

Change 583806 merged by jenkins-bot:
[mediawiki/extensions/NumberOfWikis@master] Use the magic word value cache for magic word handlers

https://gerrit.wikimedia.org/r/583806

gerritbot added a comment.Mar 27 2020, 2:12 PM

Change 583794 merged by jenkins-bot:
[mediawiki/extensions/Comments@master] Use the magic word value cache for magic word handlers

https://gerrit.wikimedia.org/r/583794

gerritbot added a comment.Mar 27 2020, 2:20 PM

Change 583790 merged by jenkins-bot:
[mediawiki/extensions/SiteMatrix@master] Use the magic word value cache for magic word handlers

https://gerrit.wikimedia.org/r/583790

gerritbot added a comment.Mar 27 2020, 2:21 PM

Change 583809 merged by jenkins-bot:
[mediawiki/extensions/VoteNY@master] Use the magic word value cache for magic word handlers

https://gerrit.wikimedia.org/r/583809

gerritbot added a comment.Mar 27 2020, 2:21 PM

Change 583789 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Use the magic word value cache for magic word handlers

https://gerrit.wikimedia.org/r/583789

gerritbot added a comment.Mar 27 2020, 2:21 PM

Change 583815 merged by jenkins-bot:
[mediawiki/extensions/UILangCode@master] Use the magic word value cache for magic word handlers

https://gerrit.wikimedia.org/r/583815

gerritbot added a comment.Mar 27 2020, 2:21 PM

Change 583807 merged by jenkins-bot:
[mediawiki/extensions/OnlineStatusBar@master] Use the magic word value cache for magic word handlers

https://gerrit.wikimedia.org/r/583807

gerritbot added a comment.Mar 27 2020, 2:21 PM

Change 583804 merged by jenkins-bot:
[mediawiki/extensions/MintyDocs@master] Use the magic word value cache for magic word handlers

https://gerrit.wikimedia.org/r/583804

gerritbot added a comment.Mar 27 2020, 2:21 PM

Change 583802 merged by jenkins-bot:
[mediawiki/extensions/SubpageFun@master] Use the magic word value cache for magic word handlers

https://gerrit.wikimedia.org/r/583802

cscott mentioned this in rESMXa120d22ba0f0: Use the magic word value cache for magic word handlers.Mar 27 2020, 2:35 PM
cscott mentioned this in rENOWc39650a2799e: Use the magic word value cache for magic word handlers.Mar 27 2020, 2:52 PM
gerritbot added a comment.Mar 27 2020, 4:29 PM

Change 583791 merged by jenkins-bot:
[mediawiki/extensions/WikimediaIncubator@master] Use the magic word value cache for magic word handlers

https://gerrit.wikimedia.org/r/583791

gerritbot added a comment.Mar 27 2020, 4:31 PM

Change 583801 merged by Jforrester:
[mediawiki/extensions/S5SlideShow@master] Use the magic word value cache for magic word handlers

https://gerrit.wikimedia.org/r/583801

gerritbot added a comment.Mar 27 2020, 4:32 PM

Change 583805 merged by jenkins-bot:
[mediawiki/extensions/MyVariables@master] Use the magic word value cache for magic word handlers

https://gerrit.wikimedia.org/r/583805

gerritbot added a comment.Mar 27 2020, 4:32 PM

Change 583803 merged by jenkins-bot:
[mediawiki/extensions/InteractiveBlockMessage@master] Use the magic word value cache for magic word handlers

https://gerrit.wikimedia.org/r/583803

gerritbot added a comment.Mar 27 2020, 4:32 PM

Change 583795 merged by jenkins-bot:
[mediawiki/extensions/HitCounters@master] Use the magic word value cache for magic word handlers

https://gerrit.wikimedia.org/r/583795

gerritbot added a comment.Mar 27 2020, 4:32 PM

Change 583797 merged by jenkins-bot:
[mediawiki/extensions/NewsTicker@master] Use the magic word value cache for magic word handlers

https://gerrit.wikimedia.org/r/583797

gerritbot added a comment.Mar 27 2020, 4:34 PM

Change 583793 merged by jenkins-bot:
[mediawiki/extensions/BlueSpicePageVersion@master] Use the magic word value cache for magic word handlers

https://gerrit.wikimedia.org/r/583793

cscott mentioned this in rEIBMa1e42dff6355: Use the magic word value cache for magic word handlers.Mar 27 2020, 5:00 PM
cscott mentioned this in rEMYV64df1138fa6c: Use the magic word value cache for magic word handlers.
cscott mentioned this in rENWTf1dadb54add8: Use the magic word value cache for magic word handlers.Mar 27 2020, 5:17 PM
cscott mentioned this in rEBSVb1802f66e0df: Use the magic word value cache for magic word handlers.Mar 27 2020, 5:24 PM
gerritbot added a comment.Mar 27 2020, 5:46 PM

Change 583785 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use the magic word value cache for magic word handlers

https://gerrit.wikimedia.org/r/583785

gerritbot added a comment.Mar 27 2020, 5:46 PM

Change 583768 merged by jenkins-bot:
[mediawiki/core@master] Deprecate unusual uses of the ParserGetVariableValueSwitch hook

https://gerrit.wikimedia.org/r/583768

gerritbot added a comment.Apr 22 2020, 8:34 AM

Change 583752 merged by jenkins-bot:
[mediawiki/core@master] Refactor magic word implementations out of Parser.php

https://gerrit.wikimedia.org/r/583752

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.30; 2020-04-28); removed MW-1.35-notes (1.35.0-wmf.26; 2020-03-31).Apr 22 2020, 9:00 AM
cscott closed this task as Resolved.Aug 26 2020, 5:10 PM
cscott claimed this task.
gerritbot added a comment.Aug 12 2022, 5:16 PM

Change 822667 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Remove ParserGetVariableVarCacheHook, deprecated in 1.35

https://gerrit.wikimedia.org/r/822667

gerritbot added a comment.Aug 12 2022, 5:16 PM

Change 822668 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] ParserGetVariableValueSwitchHook: Don't use the cache parameter

https://gerrit.wikimedia.org/r/822668

gerritbot added a comment.Aug 12 2022, 5:23 PM

Change 822670 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Deprecate the use of magic variables whose names contain a colon

https://gerrit.wikimedia.org/r/822670

gerritbot added a comment.Aug 16 2022, 9:49 PM

Change 822667 merged by jenkins-bot:

[mediawiki/core@master] Remove ParserGetVariableVarCacheHook, deprecated in 1.35

https://gerrit.wikimedia.org/r/822667

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.26; 2022-08-22).Aug 16 2022, 10:00 PM
gerritbot added a comment.Aug 16 2022, 10:14 PM

Change 822668 merged by jenkins-bot:

[mediawiki/core@master] ParserGetVariableValueSwitchHook: Don't use the cache parameter

https://gerrit.wikimedia.org/r/822668

gerritbot added a comment.Aug 19 2022, 2:31 PM

Change 822670 merged by jenkins-bot:

[mediawiki/core@master] Deprecate the use of magic variables whose names contain a colon

https://gerrit.wikimedia.org/r/822670

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits