Page MenuHomePhabricator

Add HTTP proxy support to the MachineVision extension
Closed, ResolvedPublic

Description

Outgoing requests from the Wikimedia production environment must go through an HTTP proxy. We need to ensure that outgoing image labeling requests support this.

Looking under the hood of the Cloud Vision PHP client library, it's built around the Guzzle HTTP client library, which accepts a proxy option. If the library provides a reasonable way to configure a proxy option on our image annotation requests, then that's what we should do.

If this isn't reasonably possible, we may have to update the GoogleCloudVisionHandler to make its requests using MwHttpRequest implementations.

Details

Related Gerrit Patches:
mediawiki/extensions/MachineVision : masterUse internal HTTP request abstractions to make Google requests

Event Timeline

Mholloway triaged this task as High priority.Tue, Oct 29, 8:41 PM
Mholloway created this task.

Change 547555 had a related patch set uploaded (by Mholloway; owner: Michael Holloway):
[mediawiki/extensions/MachineVision@master] Use internal HTTP request abstractions to make Google requests

https://gerrit.wikimedia.org/r/547555

Change 547555 merged by jenkins-bot:
[mediawiki/extensions/MachineVision@master] Use internal HTTP request abstractions to make Google requests

https://gerrit.wikimedia.org/r/547555

Mholloway closed this task as Resolved.Tue, Nov 5, 4:50 PM

Mentioned in SAL (#wikimedia-operations) [2019-11-06T15:47:13Z] <mholloway-shell@deploy1001> Synchronized wmf-config/CommonSettings.php: MachineVision: Use an HTTP proxy in production (T236843) (duration: 01m 01s)