In resources/ext.centralNotice.display/index.js: improve loop logic so we don't have to null out the local campaign variable.
This involves passing all responsibility for keeping track of campaign selection states to the state component of the display module; this is in line with current separation of concerns in that module.
(Spun out from T234248.)
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Campaign fallback follow-up: refactor data handling and some methods | mediawiki/extensions/CentralNotice | master | +231 -136 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T124969 Can we allow fallback to alternative campaign if mixin would hide this one | |||
| Open | None | T236845 Still one more small fix needed for Campaign fallback: local campaign variable. |
Change 623314 had a related patch set uploaded (by AndyRussG; owner: AndyRussG):
[mediawiki/extensions/CentralNotice@master] WIP First attempt at fixing state and fallback
Change 623314 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Campaign fallback follow-up: refactor data handling and some methods
@AndyRussG: Removing task assignee as this open task has been assigned for more than two years - See the email sent to task assignee on Feburary 22nd, 2023.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome! :)
If this task has been resolved in the meantime, or should not be worked on by anybody ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!