Page MenuHomePhabricator

Still one more small fix needed for Campaign fallback: local campaign variable.
Open, Needs TriagePublic2 Estimated Story Points

Description

In resources/ext.centralNotice.display/index.js: improve loop logic so we don't have to null out the local campaign variable.

This involves passing all responsibility for keeping track of campaign selection states to the state component of the display module; this is in line with current separation of concerns in that module.

(Spun out from T234248.)

Event Timeline

AndyRussG renamed this task from Still one more small fixe needed for Campaign fallback: local campaign variable. to Still one more small fix needed for Campaign fallback: local campaign variable..Oct 29 2019, 8:54 PM
AndyRussG updated the task description. (Show Details)
AndyRussG set the point value for this task to 2.

Change 623314 had a related patch set uploaded (by AndyRussG; owner: AndyRussG):
[mediawiki/extensions/CentralNotice@master] WIP First attempt at fixing state and fallback

https://gerrit.wikimedia.org/r/623314

Change 623314 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Campaign fallback follow-up: refactor data handling and some methods

https://gerrit.wikimedia.org/r/623314