Wire Open Action to TaintedIcon click
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tarrow
	Oct 30 2019, 10:58 AM

Project Tags

Referenced Files

None

Subscribers

Aklapper

Lydia_Pintscher

Tarrow

Description

Notes: Consider using a pattern similar to EventEmittingButton from Termbox.

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	TaintedIcon: Trigger POPPER_SHOW on click	Hoo man	mediawiki/extensions/Wikibase	master	+75 -15

Customize query in gerrit

Event Timeline

Tarrow created this task.Oct 30 2019, 10:58 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 30 2019, 10:58 AM

hoo claimed this task.Oct 31 2019, 12:05 PM

hoo moved this task from To Do to Doing on the Wikidata-Tainted-References-Sprint4 board.

Change 547728 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] TaintedIcon: Trigger POPPER_SHOW on click

https://gerrit.wikimedia.org/r/547728

gerritbot added a project: Patch-For-Review.Nov 1 2019, 12:40 PM

hoo moved this task from Doing to Peer Review on the Wikidata-Tainted-References-Sprint4 board.Nov 1 2019, 12:42 PM

Change 547728 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] TaintedIcon: Trigger POPPER_SHOW on click

https://gerrit.wikimedia.org/r/547728

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.5; 2019-11-05).Nov 5 2019, 11:00 AM

Maintenance_bot removed a project: Patch-For-Review.Nov 5 2019, 11:10 AM

hoo moved this task from Peer Review to Test (Product Review) on the Wikidata-Tainted-References-Sprint4 board.Nov 5 2019, 9:13 PM

This is in verification but I don't think I can verify this. Close?

In T236888#5638230, @Lydia_Pintscher wrote:

This is in verification but I don't think I can verify this. Close?

Fair enough, yes.

Wire Open Action to TaintedIcon clickClosed, ResolvedPublicActions

Description

Details

Event Timeline

Wire Open Action to TaintedIcon click
Closed, ResolvedPublic
Actions