Page MenuHomePhabricator

Use elastic for SpecialEntitiesWithoutPage (EntitiesWithoutTermFinder)
Open, HighPublic8 Story Points

Description

Decided elastic will be used in T194144#5617328, no SQL fallback will be provided, per decision in T194144#5618865.

Task
The two special pages Special:EntitiesWithoutLabel and Special:EntitiesWithoutDescription should redirect to search page

Example query {T194144#5618726}:
https://www.wikidata.org/w/index.php?search=-haslabel%3A*+-hasdescription%3A*+-haswbstatement%3A*

Acceptance Critera

  • Special:EntitiesWithoutLabel and Special:EntitiesWithoutDescription redirect to search page
  • Move current specialpage Special:EntitiesWithoutLabel and Special:EntitiesWithoutDescription to CirrusSearch extension. This both will improve decoupling (Wikibase -> CirrusSearch) and will make those special pages available only when elastic is available automatically.
  • Double check how to move i18n msgs to CirrusSearch extension

Details

Related Gerrit Patches:
mediawiki/extensions/Wikibase : masterMove SpecialEntitiesWithoutPage out of Wikibase to WikibaseCirrusSearch
mediawiki/extensions/WikibaseCirrusSearch : masterMove SpecialEntitiesWithoutPage from Wikibase to here

Event Timeline

Addshore created this task.Wed, Oct 30, 1:19 PM
Restricted Application added a project: Wikidata. · View Herald TranscriptWed, Oct 30, 1:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Yeah show them a short message elastic is needed of it's not available.

Addshore updated the task description. (Show Details)Thu, Oct 31, 7:26 AM
Addshore raised the priority of this task from Normal to High.Tue, Nov 5, 12:03 PM
Addshore set the point value for this task to 13.Tue, Nov 5, 1:09 PM
Addshore moved this task from Ready to estimate to Ready to pick up on the Wikidata-Campsite board.

@Lydia_Pintscher it seems there might be a need for some clarification on what should be done here, hinted @Ladsgroup . This task talks about using elastic search as the search backed for the existing special page, whereas T194144#5617328 was considering changing how the special page looks/works. Any comments/thoughts on what's should happen?

Keeping the interaction/look of the special page as it is now and just changing the underlying tech pieces would be preferred. But if that's too much work then let's simplify it and do T194144#5617328. Does timeboxing this to 3 days sound reasonable to make this call?

Based on discussion in story time today we decided to go with the redirect. We keep the existing form on the special page.

alaa_wmde updated the task description. (Show Details)Tue, Nov 12, 1:48 PM
alaa_wmde changed the point value for this task from 13 to 8.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptWed, Nov 13, 3:42 PM

Change 550731 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Move SpecialEntitiesWithoutPage out of Wikibase to WikibaseCirrusSearch

https://gerrit.wikimedia.org/r/550731

Change 550732 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/WikibaseCirrusSearch@master] Move SpecialEntitiesWithoutPage from Wikibase to here

https://gerrit.wikimedia.org/r/550732

Change 550731 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Move SpecialEntitiesWithoutPage out of Wikibase to WikibaseCirrusSearch

https://gerrit.wikimedia.org/r/550731

Change 550732 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@master] Move SpecialEntitiesWithoutPage from Wikibase to here

https://gerrit.wikimedia.org/r/550732

Lydia_Pintscher added a subscriber: Lea_Lacroix_WMDE.

\o/
Moving to announcement column for @Lea_Lacroix_WMDE. I sent her an email with details.