Page MenuHomePhabricator
Create Task
Maniphest T236901

Use elastic for SpecialEntitiesWithoutPage (EntitiesWithoutTermFinder)
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Decided elastic will be used in T194144#5617328, no SQL fallback will be provided, per decision in T194144#5618865.

Task
The two special pages Special:EntitiesWithoutLabel and Special:EntitiesWithoutDescription should redirect to search page

Example query {T194144#5618726}:
https://www.wikidata.org/w/index.php?search=-haslabel%3A*+-hasdescription%3A*+-haswbstatement%3A*

Acceptance Critera

  • Special:EntitiesWithoutLabel and Special:EntitiesWithoutDescription redirect to search page
  • Move current specialpage Special:EntitiesWithoutLabel and Special:EntitiesWithoutDescription to CirrusSearch extension. This both will improve decoupling (Wikibase -> CirrusSearch) and will make those special pages available only when elastic is available automatically.
  • Double check how to move i18n msgs to CirrusSearch extension

Details

SubjectRepoBranchLines +/-
Rename message keys for SpecialEntitiesWithoutPagemediawiki/extensions/WikibaseCirrusSearchmaster+33 -33
Move SpecialEntitiesWithoutPage out of Wikibase to WikibaseCirrusSearchmediawiki/extensions/Wikibasemaster+0 -1 K
Move SpecialEntitiesWithoutPage from Wikibase to heremediawiki/extensions/WikibaseCirrusSearchmaster+669 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Addshore created this task.Oct 30 2019, 1:19 PM
Restricted Application added a project: Wikidata. · View Herald TranscriptOct 30 2019, 1:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Addshore triaged this task as Medium priority.Oct 30 2019, 1:19 PM
Addshore mentioned this in T194144: Find a solution for SpecialEntitiesWithoutPage (EntitiesWithoutTermFinder).
Addshore moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.
Addshore added a subscriber: Ladsgroup.
Lydia_Pintscher subscribed.Oct 30 2019, 1:31 PM

Yeah show them a short message elastic is needed of it's not available.

Addshore moved this task from incoming to consider for next sprint on the Wikidata board.Oct 30 2019, 1:46 PM
Addshore updated the task description. (Show Details)Oct 31 2019, 7:26 AM
Addshore added a parent task: T236979: Fix remaining usecases still reading from old wb_terms schema.Oct 31 2019, 7:33 AM
Addshore mentioned this in T208425: [EPIC] Kill the wb_terms table.Oct 31 2019, 7:44 AM
Addshore raised the priority of this task from Medium to High.Nov 5 2019, 12:03 PM
Addshore set the point value for this task to 13.Nov 5 2019, 1:09 PM
Addshore moved this task from Ready to estimate to Ready to pick up on the Wikidata-Campsite board.
WMDE-leszek subscribed.Nov 8 2019, 4:26 PM

@Lydia_Pintscher it seems there might be a need for some clarification on what should be done here, hinted @Ladsgroup . This task talks about using elastic search as the search backed for the existing special page, whereas T194144#5617328 was considering changing how the special page looks/works. Any comments/thoughts on what's should happen?

Lydia_Pintscher added a comment.Nov 9 2019, 2:49 AM

Keeping the interaction/look of the special page as it is now and just changing the underlying tech pieces would be preferred. But if that's too much work then let's simplify it and do T194144#5617328. Does timeboxing this to 3 days sound reasonable to make this call?

Lydia_Pintscher added a comment.Nov 12 2019, 1:20 PM

Based on discussion in story time today we decided to go with the redirect. We keep the existing form on the special page.

• alaa_wmde updated the task description. (Show Details)Nov 12 2019, 1:48 PM
• alaa_wmde changed the point value for this task from 13 to 8.
Ladsgroup claimed this task.Nov 13 2019, 3:42 PM
Ladsgroup edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptNov 13 2019, 3:42 PM
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 13 2019, 3:42 PM
Maintenance_bot moved this task from Incoming to In progress on the User-Ladsgroup board.Nov 13 2019, 4:15 PM
gerritbot added a comment.Nov 13 2019, 6:01 PM

Change 550731 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Move SpecialEntitiesWithoutPage out of Wikibase to WikibaseCirrusSearch

https://gerrit.wikimedia.org/r/550731

gerritbot added a project: Patch-For-Review.Nov 13 2019, 6:01 PM
gerritbot added a comment.Nov 13 2019, 6:04 PM

Change 550732 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/WikibaseCirrusSearch@master] Move SpecialEntitiesWithoutPage from Wikibase to here

https://gerrit.wikimedia.org/r/550732

Ladsgroup moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 13 2019, 6:49 PM
Addshore moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 18 2019, 3:31 PM
gerritbot added a comment.Nov 18 2019, 3:48 PM

Change 550731 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Move SpecialEntitiesWithoutPage out of Wikibase to WikibaseCirrusSearch

https://gerrit.wikimedia.org/r/550731

gerritbot added a comment.Nov 18 2019, 3:56 PM

Change 550732 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@master] Move SpecialEntitiesWithoutPage from Wikibase to here

https://gerrit.wikimedia.org/r/550732

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.8; 2019-11-26).Nov 18 2019, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 18 2019, 4:10 PM
Ladsgroup mentioned this in rEWCSa08a2b9d0b03: Move SpecialEntitiesWithoutPage from Wikibase to here.Nov 18 2019, 4:22 PM
Lydia_Pintscher moved this task from Test (Verification) to Needs Announcement on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 19 2019, 6:50 PM
Lydia_Pintscher added a subscriber: Lea_Lacroix_WMDE.

\o/
Moving to announcement column for @Lea_Lacroix_WMDE. I sent her an email with details.

gerritbot added a comment.Nov 25 2019, 12:36 PM

Change 552796 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/WikibaseCirrusSearch@master] Rename message keys for SpecialEntitiesWithoutPage

https://gerrit.wikimedia.org/r/552796

gerritbot added a project: Patch-For-Review.Nov 25 2019, 12:36 PM
gerritbot added a comment.Nov 26 2019, 9:59 AM

Change 552796 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@master] Rename message keys for SpecialEntitiesWithoutPage

https://gerrit.wikimedia.org/r/552796

Ladsgroup mentioned this in rEWCSd5f6886b6e65: Rename message keys for SpecialEntitiesWithoutPage.Nov 26 2019, 10:11 AM
Maintenance_bot removed a project: Patch-For-Review.Nov 26 2019, 11:50 AM
Bugreporter mentioned this in T168791: Remove "item" option from Special:EntitiesWithoutLabel etc..Dec 2 2019, 4:28 PM
Bugreporter mentioned this in T90098: [Bug] Special:EntitiesWithoutLabel shouldn't use numerical offsets.
Bugreporter mentioned this in T207653: Don't use offset in limit in Special:EntitiesWithoutTermFinder.
Lydia_Pintscher closed this task as Resolved.Dec 12 2019, 9:31 AM
Lydia_Pintscher moved this task from Needs Announcement to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

\o/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits