Page MenuHomePhabricator
Create Task
Maniphest T236902

Spike: Check book ref. compatibility with the REST API endpoint
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

There is a REST API endpoint at https://en.wikipedia.org/api/rest_v1/#/Page%20content/getContent-references that extracts references from a page (either from the current or an old revision). This was implemented for the mobile skin and/or mobile apps.

To do:

  • Make sure our extension does not break this API.
  • We might need to expand this API, so users can see which references belong to each other (which is a sub of which) in the API's JSON response. This might need consultation with the WMF team originally responsible for the implementation.

Related Objects

Event Timeline

thiemowmde created this task.Oct 30 2019, 1:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 30 2019, 1:45 PM
• mobrovac edited projects, added Page Content Service; removed RESTBase-API.Nov 5 2019, 11:37 AM
Restricted Application added a project: Product-Infrastructure-Team-Backlog-Deprecated. · View Herald TranscriptNov 5 2019, 11:37 AM
JoeWalsh moved this task from Needs triage to Tracking on the Product-Infrastructure-Team-Backlog-Deprecated board.Nov 6 2019, 4:37 PM
awight renamed this task from Check book ref. compatibility with the REST API endpoint to Spike: Check book ref. compatibility with the REST API endpoint.Nov 12 2019, 12:48 PM
awight moved this task from Backlog to Default version backlog on the Cite-Extends board.
thiemowmde set the point value for this task to 8.Nov 26 2019, 12:36 PM
thiemowmde added a parent task: T239228: Make the ReferencePreviews feature of Popups compatible with BookReferencing.Nov 26 2019, 12:45 PM
thiemowmde removed a parent task: T239228: Make the ReferencePreviews feature of Popups compatible with BookReferencing.Jan 15 2020, 6:48 PM
thiemowmde added a comment.Jan 15 2020, 6:50 PM

In todays meeting with WMF it was said the RESTBase stuff will not be supported any more, and some day be removed. It is already not used any more in the MobileFrontend codebase (which is why I removed this from T239228).

WMDE-Fisch closed this task as Declined.Jan 21 2020, 3:07 PM
In T236902#5806770, @thiemowmde wrote:

In todays meeting with WMF it was said the RESTBase stuff will not be supported any more, and some day be removed. It is already not used any more in the MobileFrontend codebase (which is why I removed this from T239228).

Due to that comment I will mark this ticket invalid now. There seem to be no need for us to support compatibility here.

thiemowmde added a comment.Jan 21 2020, 4:10 PM

I agree we don't need to make the extends feature available via the REST API. But we need to make sure our changes do not break the API. As far as I remember we checked this already. To be sure I checked again:

It succeeds and returns all 4 references from the page, just as 4 independent top-level references. The last one shows "S.128-129", for example.

thiemowmde changed the task status from Declined to Resolved.Jan 21 2020, 4:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL