Page MenuHomePhabricator

Closing the Media/Gallery/Basic Reference dialog without closing the inspector inside it, throws error "Uncaught TypeError: Cannot read property 'getView' of nul"
Closed, ResolvedPublic

Description

Steps to replicate:

  1. Open VE
  2. Open Media/Gallery/Basic reference dialog
  3. Open link inspector or any other inspector inside it
  4. Without closing the inspector, close the main dialog the following error appears in the console

Found on Beta and test wiki.

Details

Related Gerrit Patches:
mediawiki/extensions/Cite : masterve.ui.MWReferenceDialog: Avoid exception when destroying
mediawiki/extensions/VisualEditor : masterUpdate VE core submodule to master (c6b5e46fa)
VisualEditor/VisualEditor : masterve.ui.TargetWidget: Avoid exception when destroying widgets

Event Timeline

Ryasmeen created this task.Oct 30 2019, 8:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 30 2019, 8:00 PM
Ryasmeen renamed this task from Closing the Media/Gallery/Basic Reference dialog without closing the inspector inside it, throws error "VM18:71 Uncaught TypeError: Cannot read property 'getView' of nul" to Closing the Media/Gallery/Basic Reference dialog without closing the inspector inside it, throws error "Uncaught TypeError: Cannot read property 'getView' of nul".Oct 30 2019, 8:21 PM

Change 550573 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] ve.ui.TargetWidget: Avoid exception when destroying widgets

https://gerrit.wikimedia.org/r/550573

Change 550573 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] ve.ui.TargetWidget: Avoid exception when destroying widgets

https://gerrit.wikimedia.org/r/550573

Change 552087 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c6b5e46fa)

https://gerrit.wikimedia.org/r/552087

Change 552087 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c6b5e46fa)

https://gerrit.wikimedia.org/r/552087

Getting the following error still when closing out the Basic Reference dialog with link inspector being open inside it:
Uncaught TypeError: Cannot read property 'getDocument' of null

My bad, I thought the issue fixed by the previous patch was the only one, but it turns out there's one more issue specific to the reference dialog, which I haven't tested.

Change 553514 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/Cite@master] ve.ui.MWReferenceDialog: Avoid exception when destroying

https://gerrit.wikimedia.org/r/553514

Change 553514 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] ve.ui.MWReferenceDialog: Avoid exception when destroying

https://gerrit.wikimedia.org/r/553514

ppelberg closed this task as Resolved.Dec 24 2019, 6:34 PM
ppelberg claimed this task.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptDec 24 2019, 6:34 PM