Page MenuHomePhabricator
Create Task
Maniphest T236979

Fix remaining usecases still reading from old wb_terms schema
Closed, DuplicatePublic
Actions

Details

SubjectRepoBranchLines +/-
wbterms: deprecate WBC::getPropertyTermIndex & remove leftoversmediawiki/extensions/Wikibasemaster+7 -12
wbterms: Rename BufferingTermLookup to include Termindex for claritymediawiki/extensions/Wikibasemaster+22 -20
Customize query in gerrit

Related Objects
Search...

Event Timeline

Addshore created this task.Oct 31 2019, 7:32 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 31 2019, 7:32 AM
Addshore renamed this task from Fix remaining usecases for new termstore schema reading to Fix remaining usecases still reading from old wb_terms schema.Oct 31 2019, 7:33 AM
Addshore triaged this task as High priority.
Addshore added a parent task: T208425: [EPIC] Kill the wb_terms table.
Addshore added a subtask: T236901: Use elastic for SpecialEntitiesWithoutPage (EntitiesWithoutTermFinder).
Addshore added a subtask: T205194: Make sure EntityLinkFormatter implementations not use wb_terms table.Oct 31 2019, 7:36 AM
Addshore added a subtask: T236681: SqlEntityInfoBuilder reads and writes from the old term store regardless of the config.
Addshore added a subtask: T232040: Add label and description collision detectors for new terms store.
Addshore mentioned this in T208425: [EPIC] Kill the wb_terms table.Oct 31 2019, 7:44 AM
Addshore moved this task from incoming to in progress on the Wikidata board.Nov 1 2019, 8:50 AM
Addshore closed subtask T205194: Make sure EntityLinkFormatter implementations not use wb_terms table as Resolved.Dec 5 2019, 11:24 AM
Lydia_Pintscher closed subtask T236901: Use elastic for SpecialEntitiesWithoutPage (EntitiesWithoutTermFinder) as Resolved.Dec 12 2019, 9:31 AM
Addshore closed subtask T236681: SqlEntityInfoBuilder reads and writes from the old term store regardless of the config as Resolved.Dec 23 2019, 1:03 PM
Addshore added a subtask: T242326: Wikibase Client PageTerms api module should not use SqlTermIndex directly.Jan 9 2020, 9:32 AM
gerritbot added a comment.Jan 9 2020, 9:57 AM

Change 563141 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] wbterms, deprecate WBC::getPropertyTermIndex & remove leftovers

https://gerrit.wikimedia.org/r/563141

gerritbot added a project: Patch-For-Review.Jan 9 2020, 9:58 AM
gerritbot added a comment.Jan 10 2020, 8:43 AM

Change 563376 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] wbterms: Rename BufferingTermLookup to include Termindex for clarity

https://gerrit.wikimedia.org/r/563376

gerritbot added a comment.Jan 10 2020, 12:25 PM

Change 563376 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] wbterms: Rename BufferingTermLookup to include Termindex for clarity

https://gerrit.wikimedia.org/r/563376

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.15; 2020-01-14).Jan 10 2020, 1:00 PM
gerritbot added a comment.Jan 13 2020, 11:30 AM

Change 563141 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] wbterms: deprecate WBC::getPropertyTermIndex & remove leftovers

https://gerrit.wikimedia.org/r/563141

Maintenance_bot removed a project: Patch-For-Review.Jan 13 2020, 12:11 PM
Addshore closed subtask T232040: Add label and description collision detectors for new terms store as Resolved.Jan 15 2020, 4:59 PM
Addshore closed subtask T242326: Wikibase Client PageTerms api module should not use SqlTermIndex directly as Resolved.Jan 15 2020, 5:08 PM
Addshore added a subtask: T242095: TermSearchInteractor should have a new implementation supporting new terms storage.

The one subtask remaining is only needed for Wikibase but not actually for wikidata.org to finish its migration.

Addshore closed this task as a duplicate of T219303: [Checkpoint 5] Update Read Logic.Jan 16 2020, 9:20 AM
Addshore edited parent tasks, added: T219303: [Checkpoint 5] Update Read Logic; removed: T208425: [EPIC] Kill the wb_terms table.
Addshore closed subtask T242095: TermSearchInteractor should have a new implementation supporting new terms storage as Resolved.Jan 24 2020, 10:20 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL