Page MenuHomePhabricator
Create Task
Maniphest T237045

Long-press on Edit icon causes a crash
Closed, ResolvedPublic
Actions

Description

On 6.4.1 (1686) on iPhone X on 13.2

Steps:

  1. Long-press an edit icon (default, protected, and semi-protected)

Expected Result:
Nothing

Actual Result:
Crash

Result:
Crash

5/5 Times on iPhone

Note - Does not happen Ipad Pro on iOS 13.2 and also does not happen on iPhone 7 on iOS 12.4.1

Event Timeline

ABorbaWMF created this task.Oct 31 2019, 6:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 31 2019, 6:09 PM
ABorbaWMF updated the task description. (Show Details)Oct 31 2019, 7:39 PM
JoeWalsh subscribed.Oct 31 2019, 8:15 PM

This was fixed in 1687 but it looks like it's now previewing links we don't want to preview, PR for that here: https://github.com/wikimedia/wikipedia-ios/pull/3313

ABorbaWMF closed this task as Resolved.Oct 31 2019, 8:43 PM
ABorbaWMF claimed this task.

Yes, no crash now. It looks like I was a build behind on the iphone. Are we good with the behavior? It is linking to the Edit Pencil article.

JoeWalsh added a comment.Oct 31 2019, 8:55 PM

Fix for the WMFEditPencil article issue coming in 1688

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL