Page MenuHomePhabricator
Create Task
Maniphest T237068

Dev: Optimize ApiQueryPageImages::getTitles
Closed, ResolvedPublic
Actions

Description

Retroactively creating this phab task from the gerrit patch to make it more visible:

Avoid array_map/array_flip + foreach when doing the simple thing also in the foreach

Swap Title::newFromText to Title::makeTitle to avoid reparsing the string

Details

SubjectRepoBranchLines +/-
Optimize ApiQueryPageImages::getTitlesmediawiki/extensions/PageImagesmaster+10 -15
Customize query in gerrit

Event Timeline

Jdlrobson created this task.Oct 31 2019, 11:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 31 2019, 11:08 PM
gerritbot added a comment.Oct 31 2019, 11:08 PM

Change 547652 had a related patch set uploaded (by Jdlrobson; owner: Umherirrender):
[mediawiki/extensions/PageImages@master] Optimize ApiQueryPageImages::getTitles

https://gerrit.wikimedia.org/r/547652

gerritbot added a project: Patch-For-Review.Oct 31 2019, 11:08 PM
Jdlrobson added a subscriber: Umherirrender.Oct 31 2019, 11:08 PM

Patch from @Umherirrender to review.

gerritbot added a comment.Nov 1 2019, 2:17 AM

Change 547652 merged by jenkins-bot:
[mediawiki/extensions/PageImages@master] Optimize ApiQueryPageImages::getTitles

https://gerrit.wikimedia.org/r/547652

Maintenance_bot removed a project: Patch-For-Review.Nov 1 2019, 3:10 AM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.5; 2019-11-05).Nov 1 2019, 5:01 PM
Umherirrender closed this task as Resolved.Nov 1 2019, 11:03 PM
Umherirrender claimed this task.
Umherirrender triaged this task as Medium priority.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL