The post-rotate script implemented in rOPUPfece35d5ddb4: toolforge: process dynamicproxy access logs has not added new rows to s53734__toolviews_p.daily_raw_views since 2019-10-28. Likely an unintended side effect of T235627: Toolforge: upgrade main proxy servers to Debian Buster
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| toolforge: Update toolviews.py for ldap3 v2.4.1 | operations/puppet | production | +19 -28 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | bd808 | T166406 Program 10 Outcome 3: Outreach | |||
| Resolved | Quiddity | T176677 Promote Toolforge Tools and their maintainers within Wikimedia communities | |||
| Open | None | T178834 Provide any rough metrics for tool and project usage | |||
| Open | None | T129630 Collect and display basic metrics for all tools (service groups) | |||
| In Progress | MusikAnimal | T87001 Provide basic page view metrics for individual tools on toolforge | |||
| Resolved | bd808 | T237080 Toolviews data loading from Toolforge front proxy access log stopped on 2019-10-28 |
Event Timeline
Comment Actions
$ sudo journalctl /usr/sbin/logrotate --no-pager -- Logs begin at Thu 2019-10-31 21:57:55 UTC, end at Fri 2019-11-01 02:17:24 UTC. -- Nov 01 00:00:55 tools-proxy-05 logrotate[13051]: Traceback (most recent call last): Nov 01 00:00:55 tools-proxy-05 logrotate[13051]: File "/usr/local/bin/toolviews.py", line 242, in <module> Nov 01 00:00:55 tools-proxy-05 logrotate[13051]: main() Nov 01 00:00:55 tools-proxy-05 logrotate[13051]: File "/usr/local/bin/toolviews.py", line 237, in main Nov 01 00:00:55 tools-proxy-05 logrotate[13051]: stats = ToolViews(config, args.dry_run) Nov 01 00:00:55 tools-proxy-05 logrotate[13051]: File "/usr/local/bin/toolviews.py", line 63, in __init__ Nov 01 00:00:55 tools-proxy-05 logrotate[13051]: self.tools = self.get_tools() Nov 01 00:00:55 tools-proxy-05 logrotate[13051]: File "/usr/local/bin/toolviews.py", line 71, in get_tools Nov 01 00:00:55 tools-proxy-05 logrotate[13051]: ], ldap3.POOLING_STRATEGY_ROUND_ROBIN, active=True, exhaust=True), Nov 01 00:00:55 tools-proxy-05 logrotate[13051]: AttributeError: module 'ldap3' has no attribute 'POOLING_STRATEGY_ROUND_ROBIN' Nov 01 00:00:55 tools-proxy-05 logrotate[13051]: run-parts: /etc/logrotate.d/nginx-postrotate/toolviews exited with return code 1 Nov 01 00:00:55 tools-proxy-05 logrotate[13051]: error: error running shared postrotate script for '/var/log/nginx/*.log '
$ python3 Python 3.7.3 (default, Apr 3 2019, 05:39:12) [GCC 8.3.0] on linux Type "help", "copyright", "credits" or "license" for more information. >>> import ldap3 >>> ldap3.__version__ '2.4.1'
Our first confirmation of T214541: python3-ldap3 mixed versions and future traps!
Comment Actions
Change 547700 had a related patch set uploaded (by BryanDavis; owner: Bryan Davis):
[operations/puppet@production] toolforge: Update toolviews.py for ldap3 v2.4.1
Comment Actions
Change 547700 merged by Phamhi:
[operations/puppet@production] toolforge: Update toolviews.py for ldap3 v2.4.1